From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6280C4706C for ; Fri, 12 Jan 2024 17:23:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 048BD6B0092; Fri, 12 Jan 2024 12:23:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3AE88D0001; Fri, 12 Jan 2024 12:23:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E02406B0095; Fri, 12 Jan 2024 12:23:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CFD9A6B0092 for ; Fri, 12 Jan 2024 12:23:50 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 90CA040CED for ; Fri, 12 Jan 2024 17:23:50 +0000 (UTC) X-FDA: 81671331420.21.9AE4957 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id 3B2FD4000B for ; Fri, 12 Jan 2024 17:23:47 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=coh+Fnu1; dkim=pass header.d=suse.com header.s=susede1 header.b=coh+Fnu1; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705080228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xHxzNkl3+lg5RxMKF+f20439C0qvkhGvp+j1/UrE0ss=; b=r1QZ2rdfm6arijtME9rM4u5sssoi5q3jx/ug5+OfYYUta/K97+TWHpxw5Acr7gHO2utdP7 AeKrJh5WScu1C8YLjMwi76oJUeMxJbznlShsf/FqKU1OGvt6ZzU9C4ILnJr23pv16wzelb Q+TPGI85QbH4gqnRItI8HbTuyTIfR4c= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=coh+Fnu1; dkim=pass header.d=suse.com header.s=susede1 header.b=coh+Fnu1; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705080228; a=rsa-sha256; cv=none; b=2VosYkYpoWnesdt/mWbpACEkfWvp1PTAwPOriPoVGWy/d6vUE8oF1YVI3nef8BEC952ewi gaUF7/KCbOkg/TzVt2/NNUr7a7VFyIA5nVyuu926f6f68Pkcct8r5wO1hzTpeeucBmTg/A kSqCh0Zw9U5unkb6NkuigAkoSAvQn3s= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 145DF1F396; Fri, 12 Jan 2024 17:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705080226; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xHxzNkl3+lg5RxMKF+f20439C0qvkhGvp+j1/UrE0ss=; b=coh+Fnu1UJz13gGiunWRvCcSzWJD2fwZrkHJ5sUDzW6vhjdNim8KWDD2ba23fDxBMIh1lB Jp5SehF/gfoh3YoHmxoQ9FtbDGLOeqgz3mVfxnA2nOI4th84z5IY4S80dEy8XvzzBee4jM BbATxr1ambWoEyMxadVor+ufkHahK20= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705080226; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xHxzNkl3+lg5RxMKF+f20439C0qvkhGvp+j1/UrE0ss=; b=coh+Fnu1UJz13gGiunWRvCcSzWJD2fwZrkHJ5sUDzW6vhjdNim8KWDD2ba23fDxBMIh1lB Jp5SehF/gfoh3YoHmxoQ9FtbDGLOeqgz3mVfxnA2nOI4th84z5IY4S80dEy8XvzzBee4jM BbATxr1ambWoEyMxadVor+ufkHahK20= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EAE3E136A4; Fri, 12 Jan 2024 17:23:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uTxdNqF1oWW+OAAAD6G6ig (envelope-from ); Fri, 12 Jan 2024 17:23:45 +0000 Date: Fri, 12 Jan 2024 18:23:45 +0100 From: Michal Hocko To: Roman Gushchin Cc: Johannes Weiner , Andrew Morton , Shakeel Butt , Muchun Song , Tejun Heo , Dan Schatzberg , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: don't throttle dying tasks on memory.high Message-ID: References: <20240111132902.389862-1-hannes@cmpxchg.org> <20240111192807.GA424308@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: / X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3B2FD4000B X-Stat-Signature: fis7icuozks5ss6jhoe6j4tehig7eidj X-HE-Tag: 1705080227-100675 X-HE-Meta: U2FsdGVkX1+k4dqa79b35+h2Gn4tK69TWVXShEI6Sr2qHxU9fAvdiUcUwGGm3kmvv5+9Wmpls5EvWChnsr/V1fHhhfXSFBCWrv3t3KC08EcnWPfhtIN4CHnT9xrVzoPZy+lsYljc36et3LkZmLA9o7iskVee8DPxW/Hw+y5vjqoDBoVNOmgSNlGFoJlh/dyDdvcODdBYW9EGOi0PryPSGYUKviSyees7uUmS500u/c4VrdLuD2Aaaho9LznHu7rVvLXeJ33Khq0PAWiX4u1cH2QARIb+MH9Ry+wNYZuwPdrGpJEBGscGchpeLQPfMEVsrgRJFf/emMxNYMYBMp7wfyKOKgOXAF8x3o6Za+algHhKL4QCiIYjfvBLBhqBBg4gv8CQtXToJLTTi697sYsdMw3uIF+y4JnxSXyFbvcKgH+LKRZ8Ezh9wFmc3PUB9NEZj2qqVMYgJFjiIALevtIjyt/C5D0iwb1DxXIaCIIJR0U6SeWyfLrGda7bwGi5ZQp5etrsWBp/w6f/LbjgD6WhZ58STNonxDb8NWPgHxknYXQl5b/8DCnxnm67Dy66SKrjx3ykr6jlCIdb3bxycnTuQISU6B5HN5C/Jrj+W+iavdREMBOB4qr7rtT3i/YvyThhRSC+jjjUiW9TplpjSxLI0h4AI0uQFctYfkJ8yg7pZaznRaL+qxVc6jLmXAMnO0Q9pO5UZYa8d55rP3+bQAIxYlZ4fQLa3+kIglM13RqTWXXVLL3byYqpLg4Me5Ww2AP1hJCxyTvtVC7aHzkmxfgND3hJhI98/qb0j8mzvK1aQWBM+UoEopHUMN/t57PF2uPYw5+mGvL1qywqLYfa86xER/uRs8AQ+9pHBXhU4EIDtSiIKfCHLsAcROTFjounpr2KNMAWt+MdGpX485vswzODCCIE8qhyPKtap11jjSXxoWzQCCrUZ/HmHVrmL5kq5XBK7voZEZQynWo0cLKlRK9 BmJCqpaF t8AXmoNXNL+CfIgO+dSTbOJ2vM/QgDcVXHNJhENA3sIvyTvqfLmrvyY/EQshXrltyqEcnWIaDov05PQcBtn6z01L19+8kWDmdu0PJ2dhUjFXx/flbkRvOyJMqfgbX0fKvxLj+0iuCTeOzirA2BhCC9B+IrGTc590UmQLeBo45EhVTPqYm2ISqhZCQsJv5Y0nLdSgV3Iq2vpsH0EXqN3G6MbGCGiYA5h3qXYJeSshkNqPSsQOb97KQXy0k8hxbrsw6I5uKm0OyQONf4nGQY7cGL3hWyYTeZ2MvCznq7si63pHeXb/+Ly8kst4TdBbpeIRPDJB8bmVbfjXdobhrPyOizqAuSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 12-01-24 09:10:33, Roman Gushchin wrote: > On Fri, Jan 12, 2024 at 06:06:39PM +0100, Michal Hocko wrote: > > On Thu 11-01-24 14:28:07, Johannes Weiner wrote: > > [...] > > > @@ -2867,11 +2882,17 @@ static int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask, > > > } > > > } while ((memcg = parent_mem_cgroup(memcg))); > > > > > > + /* > > > + * Reclaim is set up above to be called from the userland > > > + * return path. But also attempt synchronous reclaim to avoid > > > + * excessive overrun while the task is still inside the > > > + * kernel. If this is successful, the return path will see it > > > + * when it rechecks the overage and simply bail out. > > > + */ > > > if (current->memcg_nr_pages_over_high > MEMCG_CHARGE_BATCH && > > > !(current->flags & PF_MEMALLOC) && > > > - gfpflags_allow_blocking(gfp_mask)) { > > > + gfpflags_allow_blocking(gfp_mask)) > > > mem_cgroup_handle_over_high(gfp_mask); > > > > Have you lost the check for the dying task here? > > It was moved into mem_cgroup_handle_over_high()'s body. Ohh, right. Somehow overlooked that even when I was staring at that path. Acked-by: Michal Hocko Thanks! -- Michal Hocko SUSE Labs