From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33B7C4707C for ; Fri, 12 Jan 2024 05:48:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FBFD6B008A; Fri, 12 Jan 2024 00:48:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B7366B008C; Fri, 12 Jan 2024 00:48:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19AD36B0092; Fri, 12 Jan 2024 00:48:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0B7876B008A for ; Fri, 12 Jan 2024 00:48:15 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D01CF1605E4 for ; Fri, 12 Jan 2024 05:48:14 +0000 (UTC) X-FDA: 81669578508.02.9644840 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 9E42918000A for ; Fri, 12 Jan 2024 05:48:12 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HIzrxhlC; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+0600f2c447b6cdf09b16+7446+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0600f2c447b6cdf09b16+7446+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705038493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P7BoQkKVZMgf6vnmP1aQ9LNyV+OuN5zAeIwFDZGSshE=; b=EsFhQdGQr/pi/cpv6b0n6NaatBxdwyQHXt7EnH/Tf1mFlvduiROP//Rs5+RrktvOF7GYI7 Ro4idy1Xnt1auPHqCQNdAlWhRYroqlFbG1rft4+Ov5jXDEkJIpENCuVt4rHMLx/Vmt0pQc V5BVIdKfu01wt2bWg7uMitJGULnvQ9U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HIzrxhlC; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+0600f2c447b6cdf09b16+7446+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0600f2c447b6cdf09b16+7446+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705038493; a=rsa-sha256; cv=none; b=FLBXT8fEQRvH8bZqflo8PYuOcdH+VTTZm7U08nN0H4dtVNabpt7gqdnesfFeW2CYrS0o6n VUZZ04UU3mOg4DxY0CZXhxgjVdWTyrIsqEC+rO/+D+fokIU58pSuChdJZP2bep+5rqCaA5 Vaj8voWCcrTSAJKxbLcOlsxPbRjAfdw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P7BoQkKVZMgf6vnmP1aQ9LNyV+OuN5zAeIwFDZGSshE=; b=HIzrxhlC3lQeP8d0vel1OTHYYS H9ExqFhsFjfNhDSzJCRwzNhJB9AZaP1Jro1YhYIlFkxBrAafxGA/RRuViLWdQ019rXzxfSWCQ7Mjw VCKFwpcJI/fx+pcv4Uce59rr08TsSJcH1QYtXVmHbObokLqnRRTuvU7Yr6b5H7+D46soliAsMUWFm AkOUfscdOwyElzbDGkcNi6nIIcJkmwhk7cgpLlgwOYTFDjHLD2mMEMUbgOKo/FIEXJoNlPJTjZNFU itggmrSDxrPXQaugbmylsV1mirs3SCETYWB+38PZ0O6R+SzTecCKxjl+MfbGxf5/RIZsZHbwYZNwS CSf0MHsQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rOAOn-001yLf-2L; Fri, 12 Jan 2024 05:48:09 +0000 Date: Thu, 11 Jan 2024 21:48:09 -0800 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot Subject: Re: [PATCH 1/1] mm: vmalloc: Fix a warning in the crash_save_vmcoreinfo_init() Message-ID: References: <20240111192329.449189-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111192329.449189-1-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: 5q7ojkwkqrhcx9hyswfxgtn4h76zhfh6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9E42918000A X-HE-Tag: 1705038492-427692 X-HE-Meta: U2FsdGVkX19PyNvtRi3LhTsQL+0lQlq2ns6J5qdJKzsgDK/8k7xqt8RSJNKzAbCEdajgVx4vCNtgNz/3af2wNWSzEO9F62QqxCt3p7oS3flNLSybxZmLHRU+xWzrPwrrzHY1K/3NhhGhwQ7B7wrh6lT6JOnMGR+bdnrXM+VVwazy4uuppK+sOrEtLcsUDIelOVCzqgVGZWNpjHPEURMo54+nGAA0SKzhYfWlbq0wiUeJBTi8kUpsECFfCdAFe3BqFOfNNpBmcD0joh9h3LILyxUzYZNDWao/hupmX0d5lngjdKBWsCPIHnqgfupdugv01Ykm8CQuuKEq7Q1ZjV9319hQEyVc+rcgRliG8obHgowrUHrVDQ3P8O6qE+O2EVSQvqJUuNZrP/A5wk2+jNP6bVbOJdjq/d2sdjHguBDH2ATnXaqzv5Tdt/LD0S68i8ANrRik5UdaAi/nI87B8m5bzknoh8BAAwUHNBHcr/AU7UivIGhETfMjDJxmMVQAKQsSRExpRDAzk6jvcEx+eHgfBrxYY3rX886bIHmgBTnS2VNbuUgT7tHuqyK5vX5q5G7fGNGA8VzLe1DfqDhDQu9rDfT58ss7gFf1gU/qiEr/fYuPHGnO2DLAgfrSR4ygtJSvAeWxZMUOHGYq3Kkni7UuftGfWgoMo2q4pw/jnHcNATyUesHg+xmGJJaxsi1/2tolKoYL9WlAoaSNUHDRGwqdwCmuth5ikkS5SggZrgUSTgaxXgg1FF3++/h/b1AHPVgX1KTQXsDxu7jzaQmErFP5h3gn8RLFL17x+CaGAYC+N5msfLTl+h6YjSQIfY5h6hFt2EBBcuvgkrT/r7tQGXEici5V54Z5FAbqJBhiXbAkf+/V8Nk/BEXSTBZlFACby21OTqbuhxxhd1AoThF2v8nZGEJjJg3Xos+OyRsMAXwQ5g/4WGBSNg3TLVJfDK2OQVs7pMCNnZ7TK8MtRYvepvH N23FToVO oGNlMymUeVasMOghkd1ZfKdFm28vvPhtSZq8pCRJISp2GZ32vrSQU+cHXzunPOWtvYyj9dUclQ1fsacnuSIK5DoNGUUbL98tc2QY1/SES87CZ+ajxQj9MB6d1k0HeWcvSKQX+diueqiXmVQg82GLxcvxORJBZrMJxdTAeMvYS4gYCCDKjAJe9EfmQl+jHIa717yVKV56/RWhSKQUiefjA5wxSUDq26Dqtoo+wcyMpN44UOq9DnsRgRqHJq/cq8vUzdBXw3vZxy09Y2O8DNKsoBikntMy69r7MLZmgs2dHVggMHN3wqqjBJz9l86/+rLkp5MnnVyxsmjax4ItkGuszFtlyRHv5usGtu2QNEW28vC+Q/eXK7A/fY66tpgbiAOrdWn9BF1KXRdtauC6NBn8UOsAWdAJhZKoTMyDQgmJZJ05Ct2ZskirYHxJFds/Hk8C2gvrAyDRm47B94SbApIxl6+yi9Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 08:23:29PM +0100, Uladzislau Rezki (Sony) wrote: > #endif > VMCOREINFO_SYMBOL(_stext); > - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); > + vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", (unsigned long) VMALLOC_START); Well, the right fix is of course to make sure VMALLOC_START has a consistent type, else we need to plaster this crud all over. unsigned long seems like the right type for it, so at least m68k should be fixed to confirm to that by adding a UL postfix to the definition.