From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FF0C4706C for ; Fri, 12 Jan 2024 05:42:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 764346B0087; Fri, 12 Jan 2024 00:42:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ED036B0089; Fri, 12 Jan 2024 00:42:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58D6F6B008A; Fri, 12 Jan 2024 00:42:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 44F7A6B0087 for ; Fri, 12 Jan 2024 00:42:07 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1AF53406D6 for ; Fri, 12 Jan 2024 05:42:07 +0000 (UTC) X-FDA: 81669563094.24.4D5DBBB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 802E3A000A for ; Fri, 12 Jan 2024 05:42:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eDURiJiU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705038125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g6BSFRepca9WGGc5Fa5O/uOTZnuhNDHcJLcyaQXXfX4=; b=jaq93gCC6kdGR4MX/LMDyHxqUBGk5qewrqPVBjC0CdOQs8ZgrS0zYPjm7eRqw6kFI0CsY4 f4hM5EEO2Hc0xOat2WQC8nBNvKJ/eIEHV5yXF46QNCSLTzNxUBvJr9jZSsNN4vrY8/jqmL 65QGd4eqelTPwAEdsx+7ZvibFWTsfVk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eDURiJiU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705038125; a=rsa-sha256; cv=none; b=b9TDC+7wJ3970D4XSpeoL3bbXbwcVn3aqjaTS6cW/i/td83JlKLMvJAsmQBMVaqNF8QNRB R5wkujG/4CTTL+Ph/woU0KexuzHL8XIkXYlWmctZ4XJ1UtSHA6/aN/fLiR2sQ4p9jAXB4S duvCDGqkkZ7LopcQ9D+I4kTZ22rWB8Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705038121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g6BSFRepca9WGGc5Fa5O/uOTZnuhNDHcJLcyaQXXfX4=; b=eDURiJiUxpslLKjsd+D8wp/a0M0K6NJqZOMtzp+IIpSowyk+q4wJMlUkc9LtJIfY/Wy8AE O/E6xHq+oev7Ey9QMHz65A+xD2sx1IETktDRBrqgdomELGHV/iRb6ARzqDVe5CiPukxF/J DsRz4s4rRyaj0Dc5wXv5bqnscNf+ie8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-3isU-4a_PDSNjcCvGJ2gNA-1; Fri, 12 Jan 2024 00:41:56 -0500 X-MC-Unique: 3isU-4a_PDSNjcCvGJ2gNA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4AA6C85A588; Fri, 12 Jan 2024 05:41:55 +0000 (UTC) Received: from localhost (unknown [10.72.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC2FD2026D66; Fri, 12 Jan 2024 05:41:53 +0000 (UTC) Date: Fri, 12 Jan 2024 13:41:50 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot Subject: Re: [PATCH 1/1] mm: vmalloc: Fix a warning in the crash_save_vmcoreinfo_init() Message-ID: References: <20240111192329.449189-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111192329.449189-1-urezki@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Rspamd-Queue-Id: 802E3A000A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 3qzuag5krn7igsoj5cdwn5unhu3wz1y3 X-HE-Tag: 1705038122-839716 X-HE-Meta: U2FsdGVkX18B+gpD+z3pHG4QvRGA7RFqLewpQ09IxtgbeHxYMxyGd9pRxAzopJJmxOJW8UgUmwtKkB4HB7alrmbfFwTVXfy90ti2FcdvEG6ilfh+trdTtuNMCnHi6dLHNxaEBxs3CXP/USCjQO0UJbMkLO65FZ0mv1JK1gWtGkX2TYezKi8tkIqfrqTpIqCwFPoxRBoCAVNptQuMvCty5dXBZSe7ydIVnfVdxl2RXFNloxktR6YjyXJuKvblUEtV6dRSe3ELeiCqmk4i4FpJMD8iTpO2ZtSEshlk0eRie8e1n4JNy/FjyYMkMZZ1nCz/0RfHavMxFbH8FBRgAOE8sS2bGH9wVzIuIG4kU+PmI9w1ckofQy2dZyK/B3YoChYefcb8dFhyTOuZrvC/ooxewZhi0kzQKsi2jJFiF1k9TcQi8apPggeZ196mJXE9faUPYA1S3mJZtHw7OYcgyXF0dFVzNck08dHqyWO16hxuSGHqrRu5lnQbdBcXMDjfG58Un8FtX58E6h5gWl+zHrXvmnj+7PaRDq+m8r2oz5f1tRUvPLP77qsTcPigJgb0iZAlb4DDG1aPGK0IQtmVphdvlPpF6nxW0HDWttL69ui+K3MJgCxgOc55HcVeuBljBoaccYiMcREVEhx8K2EGs98J6DYK4l3GW0q1XXmZd9k5K33c566RoiSkDQKtnBqEl7E/1IO8IhSF/KSqQVzoJBsLTsUyQnLmUp64BOk8IGCyVtujdS1wCJYmqgVURIK2WzEVsazYK1eAx1wOTyvPSUKV6QjS+t78nBZpD3jJ9HOtSkDXjFMTId2uf3P2Md/PSOkN7ra/YzYy7phk76Wr8uHHpu9X2qC03UpdRAYK8xqRv1ywQESlSIukDDu/+A5rLhugBQKZIm+dvwkpJVub9P3UYxDMR3MzWFOVclympZFVpzQiEdeB4t3oL0/ZwYAeZGh0bkY5EDZpKkcVXc/nOyB ydulQQhY nns8HpSATenrFgo5R7X4OAtr+8zoVDBpTH9Vq6sZ3lS74RigpKLyDkJ0miirMLf8vubePeBti1ONFb4qY3KcCPt+sbQYCBPnTai6L1gQLjP4OETqCqx2CVfETZenJqjI2HupgHQFT/Tvjb83KLLFtCBS/V86DwxSjEGDQYGgLYM+3mu3AopCeyPJDxyDbLPtoRXbvM2iu29OnywSekHDFW43Ogs6eLRxX+QsWXljwWgSS53OO2wNsELiDiizcholaLL2bCt1phq4GmlhyP4GdjoFscOIXBJq0NqGPzDrVteVuTlyDeNtAsPvPrI8zNUK2MUGS6uxNELFgSquDp3WDPgmBVJJcf9P6hKTcBxzDHt5rLzbLgHVVmrFC+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01/11/24 at 08:23pm, Uladzislau Rezki (Sony) wrote: > The vmcoreinfo_append_str() function expects "long unsigned int" > type as a second argument(0x%lx) to print a beginning of vmalloc > start address which is defined as a VMALLOC_START macro. > > For some architectures it can be considered as "int" type, for > example m68 generates a compile warning message. To fix it cast > a second argument to "unsigned long". > > Fixes: 9bdb180b2d ("mm/vmalloc: remove vmap_area_list") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202401120218.y469Puyf-lkp@intel.com/ > Signed-off-by: Uladzislau Rezki (Sony) > --- > kernel/crash_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index b60de490c1fc..49b31e59d3cc 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -748,7 +748,7 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir); > #endif > VMCOREINFO_SYMBOL(_stext); > - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); > + vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", (unsigned long) VMALLOC_START); Thanks for the fix. Acked-by: Baoquan He > > #ifndef CONFIG_NUMA > VMCOREINFO_SYMBOL(mem_map); > -- > 2.39.2 >