From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68494C4707C for ; Fri, 12 Jan 2024 08:11:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB51C6B0085; Fri, 12 Jan 2024 03:11:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C63186B0087; Fri, 12 Jan 2024 03:11:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADDAF6B0089; Fri, 12 Jan 2024 03:11:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9E7F56B0085 for ; Fri, 12 Jan 2024 03:11:35 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6B2F2C04CF for ; Fri, 12 Jan 2024 08:11:35 +0000 (UTC) X-FDA: 81669939750.04.508BC0A Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf24.hostedemail.com (Postfix) with ESMTP id 80C16180009 for ; Fri, 12 Jan 2024 08:11:33 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iWU698xc; spf=pass (imf24.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705047093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3NoH8qoCkKWJ/xlxXV8t+mbxpkVHWg2gJxhM/Ol3TbQ=; b=qTFDEPXW1xx/lBY2s1KQ+p2K4C7vX6zOaJN0lBGXafmq4qJq/jKOAKg0QjNF57gyJnduop 14zLk0CDVxbUMmL5Rh81I4KcHPs7IGMuTD1IK3kwZzqaLbPXWCWVhziccgtvzGGKO6qwmR ArjL6pkCg990FN4Dlftz2vCqM5EgKps= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705047093; a=rsa-sha256; cv=none; b=CTBbBayaGjh2iDdpKA+I9JYsPU8LKYqlFfzQrKR6IjVKGouSRflPEsf6w8dEunANzd/jYL tBSwuCjSyY1ez/HZbfonJozYDXrauTrLRpgOQmhz5hHEyT34K8tEUWLtoPyvYd6w/0p8S5 cDHne0Y+klj8i/s5gV3YcRezqJKGNgg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iWU698xc; spf=pass (imf24.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-50e80d14404so6221839e87.1 for ; Fri, 12 Jan 2024 00:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705047091; x=1705651891; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=3NoH8qoCkKWJ/xlxXV8t+mbxpkVHWg2gJxhM/Ol3TbQ=; b=iWU698xc9N1BgHyWH7rLDnbO1/ntaBAGbGTEbNb9LvMFKNWNWKZsaW7oSVmQxLwCx6 F6b/0RkLf+9obgOdXAP6jlhJ0pdOeFSIOkIKEqJfZR06gcerKTcIdhFIr5neysrdnCyT FlwnaRhZpG80lGtt1wDW3VPmJYIYUG+93x1LygTXf7H7rw+PL9H5Gh74cRspSTBg2uco zjfvf4iW1vc3zRZFhh3TDwHqtaRskzZCYLC2BTzirYBSGH5exrQWGSKLvjRu2zo7OS94 ocOhSh3WFqw144UwTZtBPstednGt7GyHkBO8oL9ZuG38w9MvBujeZHQbC3hvAkZHnR0F ei/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705047091; x=1705651891; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3NoH8qoCkKWJ/xlxXV8t+mbxpkVHWg2gJxhM/Ol3TbQ=; b=QUxNKgAWB/7ajdwtv/OR0JJG/JgZx65R1BvuUChgJd6Bel5aALsPHoCCySZFCu7JSQ FGQxPt60qXXqBFh/Pu8l8jR7/HgivfKT3gXyLd9Okg2qfSABitc7NUJVtl4H25RbaNiO jwC96lusiZ8r0CQVkkkFqVeunGNWhN8Xw0O9dsJWhQEVA7/jJ8PWdqsjPUdmb3MeWFxV ciRHJWsy7/rRT9a/KtprQKbLSCKU2nC+iTIYtmozVd56gQ7gkLHyndbEQ4PlkPEC6ulo T+n/lbmPXcWgpBGv3015MrVSHBQNQGXGeJllslk/1nCtJDshyTHOfphz3/Y1jSBY8q3W JoGA== X-Gm-Message-State: AOJu0YyruKj4wQBSTW+b/ZnZWlPobkbT0HmHYvaCppz/rRSRkHEklAk3 /Gnc9zV8rWujwgOAzruSlnE= X-Google-Smtp-Source: AGHT+IFQHhtOxsieltG8UGyMgmlTgU2cFPw74mB3f7bn0Nu/nnaBO9NoFsVJcHS5gLdLYx89BE8g0g== X-Received: by 2002:a19:4342:0:b0:50e:4b1f:5ddb with SMTP id m2-20020a194342000000b0050e4b1f5ddbmr396182lfj.16.1705047091328; Fri, 12 Jan 2024 00:11:31 -0800 (PST) Received: from pc636 (host-90-233-192-22.mobileonline.telia.com. [90.233.192.22]) by smtp.gmail.com with ESMTPSA id eq9-20020a056512488900b0050e76f2591bsm437820lfb.58.2024.01.12.00.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 00:11:30 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 12 Jan 2024 09:11:27 +0100 To: Christoph Hellwig Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot Subject: Re: [PATCH 1/1] mm: vmalloc: Fix a warning in the crash_save_vmcoreinfo_init() Message-ID: References: <20240111192329.449189-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 80C16180009 X-Rspam-User: X-Stat-Signature: iey3nrpefb8hyy193zwo6exxugce1osn X-Rspamd-Server: rspam03 X-HE-Tag: 1705047093-426123 X-HE-Meta: U2FsdGVkX19ySSrv+z6gPjiwfOkJEBsNjsq0IkJtEEep5r0686JF3uobLibc62K/8JC+dJgCKnDHd/mPInAkTGYriS0WuJeNDFy9lPf2o3U/7VudSpCo316cLnsmkrF24kv9Cz6v5TyLiNxYmH+s62ql3ZgrhjZt3T/yWZTi+IeIJUN9zmLL2qvw7e0MENZGD5u7tgVL9cXavNC2BLX1/RpL9gp5MKK0TTzJf5zCJNzPeKb5PolBbIbAml4XKFm77Wj76hYxvpcOZyk7Qeo87ALdVKpNP7jdtEFYZb8NZP/sVUYwPqDZQLeo2yZ068jBltvdwaMwQ0LN7j9U3L9JUh44NryRTWBAppI/D/e/w+X+iAjQ5M6OFd1msbGEbyYGLyD8Y1sFwm6K3rNTQDtdoGFHIGE7Mcs8rY/l0RenMqWUNM4N2Z/kM4YOa3Byn2z5su5rGfqsgLyBhoMD/MetRNIhDsPMwxHEd5FkOhtsFMpi75O0bQi74AkHGjZVirYo2hj2ZojBJgeZDiBecS0htC/EeNE4qzw7fdT+qZ1OqT10Sy0upQrakk09lshchldbybj69VnnwbPZXSf68YVO1qOy6etVVKNu6F1f44Uvdy0ENEIspUAjoG/GqVwrBClN62i76ctdag5VvUnfDTEjkbVc7cCnapbUIqC/vnj7yORMpJodLFaFhmHfQT0X4ecSCGELBI6wPQ+tq6tWbSEuBtDWBtVbEmUNFil+RzeD0S2zYx/6vUaWQEB/kInLeHPxWl1rOShuGix6DGQlnQy+jms4/QCrnh+gDTfX3nzJuEzSUtZv8lKrXaC70JNSCnap7iv84gloL8epvNdGjrLU+0fTonKFkarU3QTAyS6EFNuL5Rr2eriW7Z3VITWS7hC08u7ASxhr2mfbAcVh52CmGXtiXCRxQiEt5nFFad0eCXoy6Y+Oi1yIbWhRsu+rbCb/TfkVjx5wE8AChbTB17X 3Au60PnY kHuZfaMkNc7sB3pSiuFALh0wAbBhECt6hX006HaWpLBGdbkwdvIoqurauXvCPn26LxGtluwXjWn44qL+nI5f0y5tUxgeZaQMoIBPMqTpF9KoxnCcNvE016eGkckEMceSQT7X3QUWsTSCOrJk2PPK3d9LSEEgpL2rLol4eQu78Q3+LkWDOTAHcBcxQ09h5ySjFP9X+OycdQErEq+Z+KQjJXjUzuUgLlw/SOZbjWqehnUGDcHmkiYNJ8zDz01QyNoc+jjPZAlm/qw+Ylory3TiXlpCUNxXEc375XcKCjjBHbzH3vsY1EQv3GPaUsn8OTM5X/eVpMw4VFBo9oxAenQF4dwio3u1FVwHZo3p3b1BHgI/RvvldKsPyTjTOBnl46VWfbP0E0AInKL2uHuGs6P3Ek+H/7wf2G0y41Illg5sOK+opL7Xt3ISQoXS8KYumRaZygfNb3eRZfryb3rUHsF7n6GP7XmdrkPZM/EBFPpU/TePdQWqkv1WRihccd+KOsHB6iq13 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Thu, Jan 11, 2024 at 08:23:29PM +0100, Uladzislau Rezki (Sony) wrote: > > #endif > > VMCOREINFO_SYMBOL(_stext); > > - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); > > + vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", (unsigned long) VMALLOC_START); > > Well, the right fix is of course to make sure VMALLOC_START has a > consistent type, else we need to plaster this crud all over. > unsigned long seems like the right type for it, so at least m68k should > be fixed to confirm to that by adding a UL postfix to the definition. > I agree with you. I wanted to focus on fixing that particular place because i wanted to avoid other(on this step), possible side effects or drawbacks if i went with patching the arch/m68k/* files. But, in general arch/m68k/* has to be fixed. -- Uladzislau Rezki