From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7EFCC47077 for ; Thu, 11 Jan 2024 18:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 419C66B009C; Thu, 11 Jan 2024 13:04:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C9196B009D; Thu, 11 Jan 2024 13:04:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B7F36B009E; Thu, 11 Jan 2024 13:04:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 12BE86B009C for ; Thu, 11 Jan 2024 13:04:25 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C83EA1C172C for ; Thu, 11 Jan 2024 18:04:24 +0000 (UTC) X-FDA: 81667804848.10.1EFA4D9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id BD7C3140020 for ; Thu, 11 Jan 2024 18:04:21 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tkDWBWFF; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704996262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VqEajgKYUCRG8Rpm6+M9Aezz8/e9dXscDdOmwHGM7AM=; b=MrdTF/73Fe9Hjl+ehhvlNLutrIQK4akP+XguX3UptrK3tqjdrwjsspxjEo1Wm4pn8SBtuI jaZAoyo1uuw3bcVkXk7B0jgKEAdz8dUmJbNpDAjZaCtkL7ovt2HCIkXx6nyaXrTVEJLZaZ xw0KOg5ZOrUHV+KztlVRLS4/lDpkl5E= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tkDWBWFF; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704996262; a=rsa-sha256; cv=none; b=nppjrR6MiV1ya3AI2a7/A8JpV754z8J7RH8Kk8hz4Oe2cyy5mdBbnjwiRV8jPC3LE4gG0N CESEOKAmZX7yssMDcINqKA/aSme6662X9nEGNj/MZrXnjB5yNWfjSUq4447JUAoamwZDpb p3Y+SmO4XmVkMec5hsnYZcCOoZzxAew= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VqEajgKYUCRG8Rpm6+M9Aezz8/e9dXscDdOmwHGM7AM=; b=tkDWBWFFGAttTj4drcch5XyXvQ /vAw9ozrGxZ1GlZ1XZN99Bh4Tlv08VGBISNUZib+O8GUd765lTT7ndy82gdokPwyBZzhxFSCVXSzM ipYEsMKh1AuZZ7nZu8vkzCYYCaBWGsT10BubbNozvKPGrgDrNK8IWlj0o1HxzQ0WG2BN/iz37F9Rw rAIHbvpn47GKDdQXrbbaWso73/ZrWla9A3ZpjQI2H15g3aUxkCgRYIpi3Mkg9Q+rLwbfdjTU2OwyF S0bH+jt0e3k9XcD985AMjhHCU2KLpucYcl+QNPpPKumOGYpdihRnav3Xjx+tUTMW6HRfPgRku+X+7 SEqHVhYw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rNzPJ-00EVS2-CT; Thu, 11 Jan 2024 18:03:57 +0000 Date: Thu, 11 Jan 2024 18:03:57 +0000 From: Matthew Wilcox To: Sidhartha Kumar Cc: Jiaqi Yan , Muhammad Usama Anjum , linmiaohe@huawei.com, mike.kravetz@oracle.com, naoya.horiguchi@nec.com, akpm@linux-foundation.org, songmuchun@bytedance.com, shy828301@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jthoughton@google.com, "kernel@collabora.com" Subject: Re: [PATCH v4 4/4] selftests/mm: add tests for HWPOISON hugetlbfs read Message-ID: References: <20230713001833.3778937-1-jiaqiyan@google.com> <20230713001833.3778937-5-jiaqiyan@google.com> <079335ab-190f-41f7-b832-6ffe7528fd8b@collabora.com> <6bacbd7c-88cb-1399-8bd0-db98c93a1adf@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6bacbd7c-88cb-1399-8bd0-db98c93a1adf@oracle.com> X-Rspamd-Queue-Id: BD7C3140020 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: kooa3yancr19o4p1mphirqq4kgpz7dez X-HE-Tag: 1704996261-652485 X-HE-Meta: U2FsdGVkX19QCOmnfBxyVX7nD/PwVrLglXe2wrMZydXklLcWdC+1UcXS7OO1LEbM5dVo0yE5mAgAbChHm9fIUce16viPF/kT6ZcsUya9gPEmowxpxaxPwTM9hgRwE543BXT06TkNMx2dbqT1I4u9Qqdn0QThLn8oa6hBxqoXxjvxLEd99nCYnDpHlgW/hx6qK9DfqYEd0oLBc4Uv+pWHGfh+6OEoNXpOoU46vmvVIKPnU4/+A3MrCPD/AbHO3kcEOiKcihatEmvRGicR3atqeyCu5kxEvSe+eFFRw+3T+kjntt3bYa2g3YdzqHnaz+B5Kqht6EfBa3wOYh/zVBt9YSVvawMxFRnHyVI3zujOaIusPV6MJKQmj1aoT1Wnv396W+3LFGMplof7eYYqL6rQ/bI6sgrHlYDwkDlU5BOgUM3FFo4uIph68+XpAw3dpp2ysj/5ZH9fb56o1xvH7sfIZSnv6jIAyZY1AuNO1E7cLVO9pIYCAPVINL8cEaot8J2TyWfkK1lliYwv+cUv8eLry1lDqtC8ZMRHZx4NvtM7NXSJZKapFv+qLy9wPjmcKSAeanaQmPDViYTkGSZKHIYSpaaswIvS20MsZkwzOiCYYnjcT2tVt3QIdbrk5+UmxZkbVHZoFqj+hiQVN1jZbEbvb3n4KIKK5xCMYU6+MRJrtfYiWj0bxtXD76cNwCk688VRafWAafSO7mNw00b1hq/TFSuMx7DmXMr/bvr53XMS++/8fuqMwvIj4sjU+FmNSiKCNv/1Q6hgVxPS+pr8OBr2y+yl0iDr078eAuzYPIbHGOpKAU9GNPlVMcTVcfxZCyi5a4lGwN+uZcyTtyavOHCV19pwYOGRNcjgfogkkQlv03k/xleJc2tMFZBk00dqW2OaPhDUoCUSTWWynvISo/EQCAoQZK8XDRLgKV64uGbzDN8BsYD3Rzn26diBXnsltY75L9e76BCkqozcylqFkLH hu7lLsdi m0UHj+ywDKBmzTQC2VKjq5+yVx+sfQ5dJzgPVo3Yc2dEvLosb9Lii5MVdEnOxsQzR/2RIWYcMNvpviIoJqtaAFfNRUgfhx5j5l1TiIWJDgS32V6nfGPgydNJ+Hr9pZJiHKKFTaBIzZRC4b0ADaZr0fthJ6SyK5rJ4QE99LcJa59Gst1UkNIPOr94Vog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 09:51:47AM -0800, Sidhartha Kumar wrote: > On 1/11/24 9:34 AM, Jiaqi Yan wrote: > > > - if (!folio_test_has_hwpoisoned(folio)) > > > + if (!folio_test_hwpoison(folio)) > > > > Sidhartha, just curious why this change is needed? Does > > PageHasHWPoisoned change after commit > > "a08c7193e4f18dc8508f2d07d0de2c5b94cb39a3"? > > No its not an issue PageHasHWPoisoned(), the original code is testing for > the wrong flag and I realized that has_hwpoison and hwpoison are two > different flags. The memory-failure code calls folio_test_set_hwpoison() to > set the hwpoison flag and does not set the has_hwpoison flag. When > debugging, I realized this if statement was never true despite the code > hitting folio_test_set_hwpoison(). Now we are testing the correct flag. > > From page-flags.h > > #ifdef CONFIG_MEMORY_FAILURE > PG_hwpoison, /* hardware poisoned page. Don't touch */ > #endif > > folio_test_hwpoison() checks this flag ^^^ > > /* At least one page in this folio has the hwpoison flag set */ > PG_has_hwpoisoned = PG_error, > > while folio_test_has_hwpoisoned() checks this flag ^^^ So what you're saying is that hugetlb behaves differently from THP with how memory-failure sets the flags?