From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A81CFC47077 for ; Thu, 11 Jan 2024 16:11:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43AE06B0072; Thu, 11 Jan 2024 11:11:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EB086B0075; Thu, 11 Jan 2024 11:11:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28C146B0099; Thu, 11 Jan 2024 11:11:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 160E86B0072 for ; Thu, 11 Jan 2024 11:11:14 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EA94DA0AFC for ; Thu, 11 Jan 2024 16:11:13 +0000 (UTC) X-FDA: 81667519626.15.E296959 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf11.hostedemail.com (Postfix) with ESMTP id E32D140004 for ; Thu, 11 Jan 2024 16:11:11 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WPmgSBKS; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704989472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OKzNaPM1+wqR8C57J711Npdwa2aojqdAXpN+xlVXNWg=; b=XSojw/SDCZ5XtMLkvZ1U2TNnP3uylkZ2/XrIqbDATI0etbDDAB019KSSqY8L9RzLe4XpR7 AAumcUOz1udjcpx6jPuXatvr+EqdJ8amwqqacu0yzNCmtLlqfWQjYchqSQc/PzJ7jZjIoV Ldf4+yKE6E24QKph7ZrFGh9Ilm/Mf6Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704989472; a=rsa-sha256; cv=none; b=a2TZjDNUag9KTtdsaSAJPV1zXSanYKwHMwssEPBF5Yqr+QgJaLf7zE3S8wuPun/LgEk35f VwlLW9Lo3Uh9/VWqAgLn6EY3kQtvnuSNAOsZuXZtnOEOOl6t07bas10sP4I4GTMpC6xr4J XoN7jkmFn8GdgdYCGixkV2sxGTSarrI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WPmgSBKS; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2cd1aeb1bf3so51139561fa.1 for ; Thu, 11 Jan 2024 08:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704989470; x=1705594270; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=OKzNaPM1+wqR8C57J711Npdwa2aojqdAXpN+xlVXNWg=; b=WPmgSBKSKZBqI8R1ilUZRdFCIsFCenV0PPGSQd2LkwpTzkm+6oWzQmkIW8l5qETsex uU48zymCm9NwxN8C0qeF6iqe/JUGOl54euksD8tK0XSVKY+D8S+h1wuXPe9FXmuuQ9Kr zAOr/7YAsvlcFHZUGKDO+ksVtB08E2AACOBAh3py832FbVyETp16cyYh/02a3ABd94zR mdV52+eGgDpXY0wDTrLDw/NYGfoBzJRdGb1c2ruv1Ne9wX3me02llBJ3NUsooyG9vgdw exjgs6YoPZPX9W3+rpXPh2rUG4FTA3x2+ZvASGghmvUalPezvqhzbBtjGgPNx9hlS6z/ Lohg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704989470; x=1705594270; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OKzNaPM1+wqR8C57J711Npdwa2aojqdAXpN+xlVXNWg=; b=SDRSTFvM69MNgvHLOzSnmxuXy2dQ100z7zCW/y7EbfhF5Uit8DBgbesP36xK2QDE81 /A3gQmps/blDsO4+ZI+dqhxPJe0S2XjdY6EaM97UCBEkOgaMq62ZEjFihr9uMuaeSGOq XxeI6c1RoFi45TeruimSEeEwj2ktNx5R28qR+SXK/gam7rc8g8RzN47dA5Pl1Rv4JnNh T3mteJMsPh/S9A1+rWQUv9YZxUp8BlU+FcvOkdIMfUGiL5fuMkMA+YZKEjMFgmm+wxrg i62mJ+OaHGSsZQrIEDFq13yRYj0MT0E3kneH+5UcdT8ayHkkTfo8GPoG9jlzu8C2TSzq i8Ow== X-Gm-Message-State: AOJu0YxqtGzFago2Cqks0zLo3kQuEbnJPlk+pjfRP+Skr9Mh8RB/j7+X J/hrE0WHYmRXBmNE0VQRpho= X-Google-Smtp-Source: AGHT+IHlfl6w0liWUk8SHjKaWaWMu9q0agSAPQJO2vXrHf/tTB++ecLXKUgnyGM2dU1sNfZmfRWgAw== X-Received: by 2002:a05:651c:10b8:b0:2cd:6ea2:bffd with SMTP id k24-20020a05651c10b800b002cd6ea2bffdmr25920ljn.18.1704989469782; Thu, 11 Jan 2024 08:11:09 -0800 (PST) Received: from pc638.lan (host-185-121-47-193.sydskane.nu. [185.121.47.193]) by smtp.gmail.com with ESMTPSA id f10-20020a2e380a000000b002cc68f0c127sm181039lja.134.2024.01.11.08.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 08:11:09 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 11 Jan 2024 17:11:07 +0100 To: Andrew Morton Cc: Andrew Morton , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [linux-next:master 12999/13245] mm/vmalloc.c:4652:25: warning: variable 'addr' is uninitialized when used here Message-ID: References: <202401111304.N5dkFGNe-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: E32D140004 X-Rspam-User: X-Stat-Signature: fmz3td13rtf8tsoqz7t75jedcwkj5tec X-Rspamd-Server: rspam03 X-HE-Tag: 1704989471-520482 X-HE-Meta: U2FsdGVkX18Qm0kjwdrjjIMRRrYtVKqBSgU0V/6nE1saOJWLw4v/iSjshJoFb6hwwDFn/Gy/N9vvQVykP3raXH0vDXfVN8wMFVE+QDfQYbPdi4gc0aeUMBk68Kb/SBu+NCj4+H38ulrmen40nC9nwDvwfqjRYzJWJ2E+t1Il1Tf4UI5ROAUn4CvQ9Uv7AqHFfPdTBCeVo2arlMTxwcdk9fHyS8vCh3IpGtZbkRIXJKY8mwaME0hERxXsoMbTWfqFaJyxMRHMLudenggAaL42DPYHVfM0ssJYy1gRsdriQhsi3bOOBnMdAEsboZjw69nKHbLdFyH3EsWtpeEhGWagrPwoiSNOxaka3LITw8lLHqYfR5uIld2Zrm/LZhMEXtwAfcjmSCNvr8zdJr8HKv1KslwhxnFYpOvcdqSZbY0I/IXVJ1f8Fq5wZUwAcMBcnmVw0/PP2tq2bGYSvyIhE0Gxp1S9tbl24rOMDV1u47H4388vsTFuhVBbtL2JEKWx2hLwA4tGa3o12vMWX9ktkv/DSA/C0dQSGivlOs1EFhk5Svvp/cOnX3PgwvU4AbLm2gingq9zpZdf3WJamqVJVwKnBHmu+HbNqGH1H3IwWLb1szfA/OZT+5D/PIVCLsP2aU1UpoYnytD3/SOkm28YwJE1jhuJ0Q1ioxf0VIKubiFuI2OKk5J2YjZf4Q5seMBlQ1lWP/AIKkaX8kaoh4TzLf5+AmxXmGxYfsSrx0L5eHGTga0nbJoVLCts3TSwhJW0PbHrVfy13JIP2rXe9tw6tYzQ//5m5v/SoztLVaMHvo6PFSB1yF9btPOyQsaAc3P0+D6UlcuV3hd+x8sF79gxRTsOS+L+QMmvEUR7hI6vd7iV8g9+69SO3gmIJaFnEccQ5efR1xVOMUwjKMFOQMQHZsSMNO9R6c5Zp6oiIuO5/ECtixIH4/DGs37pzRGbWT5pfMG9RQDXDxlHc0u4JIRtkEa AnZ2OdDj 8cmfcTfjBwCb09c100Q0O21O63HOrenJ5GzRzB7PLgynXZaZyWz5tO7cUB5iLQfVtt4mNxqoAjpdjAb9mRw678+9OjnFBy1KLv8564b7SXHIhgNTo57H3XoQutwLwN7GlwBy2exCWMu3lw2wpuKF7S2VgNTydsk2vsC/m56W+DPtDNS6sxkb8iCEzSfOzdJRBMgy9SlS5lNvkroIKYk3IWfRDaotCG2cfEt3dzTp+0YtIlk6Hrf6syZBo7rmKCT1oa1KVJipTNIl/RdTDbZ8K+IYFu5BxF/wHRekbQ3OrZvE6TsSdUAjYvPNli8bj/N5U987jyCO6RZ14SUZt8jeNRG4AXnwq0Rut0ujYekRrAl7NQ+wigxxerECeKr+i0Y+rEa//tWxAzSisO8z93lYM2JbKNOQAer31ZkSAQiPs/PyUSmHHCUDm1FCAxXvVF+EE6+hl5J4Tn5HoRQFkKUnMdi1VgHl2vBaseIKzyfjjLMbAoUHC7tYzHfqd9br+xiJXZunzwfrvhu2Ldf8weGqvQq+RJcrv24iNsRcjf2307elIT6HvTUEd+41Nwe0NRxyAFHTYGh9EYXxMGZHvWXB9VTqTgXFA4n1bDD6x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 04:38:01PM +0100, Uladzislau Rezki wrote: > On Thu, Jan 11, 2024 at 01:13:59PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 9e21984d62c56a0f6d1fc6f76b646212cfd7fe88 > > commit: e88b85b81d5313a69cb62829b957d4a9ecde600b [12999/13245] mm: vmalloc: offload free_vmap_area_lock lock > > config: arm-defconfig (https://download.01.org/0day-ci/archive/20240111/202401111304.N5dkFGNe-lkp@intel.com/config) > > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240111/202401111304.N5dkFGNe-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202401111304.N5dkFGNe-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > > >> mm/vmalloc.c:4652:25: warning: variable 'addr' is uninitialized when used here [-Wuninitialized] > > va = __find_vmap_area(addr, &vn->busy.root); > > ^~~~ > > mm/vmalloc.c:4645:20: note: initialize the variable 'addr' to silence this warning > > unsigned long addr; > > ^ > > = 0 > > 1 warning generated. > > > > > > vim +/addr +4652 mm/vmalloc.c > > > > a10aa579878fc6 Christoph Lameter 2008-04-28 4637 > > 5bb1bb353cfe34 Paul E. McKenney 2021-01-07 4638 #ifdef CONFIG_PRINTK > > 98f180837a896e Paul E. McKenney 2020-12-08 4639 bool vmalloc_dump_obj(void *object) > > 98f180837a896e Paul E. McKenney 2020-12-08 4640 { > > 98f180837a896e Paul E. McKenney 2020-12-08 4641 void *objp = (void *)PAGE_ALIGN((unsigned long)object); > > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4642) const void *caller; > > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4643) struct vmap_area *va; > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4644) struct vmap_node *vn; > > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4645) unsigned long addr; > > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4646) unsigned int nr_pages; > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4647) bool success = false; > > 98f180837a896e Paul E. McKenney 2020-12-08 4648 > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4649) vn = addr_to_node((unsigned long)objp); > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4650) > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4651) if (spin_trylock(&vn->busy.lock)) { > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 @4652) va = __find_vmap_area(addr, &vn->busy.root); > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4653) > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4654) if (va && va->vm) { > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4655) addr = (unsigned long)va->vm->addr; > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4656) caller = va->vm->caller; > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4657) nr_pages = va->vm->nr_pages; > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4658) success = true; > > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4659) } > > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4660) > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4661) spin_unlock(&vn->busy.lock); > > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4662) } > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4663) > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4664) if (success) > > bd34dcd4120d7e Paul E. McKenney 2020-12-09 4665 pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n", > > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4666) nr_pages, addr, caller); > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4667) > > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4668) return success; > > 98f180837a896e Paul E. McKenney 2020-12-08 4669 } > > 5bb1bb353cfe34 Paul E. McKenney 2021-01-07 4670 #endif > > 98f180837a896e Paul E. McKenney 2020-12-08 4671 > > > > :::::: The code at line 4652 was first introduced by commit > > :::::: 86817057732a9ce9cefdb6f513b6554a55ebbbbb mm: vmalloc: remove global vmap_area_root rb-tree > > > > :::::: TO: Uladzislau Rezki (Sony) > > :::::: CC: Andrew Morton > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki > > Same, i sent the patch, but just in case i post it here: > > > From fa613edf6c3d700a02ef109cbd42633b5df30abb Mon Sep 17 00:00:00 2001 > From: "Uladzislau Rezki (Sony)" > Date: Thu, 11 Jan 2024 13:04:07 +0100 > Subject: [PATCH 1/2] mm: vmalloc: Fix a wrong value passed to > __find_vmap_area() > > There was a type in the vmalloc_dump_obj() function. Instead > of passing a real address which is "objp" an "addr" was used > what is wrong and not initialized. > > Reported-by: kernel test robot > Fixes: e88b85b81d5 ("mm: vmalloc: offload free_vmap_area_lock lock") > Closes: https://lore.kernel.org/oe-kbuild-all/202401111810.TKPIXLCs-lkp@intel.com/ > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index e30dabf68263..43a6608e1397 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4688,7 +4688,7 @@ bool vmalloc_dump_obj(void *object) > vn = addr_to_node((unsigned long)objp); > > if (spin_trylock(&vn->busy.lock)) { > - va = __find_vmap_area(addr, &vn->busy.root); > + va = __find_vmap_area((unsigned long)objp, &vn->busy.root); > > if (va && va->vm) { > addr = (unsigned long)va->vm->addr; > -- > 2.39.2 > > > it can be folded into: e88b85b81d5 ("mm: vmalloc: offload free_vmap_area_lock lock") > or applied as a separate patch. > Wrong "Fixes" tag. Please see updated version: >From 98f1fd2d3913f3b7bcbe49785a78f67999151f1c Mon Sep 17 00:00:00 2001 From: "Uladzislau Rezki (Sony)" Date: Thu, 11 Jan 2024 13:04:07 +0100 Subject: [PATCH 1/2] mm: vmalloc: Fix a wrong value passed to __find_vmap_area() There was a type in the vmalloc_dump_obj() function. Instead of passing a real address which is "objp" an "addr" was used what is wrong and not initialized. Reported-by: kernel test robot Fixes: 86817057732a ("mm: vmalloc: remove global vmap_area_root rb-tree") Closes: https://lore.kernel.org/oe-kbuild-all/202401111810.TKPIXLCs-lkp@intel.com/ Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index e30dabf68263..43a6608e1397 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -4688,7 +4688,7 @@ bool vmalloc_dump_obj(void *object) vn = addr_to_node((unsigned long)objp); if (spin_trylock(&vn->busy.lock)) { - va = __find_vmap_area(addr, &vn->busy.root); + va = __find_vmap_area((unsigned long)objp, &vn->busy.root); if (va && va->vm) { addr = (unsigned long)va->vm->addr; -- 2.39.2