From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C299C47077 for ; Thu, 11 Jan 2024 16:03:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D84026B007D; Thu, 11 Jan 2024 11:03:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D357B6B0080; Thu, 11 Jan 2024 11:03:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFD7F6B0096; Thu, 11 Jan 2024 11:03:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B0CDC6B007D for ; Thu, 11 Jan 2024 11:03:49 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7CF7F160C86 for ; Thu, 11 Jan 2024 16:03:49 +0000 (UTC) X-FDA: 81667500978.25.7CFB1CB Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf29.hostedemail.com (Postfix) with ESMTP id E6890120033 for ; Thu, 11 Jan 2024 16:03:45 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kEbmK+oG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704989026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XeuKhDcKJWfphdN1PILa+BY3ook1Xxotmozr9wWl3c0=; b=yXDYTNV6tNGiLSh4uVxfSk3fetz8lHsptQgDlO1VHVzTQBLr70bhlYapOcwfUCVjKKuEkD K98pk8Sw/nxU6791H5dEwCuYemJ6sYXjc17knjguEIBIOkT+KVXzyOKZW5QJsAsxhTL2/Z 7oDH+sRUvBcjxg89Fga3k1fhDZAf1Zw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kEbmK+oG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704989026; a=rsa-sha256; cv=none; b=x8grL4gZ1CT04HZlnPlwIuzbP6LKOPX+FaEZfnnlm1mZsNLPD6BETxoO1tRb5dvZeBNbgd Oz746WvbGLVJK5HxJxznY3si3nhYGcyUa48uY830kL/mBI/9K/hCoPoOQwD6ZlwHJQKRYf QIIeupbXeOORj62utT/lUMRQ+PT5lmQ= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50e741123acso6340393e87.0 for ; Thu, 11 Jan 2024 08:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704989024; x=1705593824; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=XeuKhDcKJWfphdN1PILa+BY3ook1Xxotmozr9wWl3c0=; b=kEbmK+oGqIxmyUuoS8K4c3I6qin1jztrRUzxeM5nN2pvyi8YqejPiQVAkgMOxBA6VB fZs/LZQuuaUJewl1D0mVcSDtkBt+844y6H+mGMWE2FSLPlzsks3XJbUqPMmU/yJ3+gPY 8xY8fKP0txzjGO0wqxG8BebTFgoSZyF80GzVoCx0NJtoN8xHiGpTCUgH9eH9WYbM8/ai sUZHn1gf2Wyq2TgakouWOs4kWOQT2DdA+xj67Le9FdWBf7Rln6OG13XFhAAtwI6W0Xys 9eYe5E74D/XKyi3H0DANngLmFL5Gg1CqY6bbW7qHnx0ErUH/p47EWulYPjvZv86qV1OZ m04w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704989024; x=1705593824; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XeuKhDcKJWfphdN1PILa+BY3ook1Xxotmozr9wWl3c0=; b=a0qUmR1I/do/b3PrIOwImhrkovppYg+lFhID1IjE+OCiNrLd3hYzbOZGL8sjJdARDx w36sdSRUynfP8SyVeIOp72VrfaqgarVRFgBALcUXZH2HPN4jVWrHm4jYz7cELZQuLETE +GvWKOsgdi27gSC/Hlb0ts/pHNDdTMlrHcbSsC3nrFULRx+zJACx6wscFEYpREBscMvU g1a4CZLab+9qxq3EDtry4aLD5+WUMcK1t/7wqrwwg1VEgvM9MBfPH31Lpb02TSJ5kmsR 1CzyTHdGvRjfu58QFKMmWRKMaL9qD7YUFHGrae6KpX2/hVhH9I3WzulpTAgsGij+yqLy IgGw== X-Gm-Message-State: AOJu0YxYNic0mG8/WwVadIKi4AEdvAzJoD0DpxwjW0YsVjdbIONf4Z1w miJGop4PdcXCCIFVTAPFn3BkWbA+NpoqPA== X-Google-Smtp-Source: AGHT+IGbxSnHPXDtfWk1WuPeNK7oDvCA/G4s4nECzuJFPHGQCw7hoJ75RmWQf32vikEKPabVMqc47A== X-Received: by 2002:a19:ee03:0:b0:50e:84f8:77dc with SMTP id g3-20020a19ee03000000b0050e84f877dcmr737199lfb.111.1704989023905; Thu, 11 Jan 2024 08:03:43 -0800 (PST) Received: from pc638.lan (host-185-121-47-193.sydskane.nu. [185.121.47.193]) by smtp.gmail.com with ESMTPSA id k43-20020a0565123dab00b0050e7e409500sm233698lfv.244.2024.01.11.08.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 08:03:43 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 11 Jan 2024 17:03:41 +0100 To: Nathan Chancellor , Andrew Morton Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot Subject: Re: [PATCH 1/1] Fix a wrong value passed to __find_vmap_area() Message-ID: References: <20240111121104.180993-1-urezki@gmail.com> <20240111155511.GA3451701@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111155511.GA3451701@dev-arch.thelio-3990X> X-Rspamd-Queue-Id: E6890120033 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dcwks9ykdocmyw14ghhroh9wawcfdr45 X-HE-Tag: 1704989025-991308 X-HE-Meta: U2FsdGVkX1+6HxxdZ409H/fzpIg/YXzmp/AiJMCa9J/uBbASs2BTw9A6+0pR1fUyt4wrKblqBITcZnSg4nacKlWxshSq9QL8NUWqLYu43MWmxgayKMSLleO4ySmzl9ScCsa9mLdnSYNnaazOJ+vSx51kdn7ceQjxcyoHjaBqxW/gW8VHrxpoq5nAx5PlXrxPbGaOE98gmEu3ckS+NFVX2he7ZKa9ExeYuTXqCNE+m6EXV+hhraHDI/QO7+D5Q3j95DIcbKciQL9XoTFfOjk2jeg1OoWQL8bWpF4KBew8obHez8Ee0se0dom04ODYVN1amxHoTq3CgxTKom4rwcSX1SHp0bRhV6hri4VjCbZEbo8odqM6uodBavcRrU2sdICo4shaRUPbe6EPrgjb0yDnPZAPX2QWjPmYhLHPNcHt6JXVz/kgA+Vk6HKbDExFI6s6wbGa9V+Y3GvZ+MvgtExkzSi84feXXb2hDidN+roi9kIR9WonsbjvYhqcWgHQy+M+eLFak5U4Vmt0nd+GV3FKi86AQk2xHN/+l48b0MaAZzT0o/mPLtaDF9SOB/6yvlvtq5wL00CwPq0PZXnhQWA1YTL4pX7YGxgvQwT4QeV6vGw+2bthAnyz4Gg41NX7RoAF9YXdQG27jvrt++aWMLkxhkS6JKg2M4WHKce8yz+7TjqyWKD6QTX1RhBU7dM6fAs7aLXYBU2gpuw/RCXc6NBh8wOtl4EMS6Uha9E+h/b4l5feyt3tobDcytjYp0aZ0g1BQxcScFYEpNgrtY9i9FM+4dKKqawtCkbyvXc9mxgX+UmISnW0J5lPKZy7Nbswr1LpN4YPN2KP7SPazw2vp53kuBMcOcQ+BU6vZlybmZsLT+hY5p5XN/wJcghollJpFtCe+sa4rk8ZTeLnbSlt/vQsQwo8GzbWWjNDbvWFNublw8+TZImvr66LP548ejiCpSPr+oSew/zS8PE0KOFoebo lhjEfH3H XTALDOdePdAMY1WjUOpy5DSE/ZnYn5/RKl7KbPZ9w2+CAU2umHVCJratVx7at93QwbvQYvaoc6Xq9MH3bBsYz96bB78AyuvA2Mssqd0cWvKNsaQFZ+gt0rwMeMDWuicaM3eoGjUilZHk1YLEGP40VQ8M1msTAebspvEKc574VBgZQf3S1yOx3/lpzwQpsIjB7VqxR9CumbNw/EaC/oCHaUJeaSBcz9MkH+w+BeiQfxWsqZNtbAJHGYD+Y09F423qhFAtFzlq+600oq6dam3bgESu2acI5cT/oJkLWa1iLwS+D3fvXJ+DsIwXy1vur8WtYDpxAIMzFCYGUH3jLC3GRrRn1Ez6tyL43eCer7LsvU4g3CpingaA+FCXCK542Lh882Qa0Ji2SeKe5UCR5HYpCGBRs8a2UY0t7UJphnRgA6S7daA6+XG39ok3S9gtMsDzyXCsQCKf4RjrWDBaLVPxvvkufHNUPOH0l92hpG6abdZH8/OF62+BJKeeGf664YCVLRBFXxBhK/2kDoh1oA3bCpAe7iRKK1AbWnTG7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 08:55:11AM -0700, Nathan Chancellor wrote: > On Thu, Jan 11, 2024 at 01:11:04PM +0100, Uladzislau Rezki (Sony) wrote: > > There was a type in the vmalloc_dump_obj() function. Instead > > of passing a real address which is "objp" an "addr" was used > > what is wrong and not initialized. > > > > Reported-by: kernel test robot > > Fixes: e88b85b81d5 ("mm: vmalloc: offload free_vmap_area_lock lock") > > I am not sure that e88b85b81d5 introduced this. Based on the diff, I > think it was actually commit 86817057732a ("mm: vmalloc: remove global > vmap_area_root rb-tree"). Does not really matter for the patch text but > I think it does matter for what change this gets squashed into. > Right you are! Below is updated version: >From 98f1fd2d3913f3b7bcbe49785a78f67999151f1c Mon Sep 17 00:00:00 2001 From: "Uladzislau Rezki (Sony)" Date: Thu, 11 Jan 2024 13:04:07 +0100 Subject: [PATCH 1/2] mm: vmalloc: Fix a wrong value passed to __find_vmap_area() There was a type in the vmalloc_dump_obj() function. Instead of passing a real address which is "objp" an "addr" was used what is wrong and not initialized. Reported-by: kernel test robot Fixes: 86817057732a ("mm: vmalloc: remove global vmap_area_root rb-tree") Closes: https://lore.kernel.org/oe-kbuild-all/202401111810.TKPIXLCs-lkp@intel.com/ Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index e30dabf68263..43a6608e1397 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -4688,7 +4688,7 @@ bool vmalloc_dump_obj(void *object) vn = addr_to_node((unsigned long)objp); if (spin_trylock(&vn->busy.lock)) { - va = __find_vmap_area(addr, &vn->busy.root); + va = __find_vmap_area((unsigned long)objp, &vn->busy.root); if (va && va->vm) { addr = (unsigned long)va->vm->addr; -- 2.39.2 -- Uladzislau Rezki