From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E887CC47077 for ; Thu, 11 Jan 2024 15:38:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81A488D0003; Thu, 11 Jan 2024 10:38:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C9DC8D0001; Thu, 11 Jan 2024 10:38:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 691538D0003; Thu, 11 Jan 2024 10:38:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 59C8E8D0001 for ; Thu, 11 Jan 2024 10:38:07 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2AECF120559 for ; Thu, 11 Jan 2024 15:38:07 +0000 (UTC) X-FDA: 81667436214.07.BBDB5D6 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf30.hostedemail.com (Postfix) with ESMTP id 2CFFC80016 for ; Thu, 11 Jan 2024 15:38:04 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iM1qXGXx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704987485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tB1E0ugJK0L2KvGbNzmJDN1gpsgaCYbTOW0J/2QoMFk=; b=oSznj+8xnWjYAgmZabO1XmQ/aqvx0K2svbQ09YdcDt4QsscaisQlosuXZFUdC+f7aP4DYa AQeNQdlDwmDW+AzF8t+WvI11TyQXl4/fS3Mqr1oPomi3XXTqPg7wBUf3eyYXupCagv60y6 8pEaOMyPAL+iv9eYDZo2ULu9nUZ7fQY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iM1qXGXx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704987485; a=rsa-sha256; cv=none; b=YTW5MNG8NpX2A0hwZdXV9j6W2ovi6qQr3l6D5HSkTi3kepgcDBywoFyfPFNv8/8hI+SSmR KpJEY8txmq0lOI1VQboaKS39voDyfDVE8REarm16ssWlwFGkhcJH90r3GNb4Qk/Vmuekl4 J+XsOMMmkk3EIlT0PVfqQsNKb+Fzt9c= Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-50ea98440a7so5664924e87.1 for ; Thu, 11 Jan 2024 07:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704987483; x=1705592283; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=tB1E0ugJK0L2KvGbNzmJDN1gpsgaCYbTOW0J/2QoMFk=; b=iM1qXGXxNJH5wUnKQflRderjEjJcyEVPDu5RE/4eyCHYM0MBePIZDLv8vS5j704TP8 9hcQ9WjhiTMlY69PIOGnTtBhl1l+0BHPD5qkqLAeIrfpXW2nsdkcV95nr6T5ZE+xUPU/ NY47V7kAwRX4KurrsmbweybgGdZ6hADE3yVXfn09WVOdAsYZD7F+R6laTxtppJM3xGfZ S5RTdWi03HOFIfG28rKNeClIOxiGYfMyyxB69PNjaeWom03WWx9fMVosmgbk/kIxOYT7 2JJBLkuL3Tul08V1JtF928/3rXHCE3Qsm/SOdRDuW5VMw8BLhFs/37PXM5gYPeAz/ftt P0Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704987483; x=1705592283; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tB1E0ugJK0L2KvGbNzmJDN1gpsgaCYbTOW0J/2QoMFk=; b=PnEPmrNgT07AP39yzEoC2Q/DqAOEKECGPoEh+G231+37cNg15klhW9OsSSrXnTt13Q dSfh20dEpe6YVQsFQn5ZA+U7CtW1WoXEV5hXuSoTv1bxqrrvk2TPx3N4xWWsWKXaSwbI yrrp3i2K5b6cJIi86Z+lJrtMhP7Elx0png29hnjHgM9I1OE68YjKwDYeNKeNB3uaM8wv wNrq8idqWy+xtMeNBCMEyGC6EAIismrTowDAA6MBi81okhYWuKxNRxdKlT1064eav/xq oxvazl5RPFS+i7fTNOtKIKuCDjUgBsLspO38wfnjNywQNmxON2nQVuHGd1XwlcRqdVQ/ E1rQ== X-Gm-Message-State: AOJu0YzclxbpARCWPO5SdfKUIVYU5Sw4TsHvd43VPytN3/EMlriy0UcP Y+VOT9TXMekD1tkF8N//f3E= X-Google-Smtp-Source: AGHT+IGSaV5E1Nu8lvLDmrSs+V2HXQYAgLdni6E7SHxF3rpvN64HoSAR4JS53m1gH71mWlE4IsfqJA== X-Received: by 2002:a05:6512:61c:b0:50e:ca97:5afb with SMTP id b28-20020a056512061c00b0050eca975afbmr420236lfe.18.1704987483272; Thu, 11 Jan 2024 07:38:03 -0800 (PST) Received: from pc638.lan (host-185-121-47-193.sydskane.nu. [185.121.47.193]) by smtp.gmail.com with ESMTPSA id w11-20020a056512098b00b0050e8ea87dcesm225717lft.169.2024.01.11.07.38.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 07:38:02 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 11 Jan 2024 16:38:01 +0100 To: Andrew Morton Cc: "Uladzislau Rezki (Sony)" , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Subject: Re: [linux-next:master 12999/13245] mm/vmalloc.c:4652:25: warning: variable 'addr' is uninitialized when used here Message-ID: References: <202401111304.N5dkFGNe-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202401111304.N5dkFGNe-lkp@intel.com> X-Rspamd-Queue-Id: 2CFFC80016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9bhpx94js83tgei6y1nhpr11onck4g9a X-HE-Tag: 1704987484-35109 X-HE-Meta: U2FsdGVkX1/pgrmgzaMmv1ZMTg8tQmLyg9Lc/t+OhltbdSV5VXKgzyG3B+Npk9ZqYh4+3UM7ZjxHbkTsNCzC146S3sSID99XejbOorsI2DdxRxrt0SeIv4oGQdLFM4BAGbUOVxKBj838WmD7W49YQN77VSZjE2Dd+iJ90N6aFXfsPZAtbEnrLXVtG/hFab9DQFYIX8fjwp0ZaTeGwJGBKNH1WzZ2Z1VL15mZeVh4NOGrjQKFTcD4xfpx8VJ1Dg9sp5UiH051E8v0sSldGldpzueFFljkL0pihsuXwW3caMA7xHkDB/9wmhr70ypwe757JPevlPiLAgptws2I5ikA2z8A1aX90FIrQ9Xm48dCBhm9kzqZPmZAsDuZv5E7BX/AUlEFb/hiB40New44NO1LCHxnPDQrCabgmWJfs6NQAFlGkGoDbCvNHHDpEZa16DKC9rx0M7b5sMZUYWcFQqSkU3NbZ4zsZDBHNackgnZMtb/g4Ns67c9m97Q3qiln5yD4KxnH2NwpIJdxYGpAthk4NAZNJ/ztc2vUlu+shNsOjiGN7v0XkD8C6G53t4qmFRihD5a6/6ZvBIEABZmLSKhb1Dm2AqIizIOVLS3hKwv5CuBHNNzwbD9c/BBX3xHV0I+mXHeUOB6igkswgZ4QuljBeg4b4fu1//hZ+3y7Jifh4O4QKjPImpNpiKXI1YSIud+3p2jNDN6u58M8It76MBbgR395UMBx0Y/HCoYfj9GgUU3zjW73XSFvMPjrKkC4zNEV8zKTF36IqWnq/3Oswhun+uoUL0jDq6glfmZo8xayv9snQlBJs/eDCMoDB/UoD4IEPpt1RDplqUJ0zpokqRsXlPcXPwo97KhZ5a8/bDUBRR6pOKxUfztBUBRoMcgT7FTVtOdy32PgiN9gJfSrHrs1x4kce9BAbk/TuelK5w1R88C7fiu1tMolOL/jYuqJzxl7PGF7tjPlFH+lp7qI+eu iZStZNG+ OwTjxN2nSQw0/lu+0AA9DL4d+Z8mLsfMWjZ3gb+QC+Rj0KkNIYmlx11OfyFjk/UhM6wtWo5pnmeWUXbE1QTDlO3zrSIcDRiZdscmBX5coo7AquO5yfVMrpF/cSh7H1DRlKg85J2EIIB+m3+WIVkmQinAwYaW7QDOM1VhWIAE4ZvI/wzOj/TCZx5GNgJ8rJN09ifMQnNS65JIGpr3qNpSBNTXDuzNTZD4RFIgzAptLi0h2KO/I+/1eiGUdxqRzygAAL4L93aYPmvWQgnpP0EPtSCIwvUMa4NCjk34n8oIY6ZSkm7aAtjJGIVmSf8WBr6kF7puGb9SgYlhTIfR4anDbw5cKJMPotNQ6lFqM0nTnp+5TU9c2TW9s76QSc5Hipzu65zNi3L1DU8U9opxrIQAfk93l2NbDe4EYt8rr1HP44hiWlWwP9UE+t1uQLPNudziQr57dPaGqlZd5SZLQysk9GAGtPDy0eefD4Iryh6pkhjtL61cZg11Cv7rdZYoXTqt7WK2H7DsFtxLA+8HshpqxY9TlhEVDrIgMBA1SYyaUAyiHOoCYtjp6WAbqMBsDuYIX86G+gC2lU4Y9n6c1PsuVaAwmv+kBunRqDUuG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 01:13:59PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 9e21984d62c56a0f6d1fc6f76b646212cfd7fe88 > commit: e88b85b81d5313a69cb62829b957d4a9ecde600b [12999/13245] mm: vmalloc: offload free_vmap_area_lock lock > config: arm-defconfig (https://download.01.org/0day-ci/archive/20240111/202401111304.N5dkFGNe-lkp@intel.com/config) > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240111/202401111304.N5dkFGNe-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202401111304.N5dkFGNe-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> mm/vmalloc.c:4652:25: warning: variable 'addr' is uninitialized when used here [-Wuninitialized] > va = __find_vmap_area(addr, &vn->busy.root); > ^~~~ > mm/vmalloc.c:4645:20: note: initialize the variable 'addr' to silence this warning > unsigned long addr; > ^ > = 0 > 1 warning generated. > > > vim +/addr +4652 mm/vmalloc.c > > a10aa579878fc6 Christoph Lameter 2008-04-28 4637 > 5bb1bb353cfe34 Paul E. McKenney 2021-01-07 4638 #ifdef CONFIG_PRINTK > 98f180837a896e Paul E. McKenney 2020-12-08 4639 bool vmalloc_dump_obj(void *object) > 98f180837a896e Paul E. McKenney 2020-12-08 4640 { > 98f180837a896e Paul E. McKenney 2020-12-08 4641 void *objp = (void *)PAGE_ALIGN((unsigned long)object); > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4642) const void *caller; > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4643) struct vmap_area *va; > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4644) struct vmap_node *vn; > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4645) unsigned long addr; > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4646) unsigned int nr_pages; > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4647) bool success = false; > 98f180837a896e Paul E. McKenney 2020-12-08 4648 > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4649) vn = addr_to_node((unsigned long)objp); > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4650) > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4651) if (spin_trylock(&vn->busy.lock)) { > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 @4652) va = __find_vmap_area(addr, &vn->busy.root); > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4653) > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4654) if (va && va->vm) { > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4655) addr = (unsigned long)va->vm->addr; > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4656) caller = va->vm->caller; > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4657) nr_pages = va->vm->nr_pages; > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4658) success = true; > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4659) } > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4660) > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4661) spin_unlock(&vn->busy.lock); > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4662) } > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4663) > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4664) if (success) > bd34dcd4120d7e Paul E. McKenney 2020-12-09 4665 pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n", > 0818e739b5c061 Joel Fernandes (Google 2023-09-04 4666) nr_pages, addr, caller); > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4667) > 86817057732a9c Uladzislau Rezki (Sony 2024-01-02 4668) return success; > 98f180837a896e Paul E. McKenney 2020-12-08 4669 } > 5bb1bb353cfe34 Paul E. McKenney 2021-01-07 4670 #endif > 98f180837a896e Paul E. McKenney 2020-12-08 4671 > > :::::: The code at line 4652 was first introduced by commit > :::::: 86817057732a9ce9cefdb6f513b6554a55ebbbbb mm: vmalloc: remove global vmap_area_root rb-tree > > :::::: TO: Uladzislau Rezki (Sony) > :::::: CC: Andrew Morton > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki Same, i sent the patch, but just in case i post it here: >From fa613edf6c3d700a02ef109cbd42633b5df30abb Mon Sep 17 00:00:00 2001 From: "Uladzislau Rezki (Sony)" Date: Thu, 11 Jan 2024 13:04:07 +0100 Subject: [PATCH 1/2] mm: vmalloc: Fix a wrong value passed to __find_vmap_area() There was a type in the vmalloc_dump_obj() function. Instead of passing a real address which is "objp" an "addr" was used what is wrong and not initialized. Reported-by: kernel test robot Fixes: e88b85b81d5 ("mm: vmalloc: offload free_vmap_area_lock lock") Closes: https://lore.kernel.org/oe-kbuild-all/202401111810.TKPIXLCs-lkp@intel.com/ Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index e30dabf68263..43a6608e1397 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -4688,7 +4688,7 @@ bool vmalloc_dump_obj(void *object) vn = addr_to_node((unsigned long)objp); if (spin_trylock(&vn->busy.lock)) { - va = __find_vmap_area(addr, &vn->busy.root); + va = __find_vmap_area((unsigned long)objp, &vn->busy.root); if (va && va->vm) { addr = (unsigned long)va->vm->addr; -- 2.39.2 it can be folded into: e88b85b81d5 ("mm: vmalloc: offload free_vmap_area_lock lock") or applied as a separate patch. -- Uladzislau Rezki