From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DFD4C47DD9 for ; Mon, 22 Jan 2024 17:20:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04EFC6B008A; Mon, 22 Jan 2024 12:20:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 025D06B008C; Mon, 22 Jan 2024 12:20:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E57E56B0092; Mon, 22 Jan 2024 12:20:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D436C6B008A for ; Mon, 22 Jan 2024 12:20:09 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A286AC0993 for ; Mon, 22 Jan 2024 17:20:09 +0000 (UTC) X-FDA: 81707610138.14.DEEFEDC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 03A6B40018 for ; Mon, 22 Jan 2024 17:20:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rKSMLV0v; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705944008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QZnq9d/ql8GroW98ZcPl4rKdarm4gbQiACxhNouKKyk=; b=6xiTfW+sYRuLeq1hK6dsejvxa8CE2EVOqtwnNzwhOUBV9gTrkZn1aD2FNutDds85AwVBSM Wcu410reHygrphqxWC6vROaHSJhrOna2t7qtsLchZ/ne+jx5FfQ5WpQqUYS1WPSjpqVMsi 8WJgMxXoVZnWZUZYdETyjxdd55DumwE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rKSMLV0v; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705944008; a=rsa-sha256; cv=none; b=AbWiDdSwIhosIeik7e07VnkyKNKeaUxoLQOA+wRPr7fngSmzvOaWUEw2n51LX1nz7TZFcI 5XB42W/w/Vpei76OKRypLDwkdq4PWqUj/nps+6KmAeE7y8VEQ9d0xAEmEUjN83xaNLVpse 7JugelSYyMw8+IFeVpXwrAe4EC4zPzg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QZnq9d/ql8GroW98ZcPl4rKdarm4gbQiACxhNouKKyk=; b=rKSMLV0vZOiq4t5//yK/ML7/k0 qcJHPgoem3o2uSvaXatcJXk2JsoZ8aC8lTfQWFynshAf+GS4MMHtWhvXNCV7ff3rURgl5qRBFhFdC ZTkTMORo1WgjUIEysDLtcnoC0tO4O830pVxou3tR5mwzvI8lCqhNHwuvVakBSnhjCf/ePemx1lpV5 igP4rJuaOZ6LRXQ3yfum55VLEWx+VgBmuUvmZPludQ0h1CLTPlA2fIJMdVqIsYVz8MhMkXxGUaIid tTarsXHOaKJX2kgDeBkwnBLdiZuQekLF4whxJTJoB5ePyF2usKy4Yr+mfD3o+jIZkx2MQv0TbJXnd ntsZWp3A==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rRxxt-00000000WB2-0xp6; Mon, 22 Jan 2024 17:20:05 +0000 Date: Mon, 22 Jan 2024 17:20:05 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu Subject: Re: [PATCH v2 28/40] mm/memory: page_remove_rmap() -> folio_remove_rmap_pte() Message-ID: References: <20231220224504.646757-1-david@redhat.com> <20231220224504.646757-29-david@redhat.com> <2445cedb-61fb-422c-8bfb-caf0a2beed62@arm.com> <007e83fa-16c7-4700-b326-ee8cb7809f9f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <007e83fa-16c7-4700-b326-ee8cb7809f9f@redhat.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 03A6B40018 X-Stat-Signature: ppuo4oq33nfejtu66sqsmajaqba93kc1 X-Rspam-User: X-HE-Tag: 1705944007-241815 X-HE-Meta: U2FsdGVkX1+q8amkjW9ZKCbHV9FtPNIZ6uQYyuW0MdVn30cA03nSHyA2gzTiNe3m5QXag/jrgINMFzvZgR94To2//BCJsX+QNyts/m+sDceqXg03WWIqhekZpY/8N+2ES0tAB//7+NSMq6inM9aeuJk88RIhXc7SN28BAsBqJSzBErO5Gi/AOyfA5NwAp3WQCmMv0P+BcDTLAIwjzK9AzkHbZ112v+xtQYhpSIjVpaUIBrLzmnTxebktHfAiZemw/r+SQyP1A1e0p6SHb/c0IidwYxWbsypUpZHM1CjT+KTJ1YJ/SManH1PT1pRWcmx2SVJ6KfmWUPmCBQoqWqJDKdCII1c1nuIx4ETOOJXnktxQa+kZ5bc2YjfazzK4yQOmpS2VKkFZP6MZIAcVh+9kqEhZNNCztovjofVf/7f+E8y7gODKGfxvCRIwAESqHXl8vIae0ll3+7dfFhCxqfMEboUf5BMlFIXHs5hNIeXC4Tj3TB1RiO+nOTCYF7TDbZ3rGEUdDe6BQYI2WUnY3Ojxn1YQ+aBko/Cc5eyLxTS95BE57LNNz8mKPyS9jLHpqQ5qG20VASCsCXYIMWICYBX91j3Nqk0ENyyMcdvj2gWNkYbDjnT7eCiG/fBCSdgT2hy4fUKh92fdnCglRFK3T7de7WjZ1xiXJ7kx1fqvR8WJTO6d2UbdpoI56PPuXn2MAvUaqUpIm2vYSpW33L+zRnJ8hg2/k6hPJB7Oxm5BRgNYlbdPPj6RhX29cEx0dLOKpRNdC0S8uuWsDHRNo8SGRb/H5vTG0qz4EwC1ByYbGN8yU2q2QGMCtTnBD2eTNg6yovLDPtvGk5WBxPW6xYy8Aw1TR744SULvep8oeh8M9GsFS2eEdIqvJlo+cCb92ifXpI3em1SZ844HHMNxKw0fX0I7bBgGirVXYwp2MIYIrPADLkjvpnBX5r3VJ71MIOQUXsVBg5cbY6TPmOs8VCBw4+P OZgBslOn 32c5xHyBw5kDWVx5bAEgC5Ca/60glh9TBR8+t2/68IZPDKu3efZQAsX4XA37cdt0kmzdoHG70M3cOg8Z+TAjMJmiRaoQzRvaGw5zUNDEPxIcq/PLtkuAeEDdzVhqHOq9Vr8CsGyi9IILr42Zm/maZzYj9QQl3ZOiFGM0/aOT6gsTqVaevVdv8IDr/Bg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 22, 2024 at 06:01:58PM +0100, David Hildenbrand wrote: > > And folio_mark_dirty() is doing more than just setting teh PG_dirty bit. In my > > equivalent change, as part of the contpte series, I've swapped set_page_dirty() > > for folio_mark_dirty(). > > Good catch, that should be folio_mark_dirty(). Let me send a fixup. > > (the difference in naming for both functions really is bad) It really is, and I don't know what to do about it. We need a function that literally just sets the flag. For every other flag, that's folio_set_FLAG. We can't use __folio_set_flag because that means "set the flag non-atomically". We need a function that does all of the work involved with tracking dirty folios. I chose folio_mark_dirty() to align with folio_mark_uptodate() (ie mark is not just 'set" but also "do some extra work"). But because we're converting from set_page_dirty(), the OBVIOUS rename is to folio_set_dirty(), which is WRONG. So we're in the part of the design space where the consistent naming and the-obvious-thing-to-do-is-wrong are in collision, and I do not have a good answer. Maybe we can call the first function _folio_set_dirty(), and we don't have a folio_set_dirty() at all? We don't have a folio_set_uptodate(), so there's some precedent there.