From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03539C47DD9 for ; Mon, 22 Jan 2024 16:10:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65CAA6B0092; Mon, 22 Jan 2024 11:10:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60BDB6B0095; Mon, 22 Jan 2024 11:10:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D4726B0093; Mon, 22 Jan 2024 11:10:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3BC936B008A for ; Mon, 22 Jan 2024 11:10:11 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0DB6614056E for ; Mon, 22 Jan 2024 16:10:11 +0000 (UTC) X-FDA: 81707433822.23.0025EF6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 4309C1C0010 for ; Mon, 22 Jan 2024 16:10:08 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="bAHg37/D"; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705939809; a=rsa-sha256; cv=none; b=ayXBotWQntSUtnD1n2CXUwMwk0T4cTmcJ+bFDhSWwLy1SlEk+U4q0QjupJimJakkArTSpk wXoPGGKu3uswcB/7Ss0Ezo+/gEvMBu6a7Nk+ASTBBBXrg5oFVyJMppTwhls6nhHHv6uMZl n4LRG3vKJNjmRGCtNzzJdMfcEo+OOXE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="bAHg37/D"; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705939809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NGNHyrHMg5T+Qh7WpIiamACVfA9Z4Rcr6JKQhuA9VEY=; b=vMfwx3e+A72HZHDnsVHuxiBCH3TJV7VABpivw842ADpq2Ky1d90GkO0zUBsZQEky9cHpbo NXkS+Y7/tOJnRgWBoL8iBm6PGl5iW9LHJAlYcNPCK5KtfFj+M7lcohddmCJPZz0DdXwfVQ q30Ed3lI6J7og452Z4uN3XOU52gyw28= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NGNHyrHMg5T+Qh7WpIiamACVfA9Z4Rcr6JKQhuA9VEY=; b=bAHg37/DgOA2D7Nup2N9IoSCUf RYBdsFsEU0xkski0IK2yvU1A2OMrf/qhwna0hlIEwWl69adYPIHIu53ORHNeF2VBh5Hg6YqXlDLij QgT/abpxa9Ic03QJaHTpi1JbsPKKSfAD09GSoo5WzRD6w09XhsCKb33KdFEtAaiQroP+/MBSczuBJ PUqlXM14wca8GyUxdWtL6h281dGgW485gjFNKwYDyeOQmtaqKuC5cFXaOk2jp+fQu2XsCOZRo+WJs UhFEoChHuXUqVFkeJ67BcBHkeCQZslkJMYJKeIyQiOigfY3G+09Cq0PK3aHfIXU01a0Vs85+b2vdc ADEmH24g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rRws8-00000000Mhy-0VRc; Mon, 22 Jan 2024 16:10:04 +0000 Date: Mon, 22 Jan 2024 16:10:04 +0000 From: Matthew Wilcox To: Jeff Layton Cc: David Howells , Christian Brauner , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Subject: Re: [PATCH 01/10] netfs: Don't use certain internal folio_*() functions Message-ID: References: <20240122123845.3822570-1-dhowells@redhat.com> <20240122123845.3822570-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4309C1C0010 X-Stat-Signature: dh78qhxutq5d8gyeh1hsco4yqiq9ww7d X-Rspam-User: X-HE-Tag: 1705939808-479010 X-HE-Meta: U2FsdGVkX1+L/Mf36cvPZH6PTNqVAWNSIptJpug4OPsMBWqy3p94YxV3sSeiiDia7ldz/Kc6ArvA1p1VDgfy5NWa/kKOCzrlq2v6FU6hFW6exj6+myYmH2ST0wahXfaGuZk2/+vXD6CAFKHGj8wSbXe+duqUmKbcqv9aXzx5F2KyhP7f1Ecg+FjCQljJ7FqzLg19RZq1805ULdnkVBRIyC7HLCiqGQuZAq8N8P+soFwZ3BiQEvQpfuPY6SpZdPVbfQDEuOfpfen5G71z5W/4OO1IiO5pk8HXpcx0voAE1cpsD06SXv/55Fqaoh7vGGt7mHoVOr5ISINeQ/l/oObkVAH3Fhx/w7lzbUiyaOoSiI5C4G/ECA3VPAWFnP1jS1dOi7qiwxbtT2W30DbzQHP/oUQiVMeWUD9Ingn3Z0hS3HcOOSrUsYtNSgml+TbUolzh4ukr+C7gZH6D4sMfrjFdmfO4/1sg2j9u6xCKWCoFvT2KcJHk3TtHkemNcFj6bVQGD8A0EbI3ObxJO6Sams49wrVFo/pt+DsM0NKlnrHQphWvuwhFUTi1259xL4mRKMgcnQdB0it78HeTqIkdGegqGnxCBN7ZcYx4jNgOwW9ATKzk8g0TF1wWXBq+MAZH36WagPWQdrLYmonp42kOiRdKdvVfvmpT2g80ST0PZg3oxbKTj6MkQQEnPXsdN+RxM/xoq8sfJH+TKPuYpTnerZTJzS1PAbBEhvcEl7qOyAyS9QwaRjZhFNG4Le1cBBOYKlArDeOV4zayI3DRnwNHWwiGCiw4kgxeXs3cAGCI6HmAobjTTO+vuGagZUTiWFY6CdIWpSIq7I4oFPMzxy3mGxwIt1SICu/v7GZkgkk/KP8ZAMR+QatXliTiZHT17kZDKD03eqHXgDrhvDumjTpj+TILgVyyuVpEiM3oPGzqpDL7xDEanB8wHklMWDBEqXyLcgvVDLWJ+9tsNyaAuJSpXX0 x8+xwbzB ND61hYZ27+995m2yTuMuWkLld8yhMdydpaHfUBBr6x4+L4lm1FhTcrVglEitigFqerLRef4iz5UlZStv5hXekIL9Jdp8kqg+Eg9JRXQ82XWGUEQuFKRJAXxXZ7foRAOhgZF2hXKuP96Cp9+vRa0mC/akNYTTNkcKwjnj/sELNGg5amlxTWJpsf3iyJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000433, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 22, 2024 at 10:38:58AM -0500, Jeff Layton wrote: > On Mon, 2024-01-22 at 12:38 +0000, David Howells wrote: > > Filesystems should not be using folio->index not folio_index(folio) and > > I think you mean "should be" here. Also these are not internal functions! They're just functions that filesystems shouldn't be using because filesystems are only exposed to their own folios. The erofs patch used the word "unnecessary", which I like better (2b872b0f466d).