From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC44C4725D for ; Mon, 22 Jan 2024 13:51:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB8B78D0005; Mon, 22 Jan 2024 08:50:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E695D8D0001; Mon, 22 Jan 2024 08:50:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D31188D0005; Mon, 22 Jan 2024 08:50:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C36C18D0001 for ; Mon, 22 Jan 2024 08:50:59 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6F626160922 for ; Mon, 22 Jan 2024 13:50:59 +0000 (UTC) X-FDA: 81707083038.06.FD05538 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 21AF91C0013 for ; Mon, 22 Jan 2024 13:50:56 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ZGmPYeut; dkim=pass header.d=suse.com header.s=susede1 header.b=ZGmPYeut; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705931457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gJUVDk8RMleasp0nmDcW1YGOWvYqxPQuw9VSvws+tuU=; b=tldbcA6XW4vRNo7yADKY38lQpHPRfD3wKVQ4lbYReldBeet4nxxiv/4vraWHkYnvtA+5cw 7VREmGDUviZvAsGwsNauITMnxu4Ojq/IILKkiFhEFmIV8zphVnS5aTldifs4c7T0i7N5Rx NRJd/2IwBFOVp1OfXWkRweYg5/YvCCE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ZGmPYeut; dkim=pass header.d=suse.com header.s=susede1 header.b=ZGmPYeut; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705931457; a=rsa-sha256; cv=none; b=71MwCJ2nCwC0X2XkkJKt2s4jGv43AzOdWqEyIyCT/SBwE+89zoGxTj8pVE1aN8hXm+Xro5 M61waRAjhCR6QqoXmVtGH4YX8qDr8FFPl/2qhWdJROYmT1MkE0swwUgM7Uly9azgKGAr21 t57P2Lp9o6QyGsmMvQXHbSHES+VNd4Q= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 37ADB21DE4; Mon, 22 Jan 2024 13:50:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705931455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gJUVDk8RMleasp0nmDcW1YGOWvYqxPQuw9VSvws+tuU=; b=ZGmPYeutI1+Lm2slp2P6QkzY7igGN2LeXmJ8jnoqpgwAJsAdiI6i2qzjTEzSGn1l0maGyM GwWP+8p2LFj2ALmOy+v+vEEKvkgDMceU6ij4B12u9E3JQo3/bIoao0Qwukrzic2bCqacQL VAiFFY0aAf/bIZxsInnazudy22OFEiw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705931455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gJUVDk8RMleasp0nmDcW1YGOWvYqxPQuw9VSvws+tuU=; b=ZGmPYeutI1+Lm2slp2P6QkzY7igGN2LeXmJ8jnoqpgwAJsAdiI6i2qzjTEzSGn1l0maGyM GwWP+8p2LFj2ALmOy+v+vEEKvkgDMceU6ij4B12u9E3JQo3/bIoao0Qwukrzic2bCqacQL VAiFFY0aAf/bIZxsInnazudy22OFEiw= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 18D2213995; Mon, 22 Jan 2024 13:50:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 7x4XA79yrmVOSQAAD6G6ig (envelope-from ); Mon, 22 Jan 2024 13:50:55 +0000 Date: Mon, 22 Jan 2024 14:50:54 +0100 From: Michal Hocko To: Lance Yang Cc: akpm@linux-foundation.org, zokeefe@google.com, david@redhat.com, songmuchun@bytedance.com, shy828301@gmail.com, peterx@redhat.com, mknyszek@google.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] mm/madvise: add MADV_F_COLLAPSE_LIGHT to process_madvise() Message-ID: References: <20240118120347.61817-1-ioworker0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 3me7sqeqn1mfcincnnq8z7143gaiqcsm X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 21AF91C0013 X-HE-Tag: 1705931456-798754 X-HE-Meta: U2FsdGVkX19vwonPbDgYH+a7/Thnw0m0MZh7eglcm7CqVjgvOd4XjuIWNKkpnO6xkNoWI4s+RczazyYrJ4O+OqnPthrnOm89wwhctAjtpv16+s9wiBQGAMZKaDV0vgvr5io/ZUaWi3OAir+DeGCWCboewgn7ycEqFVNVoF1gjwjq0V+De6bc8r8OvvLtrvrBGfJfNbhMmfT3k3/+jXrQNcho+2VhUrHLKdS50UFlOkmLNQjHW8RiW27RmiwbAgN7OWxWQx3Oohq4IsMFilP/cajeQcoYNvhSt9KTphdouFrk1VmOIh+Mw1z0DqqXVE3lLFgs3D8orHWESIvPBcmEdDjFxSyP8NjSqZwB0CCDY8z1mpKyoqMBMjJ8GVkXT1dBO62YdYevQAcxESDVSyrtjNj2tlFWJyGd4eBzwz535qg1MarpHPKyTWekXS4k+p4HT9/2y9ftTeEeR1tEbLk23HhgF0X8c19csvUC6z/H8kP6BNItEto24SAbzV07g+yEr4cBzIN5vuhlJ4+5VFfy3xpzALXJcbLb50Hjlx24rqwsS24ih7M1Q8Q2GvLxoLSxYeQVD8thBg3z59k0DJ+vmWMfVWNjNZkzqxsVxTA4E67RmlSXDZVJD/08jO734nODOT3FSTFpYz0N4LaFyOfNuZriOV0RqHjxWIbM1+qaFl0kpzu8B7B7G0Yt7WtVNnFOKDgPBubsF5WAt/B8EY6X8sdQUzll+SxVoMbz0LcB0xc2IfxSB68i48a90bUnesvWI9QkaDOrIJ2scd39h6/3Z36xqVCGBc9x2CLVAZkgjxt4NPAoM1V38b+zEbltE1kQY/YUTkhcPucM/Jtb6YyrDXMK4MhNvO8xeqQjrXu1pt9s/oXx79z9q+EQzjY6ZJbhGCpEXUEHdOQgmFGQ8EblTnB0OV/q4OjcffNulmNgjiI4Cv470cvg/V69ocjOhgmGWENBHI3G4s3vGNWZFFO 6q+gnODM iL64HEYF5YyinWbVIJUG6S2n9ICd9b73nlDStrTlr6cbfbAZfI3LGFY4l2/KMIhGJnwtELwtrPl0OMll6pysA9r1jBM83nwcQ0EIy2fGaOByt1C5UFA9/Lknwfkn4Ds2H0dc0n1VHwTGeWgdPC+mXdkFBsdRynCcQeZxju7TCzVyi682Jt6eqjNoq+UtHgPl6hd0O4FuVdmL+usVV4Twm9gN186Uw7mstBDN1P5qavtXSV8woVOyx9Ze3BJH4DDPGN4h7MRNgg1zet44= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat 20-01-24 10:09:32, Lance Yang wrote: [...] > Hey Michal, > > Thanks for your suggestion! > > It seems that the implementation should try but not too hard aligns well > with my desired behavior. The problem I have with this semantic is that it is really hard to define and then stick with. Our implementation might change over time and what somebody considers good ATM might turn int "trying harder than I wanted" later on. > Non-blocking in general is also a great idea. > Perhaps in the future, we can add a MADV_F_COLLAPSE_NOBLOCK > flag for scenarios where latency is extremely critical. Non blocking semantic is much easier to define and maintain. The actual allocation/compaction implementation might change as well over time but the userspace at least knows that the request will not block waiting for any required resources. -- Michal Hocko SUSE Labs