From: Michal Hocko <mhocko@suse.com>
To: Lance Yang <ioworker0@gmail.com>
Cc: akpm@linux-foundation.org, zokeefe@google.com, david@redhat.com,
songmuchun@bytedance.com, shy828301@gmail.com, peterx@redhat.com,
mknyszek@google.com, minchan@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] mm/madvise: add MADV_F_COLLAPSE_LIGHT to process_madvise()
Date: Mon, 22 Jan 2024 14:50:54 +0100 [thread overview]
Message-ID: <Za5yvjZWVyYjgyfh@tiehlicka> (raw)
In-Reply-To: <CAK1f24m9oxciHsAht4-cCWo_NT7x+bkoXUO2HOwgMCr0OnwpcA@mail.gmail.com>
On Sat 20-01-24 10:09:32, Lance Yang wrote:
[...]
> Hey Michal,
>
> Thanks for your suggestion!
>
> It seems that the implementation should try but not too hard aligns well
> with my desired behavior.
The problem I have with this semantic is that it is really hard to
define and then stick with. Our implementation might change over time
and what somebody considers good ATM might turn int "trying harder than
I wanted" later on.
> Non-blocking in general is also a great idea.
> Perhaps in the future, we can add a MADV_F_COLLAPSE_NOBLOCK
> flag for scenarios where latency is extremely critical.
Non blocking semantic is much easier to define and maintain. The actual
allocation/compaction implementation might change as well over time but
the userspace at least knows that the request will not block waiting for
any required resources.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2024-01-22 13:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 12:03 Lance Yang
2024-01-18 13:28 ` Michal Hocko
2024-01-18 13:40 ` Michal Hocko
2024-01-18 13:43 ` Michal Hocko
2024-01-18 14:58 ` Zach O'Keefe
2024-01-18 19:00 ` Yang Shi
2024-01-19 2:37 ` Lance Yang
2024-01-19 1:46 ` Lance Yang
2024-01-19 2:03 ` Lance Yang
2024-01-19 12:51 ` Michal Hocko
2024-01-19 14:08 ` Lance Yang
2024-01-20 2:09 ` Lance Yang
2024-01-22 13:50 ` Michal Hocko [this message]
2024-01-22 14:14 ` Lance Yang
2024-01-22 14:34 ` Lance Yang
2024-01-26 23:26 ` Zach O'Keefe
2024-01-27 8:06 ` Lance Yang
2024-01-21 3:12 ` Lance Yang
2024-01-26 6:16 ` Lance Yang
2024-01-26 10:15 ` Lance Yang
2024-01-26 12:52 ` Lance Yang
2024-01-26 23:46 ` Zach O'Keefe
2024-01-27 8:03 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za5yvjZWVyYjgyfh@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=ioworker0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=mknyszek@google.com \
--cc=peterx@redhat.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox