From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8B96C4725D for ; Mon, 22 Jan 2024 11:57:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61FE26B0083; Mon, 22 Jan 2024 06:57:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A8F16B0085; Mon, 22 Jan 2024 06:57:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 449576B0087; Mon, 22 Jan 2024 06:57:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3066B6B0083 for ; Mon, 22 Jan 2024 06:57:52 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0B33F12093B for ; Mon, 22 Jan 2024 11:57:52 +0000 (UTC) X-FDA: 81706797984.04.571544A Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by imf13.hostedemail.com (Postfix) with ESMTP id 2169720006 for ; Mon, 22 Jan 2024 11:57:49 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=q2dEKfrB; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf13.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.54 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705924670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rBTCIVRECIvcLt6MaQno7tlMWYABkSGiG66d1TLm//8=; b=eSyFPeHisABjSfJOxkTM+yBAppT2v21ZDZxsJXo7Uqzz0KZc+l9/BMeXQfCjkJE93YtrLR I0Y78rytWAhY7+iKZTYyionXuo7CtEnV1MVo2o507gLlUQlZevKyliVCt7124GSn588wtJ +TlmOVsDjhcD4r8eONiBZjfAlQTnTuo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=q2dEKfrB; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf13.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.54 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705924670; a=rsa-sha256; cv=none; b=LXESWRYnolr+Yye4f5jr5CPoKuzpY6qjOdP+FHx1nHGj1hrOM63AswZu75Mn4s59hF/M/c A4mrZmD7GFSH31ATMgp0b1yYDb3fGjWWZggEP5Q6ahTHLO9QiiwWGpX/kXiH3XaXd/stz/ 6FaQaeu6Fs6Ve/UtJtCsEoCKaBwJ/OI= Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6dddfdc3244so2329720a34.1 for ; Mon, 22 Jan 2024 03:57:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1705924669; x=1706529469; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rBTCIVRECIvcLt6MaQno7tlMWYABkSGiG66d1TLm//8=; b=q2dEKfrBAJ8evd1rQzzFrz0F7eNQxSyNjbAShUSZFkXfaYUy6aVpXo8Z4mSgjYk1vb nArdmbizy976X0Gu6pw8+c82X63AXm9Rh/B19cKCJnPV0NWoHOy9PGGsVS9kXSiKqJaE uSkYC62EZ/FFcAcEyELEcqBxS7zxooF+wxdjbLb4/VsK0vHyVtrVS5TV9UwLTEZTQRB2 dbdRvZqoOVw/2yfJwGSIWWXiY43zKUCWZWFLK7go/4JytPztwDPDuLuvYUU3OJl47KgF ZxqvgfDA/PxTeJsvJ5INNLhSwqvVR32wUwpRx/oXmVIlywsDlUJHTOgiPj2g7rsS0DV5 oFgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705924669; x=1706529469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rBTCIVRECIvcLt6MaQno7tlMWYABkSGiG66d1TLm//8=; b=T29jPXT/FleD3KER6ylriFX40pr1Rvz6QE3kjXEgq4Lf/Zoienyw8LmG4WD683f2Vw 6xzbV3+lwGA3KjHlfCzq3ZaJJ+ycSUYz9yizMGHRoVHFEh5jHXJcMVBfjnQXdOuyKMaT 3EC27mLoAWyVWi4jNuOnllZ7dGJMtmhOvZsxNAJoPCzIrancNI/omokpSu1vEPq3I/0/ zBZNg0ajvh+HVfE7CPj+xfw405hdFKgFC4F7hCkPlx32CxkFUQ0Ut8YpxEDCkCTOoSHn yznOPwko1RkH+RXCka/vhrspJGDFhjI3QnroaRmHSK4BE3wOQZG+UU2DqMEzZ9+vHtoE EFSw== X-Gm-Message-State: AOJu0YxM54QkV0/eInIfODltLE5YwXJMJAjxVC1uhxa+XJfQ5l6iKG3D mfPQZQM3blE38k6KZijyjzkF5HmO+mdrFv9LZiDSYQcFuauuW71xK005SqoJRHs= X-Google-Smtp-Source: AGHT+IG1mTJ4MmTpOsgs4i6bFvFqiyjvVZWwtCZ27AojSnabkbNWPld4qMXAwbH3QYm6tNCqfYSYeA== X-Received: by 2002:a05:6359:2102:b0:175:b707:c92a with SMTP id lp2-20020a056359210200b00175b707c92amr2484028rwb.33.1705924667818; Mon, 22 Jan 2024 03:57:47 -0800 (PST) Received: from dread.disaster.area (pa49-180-249-6.pa.nsw.optusnet.com.au. [49.180.249.6]) by smtp.gmail.com with ESMTPSA id l2-20020a056a00140200b006db0c82959asm9423428pfu.43.2024.01.22.03.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 03:57:47 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1rRsvw-00DlCx-1R; Mon, 22 Jan 2024 22:57:44 +1100 Date: Mon, 22 Jan 2024 22:57:44 +1100 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] xfs: convert buffer cache to use high order folios Message-ID: References: <20240118222216.4131379-1-david@fromorbit.com> <20240118222216.4131379-4-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2169720006 X-Stat-Signature: fo1n5obeakpnb57uijim49tju13xmx4z X-Rspam-User: X-HE-Tag: 1705924669-729817 X-HE-Meta: U2FsdGVkX1+BseN4Al2pxdJ4OWXXkFiVaIzSipV5TLsL/LABE7ePn19rkQ/KlMJ4ShlchQzxozT+4RTrNdIt5983Hxeedv1Ay7Cai+4z9w7Se1Ta5PQDwwQa/59k0qVDXYUhENa6FiQqcHzcX92gsEpErTwGLGQ3TTIRr+CaGlZN8YufxlF9ElQE5ul/qnhMRI8MXaUr9uvjDIJzmoFFywPsgNMD5Xcn504lxhge9F/za+X1pHcxzDI1rDDMdT4JLU6M8bHktkPMZMNM+0xktAplyXurFONM3unAW/CcZyb2zEuRha1oXveEREb5fL/M8mJvHC/iB1eUzJWDrVNd7WusFrf9947SuYSJ/v1ULlrPSSp2vWsLl9d6acA6swKy9vVNvAmTnpvD2Rpi3lETIXnXIgXLDxplulDVCIri6EtVw/r/NK0rU75sp0vAsU+QVIxf6xLF3/w/Du7iHdXOzHTfpDvC/mv/YsUwqnos2U0FkW58egj+TANJndbrdc1HESCaayMH3K4zi67RPQ2b9hDdrd9AcuCSJ/bh4shu2r5hyqEGhYl+VGenMkPzUrnZXAHdrFH0JcnoAOzr7+qJvtGe9zmDp52voq8DA72qbzuIiXC0UJzGUhMJRsGi/4MEKtDVV+LXBSDix5Shg3qXI/38B48wLExLIYPDA8czcRXR25k69z0/m1+TLBNyq11owDWF7mqQiPVMuVsv+YdDSVJL3PptIBu6BcFFO5g8cDnTiqIy/wUc0SDK820WYEJ7VF8PtqoX0ZdYGQ4vdJMGDTHrau2f2BgVzpQ32sC6ReV1MWs4tOOcUrPrCUvTtxQpxF0xfAUmXHniKaF3xsE+0Tzkp4VanpzpWrGDUsHJcOyqfhbuVzz7lNZ/hzKgKajmGli697XzD1xPok0ThzNkR7CFqCLCMt2qQ/0SZTTz9lU58Gi08PGx3+XQuXGRKCX1L0dbkcHD15dxc2fG26T 7pwUtFJi cQ4rh96Do2zpPV2QoRIQGj/EEoFJMLvda7+BZ96popceHZ18hUl8QNY7f8HOQRRN0mXCJH7JOrndm8c71tEWiupjwVFE33v/JPoAbPXRkSMB3xnrUsvIHMNSHXbpC54o3NNyOTi7nCDXhI+2owzDJZ9dQi2rCr+D8MAkMLxgzyHulxTkAN02Xg6yGe5dS1Wmhb7mKsd+sfZhQK09zRoo3KQGL4q7XrUpkCMdIKesioenJT47aRb0rtn2kzlK/62t9+vF1caVNCoawm0xC20P7utmSR4iMRlebHbZx6cq6j3vhyaSsaevIE7YIugS2ro+bnNrw7d5ppCA7xGpcZfoPjN8r7rmnfl8a1e0VJjL91M35z5ZTuFQWIgvg2gLu2LOQQPUn7mkpGgG/9Vwz9Q4i5ugYAgTIMBM+XkMtHG5yhprnUASoDO7g5Ty6+WlkNDk7/nW+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 21, 2024 at 10:45:55PM -0800, Christoph Hellwig wrote: > > + int length = BBTOB(bp->b_length); > > + int order; > > + > > + order = ilog2(length); > > + if ((1 << order) < length) > > + order = ilog2(length - 1) + 1; > > + > > + if (order <= PAGE_SHIFT) > > + order = 0; > > + else > > + order -= PAGE_SHIFT; > > Shouldn't this simply use get_order()? Huh. Yes, it should. I went looking for a helper and didn't find one in the mm or folio code. Now you point it out, I find that it is in it's own asm header (include/asm-generic/getorder.h) so it's no wonder I didn't find it. Why is it in include/asm-generic? There's nothing asm related to that function or it's implementation.... -Dave. -- Dave Chinner david@fromorbit.com