From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 413A4C4725D for ; Mon, 22 Jan 2024 07:42:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE6BF6B0074; Mon, 22 Jan 2024 02:42:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B972E6B007D; Mon, 22 Jan 2024 02:42:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A60026B0080; Mon, 22 Jan 2024 02:42:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 96ECD6B0074 for ; Mon, 22 Jan 2024 02:42:19 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 606DD140604 for ; Mon, 22 Jan 2024 07:42:19 +0000 (UTC) X-FDA: 81706153998.19.3E200A2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id 58E6440007 for ; Mon, 22 Jan 2024 07:42:17 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WBu8+uXr; dmarc=none; spf=none (imf01.hostedemail.com: domain of BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705909337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dR6yx6tN67WvcGk22bfKMLtWLGB0Su5dqNJD6Sk4JUQ=; b=4HNrHE4L4VOmEoPyMtXupHxQzu31flZYIBcP3NOkRuZqP4UbyihLAk9wvEpFr0mc7sQcLU 8cK9eaSAAgnIRUnRe4DRPW9dbFAsqi5ox7IvZjBrGcPsuGQ8gE/O56X3c0WoJ75C/g39tp VqJqOl8Ee8Uh00xvs/VpcZ71oNjPtbc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WBu8+uXr; dmarc=none; spf=none (imf01.hostedemail.com: domain of BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705909337; a=rsa-sha256; cv=none; b=GSBYHBv/ptkydRP+OSDsbunRjChTrT18j5lbCzfK3iMYQA7qKIUfUxB/g06n5bQWoNbchP 4svNrZMORQ7go4mG2dw+fte/MYEKZB3shzMpq1ewfDwNsNTW34gsTIhliVo+tonfFcfNgP j2gKFACzhfdsrcXLji0RfDAMPDQNfwg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dR6yx6tN67WvcGk22bfKMLtWLGB0Su5dqNJD6Sk4JUQ=; b=WBu8+uXrPFN46pwRaBFARTzEwz BTwc4Pz8LPt1Fqn8IVxHsE4uzB01j9gUoHrZg1sOYkZYoAVys53D0DpJ8iSKFPpjTP8YS7AAaec0c 3mEQN405x+d3rJ3RuYaVyhVkhmJzmcDbV0S+m25vaJlc4nmjvu5Yw89rNHHf0lTGhOsgKsKVqOWV1 6W7K/KrBBAl+kJK4s9uL5uYbGtywtn8YWThJg3rcDEsPhRKD1LyF46FZTVbDjoezyc0jAsDenhi2K aoMnIZ9xkfG/2SiyVHT5Dkc7DlWhSmUKoGQJhKQhVBEJ3s/J1Cm5aCtRYaT6r+uASa0BJgXOZ72/R CI7KFzJw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rRowZ-00Atfo-0s; Mon, 22 Jan 2024 07:42:07 +0000 Date: Sun, 21 Jan 2024 23:42:07 -0800 From: Christoph Hellwig To: Yosry Ahmed Cc: Christoph Hellwig , Nhat Pham , Miaohe Lin , Sergey Senozhatsky , Huacai Chen , Nicholas Piggin , "Aneesh Kumar K.V" , linux-mm@kvack.org, loongarch@lists.linux.dev, Johannes Weiner , "Naveen N. Rao" , Minchan Kim , Andrew Morton , linuxppc-dev@lists.ozlabs.org, WANG Xuerui , Vitaly Wool , Chris Li Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED Message-ID: References: <20240112193103.3798287-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 58E6440007 X-Stat-Signature: xpfnn7gqrc89qdbpi8j4eaciaqm7zbjw X-Rspam-User: X-HE-Tag: 1705909337-291853 X-HE-Meta: U2FsdGVkX18uW2T5bIDAxAIQqbKPMt0pQ+2+8mAO6TjysUA3eze/prNaz04eLnS4PgAfQGKuED0uEqtDBT47He8XOWQojvUV3fZRsfPIci55BF809y4Zsm5vaEr+P/HE5Wr3TmpLrTVQkR9w+2a86PHKDU48pGvJu0AZLW7ZEhDquvMKeFKcIsuYzorbTT4SYf0IvKVsy1eNKNyO+X2aictMzcaEep1RNYijh+Af2zm0KFI194qyXprhxYPwND+G7hbm/dAHkiz7D/V5atSMX4RKQ5nRr/aVgIYY415kPAZKLDDXlAJmKa9tTFGfxvehMNRWl5uGuuxHt8AisuFFvnqOGZtBLAjXpPXX1dQqXnzNSjWr9ZmfM0YCSgaL3utUC851VMph5wHQqn+cmJvY7yol9cwzMTAY2oBwJPNyW7qDw6ckvVJ3vv0NuW0h7ggQcDZDM5UiSa67U+p2yakFMNmfPyf8OlQ7H347hqQrIzv949MhMUPoGF+OFZTopyWVuId0mIZspnAV1c8ZGo0/F5Xdev1qZJ6KRZQwlv/BLg78iBpIv+qSQgA4LYqBVSr9+K6qDFHlVMACrqXw0gBHli1g/JsoKYmyIe/8BN+UP8H4eLaW5K1+SfFQMhOvq3qh6gW+gXwgVUPCf2/NiVtVWfoBuHLpRLyD4OqTBwZjnXRIssC7t484pLcAdwKR85l1Szj/mtF5S8dZ1pTxAr+DGI5tc/ATW0VrWdbdgDcT55yY+EJf4blsso1aov2XKayiAdHR0X5NwRra3jjYpSqNUl1jKd2nN64jm5jS3roHfdHZgXVZ9lgmyeh0PeCO8lILyfo0lul8VZj7GeObiHiMJRBazZGwKiNWNPu4s61DptZR1mEeuv12ubn2XwOB4P47WNIyS2VDMCTDFUJhzqC7VF4ordLvrNYtzH8TzWCGqNJZoUd4uNDxEa8EXXVXE6wCvORcFJRzVmLbRYbfWVU aChS7aHt KqwCGM9di7I7v/wec7mKCRNFzood8nQwcOM1erGKlmxtr4glHQPYAJl9p0klsUuIvLgPsrjCR4vkmtF8zJmtjxsOl/NlDNxkp0qBaR+Zd2UEefD9VXmK0ZbZh02+56zqGR+y0wQ3N3nxhxp+KLa0fHZ6FgkANgtp1M60DatKS2EwJ+X3ebTTozuLY9d7RYKL3FZhkt9rAkLuN0kRyXkV2GGIiOghrbN1NA01vMKSxYhc1SM2Oj+arlLiH6eS08qmKk3vA7HLDgzpZB539i0/R3MhpmpPD79lo9Ocy3+tQtBitEJYfKJsL+eNC4M3TCRbbY4Fg0yOzBwtPJ0okR1KqUmIXAsX6sqA8tpETvGDcmaVnjzoj46HIITV5Sv/FR/9a44pSGEJp43+cq48ayz7soK68J7DtkXxjEQnjodT7VniZET1o8AdB3tw1Hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote: > Well, better compression ratios for one :) > > I think a long time ago there were complaints that zsmalloc had higher > latency than zbud/z3fold, but since then a lot of things have changed > (including nice compaction optimization from Sergey, and compaction > was one of the main factors AFAICT). Also, recent experiments that > Chris Li conducted showed that (at least in our setup), the > decompression is only a small part of the fault latency with zswap > (i.e. not the main factor) -- so I am not sure if it actually matters > in practice. > > That said, I have not conducted any experiments personally with z3fold > or zbud, which is why I proposed the conservative approach of marking > as deprecated first. However, if others believe this is unnecessary I > am fine with removal as well. Whatever we agree on is fine by me. In general deprecated is for code that has active (intentional) users and/or would break setups. I does sound to me like that is not the case here, but others might understand this better.