From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C3DBC4725D for ; Mon, 22 Jan 2024 06:46:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 004476B0083; Mon, 22 Jan 2024 01:46:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF6166B0085; Mon, 22 Jan 2024 01:45:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE5D06B0087; Mon, 22 Jan 2024 01:45:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CC4A56B0083 for ; Mon, 22 Jan 2024 01:45:59 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 764851C11AF for ; Mon, 22 Jan 2024 06:45:59 +0000 (UTC) X-FDA: 81706012038.30.12F3D43 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id D9AD440007 for ; Mon, 22 Jan 2024 06:45:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ohk6fXLA; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705905957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fC8PY6sF3cW1oDp1cRiGMw1Oz8p1hQgx1DGXN56mE+4=; b=osTudGIJYTPzmqdOyf5FwPZ3brER5sTNYB8YnWsx8fvQWlTccfFcpGFyW2FmpCnLfBdGOa bUROtSmzCvduLrZThLtkmdjRelf3JaJo5okzIxI7jjI2k7kDco7WDcahYb7uzccTdy9QVW tc75RpAkIhhLIrXwUY1R6ZFIHiIw5Ls= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ohk6fXLA; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705905957; a=rsa-sha256; cv=none; b=cGm50v9VZfoEjD81P//lxpB2VUPb4wqNohytGeXFVBNF8qbXnrBNoXtk1KzpTAbF0ZBZY7 yMBloa7zOyODKqqcoNYPMvUy4DAXkuI8bZKBVj99PuXVnNE2mb2PKFTfag/cv5+Fjnnudh Em2MxBLNosgoruorw22ihMk89YVc5pU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fC8PY6sF3cW1oDp1cRiGMw1Oz8p1hQgx1DGXN56mE+4=; b=ohk6fXLAy7dmVf3vrUPNYZcUCA ghX81aX6nYkPZgE8qMiAE8bFVNFoEgoemDZIlWY3ydgjRoy9Jr0KSdyKLbWtPbH8+tZxYB3bZ0W7/ vL3q0Z0fwq7RqEtRG37+pH6YosOL69nfi9OqhTLjAf2zlixpYuJIesQWMPSJLlgDxi23LgQXRozyC n0zBUJ6n9fwqFWSVuXFNFckFlp/XUPTQ7SVjVEBL0YU5CsCafpBnFARfeZOcsApYS+vcItH5c1f/a wCmVfFHKz6+wmKxhFNTB71iKwVM/jXSqy0hHJEAsAYg4H7dNugKRVG90TOuJ5erFn4Nvz5KMkACpp YTBS8hUA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rRo4B-00AmNS-1f; Mon, 22 Jan 2024 06:45:55 +0000 Date: Sun, 21 Jan 2024 22:45:55 -0800 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] xfs: convert buffer cache to use high order folios Message-ID: References: <20240118222216.4131379-1-david@fromorbit.com> <20240118222216.4131379-4-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118222216.4131379-4-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D9AD440007 X-Stat-Signature: dwjw5knfcfnsmbde8sibhbfkxrcwzuxc X-HE-Tag: 1705905957-33764 X-HE-Meta: U2FsdGVkX1+ZHmIYHjj7yHpZFLOLvPh50JBKSDaUmXyrOofGm3kfbr3Pta3KYwGKGE1R0mIS9sOnTEADAREPyQylnwjUQfPdS2/uvVDa23pDcWFxb29ZW/h0xBoO2UDbxGQEDiUMwL2F3uicwydnhYr/5Zs2MCeGbJK4kyf5F5GPuWSoG9pOkuNUfU8y3cGPslWWSuMkKmBZ+E/C1yKCbbrSqK2skRtinq1BSklTs6Xl42Mir67KX9SvVngfMz651cinLb7ebj+E/PbCE6N0Nt4/CLz5wtI7o7GBlve6joSy3BO9k91Pol8lW+ShAfi4NWXhWGe1WqIvGpeirRAdIrgzPDMtK/OFfolx2jKnImSyLq+8qBx9XLZgvmdKbhptIolPjjvP1IAq4zXM0N0lWeE70wO6nqvmSIbUU5/Tw9fox+TavSgVDEctiDEaMXLNfKQ1PAC+tMUpGNbz9Qi9igeiZsCpYEdjMrY9BfeIlG8OYkAZBzyygh7jOgArgyDN096p4y2MRmGZFUcuNpA2O6YJSbuUc2ZcdhUTaN012BepOub9P0zhGnxBqtB+AWRNXaCKGTbkSJV0lBWUUgjmB1OPVn5mbrlWYEzYoRmaw1EwjGcoQ1f6Uf4IGiUR9Jlzp7b5JaafnqrPWHu4+JOJybty7WiClGtM2iTOkqlLDzVoFz8ruC83tGFu3s7m9zBiAss8G6rulWLffhbFjzmN7PvAe+AOZuCA2JcS60hmQh0B96QvjA2vPoexkBZYV5IvdIcwsc3ZO+5gAVqAg9iDYiI8uvsllRABgEIjI7661I+4eMl7uD8bPDKVOq8nv3nvtoffjz8SLoLWaLUkky+0wVrgP+zK9e/+MLlgvZpCbG9VGvPtdaVC75scJOh9NWP1SplCKME1VteDNXBP+duqeAD7N2DC9VLmeo69i8S5phzrYClvEinV48yIulUbqnmREc3iZ8LSOwpj4UpkX1v 4vi6GA8B wn+XTZglqF/3fTeEIwZFJGDfWwZUXovq2g87sSTIVyrCr66eR29hSqHaZgjRdoh2lrTdk7rX8ZPRh9GRhDVl+SWs2EqZ3rWWfXs1wY7jLl5LSyDdfemOA/ygkUtMLFwYFNpucQPDPvFPcKriiS8O/is9XEtjosHazWFr1yef09DwsHZJt+4YUsjLpFw+g3EqqKSafS/jUZn4oSIAdrj1o0+4Sw0H1jjUXuTo13jOhIhP87Y2OAFHEamLk/bUEQSEF8oqy78KYM0cfwHQVdZfFzpwryfj+/Ghz477e0Ktr/KN5RZz8kqhhixNQQApKYSbYok3TVQs4i56EoyVX8eTgoVrv9GN3SVbkC60/BcIKXk/3X7V5JuBF9sFH1PnAzReyUCq1WBn9Zlb+nvA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > + int length = BBTOB(bp->b_length); > + int order; > + > + order = ilog2(length); > + if ((1 << order) < length) > + order = ilog2(length - 1) + 1; > + > + if (order <= PAGE_SHIFT) > + order = 0; > + else > + order -= PAGE_SHIFT; Shouldn't this simply use get_order()?