From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60F49C47258 for ; Tue, 23 Jan 2024 11:24:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E558A6B0071; Tue, 23 Jan 2024 06:24:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB7B26B0072; Tue, 23 Jan 2024 06:24:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C59A06B0081; Tue, 23 Jan 2024 06:24:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B22A06B0071 for ; Tue, 23 Jan 2024 06:24:27 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 88BC9A1F76 for ; Tue, 23 Jan 2024 11:24:27 +0000 (UTC) X-FDA: 81710342574.22.4A513EC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 406FD140011 for ; Tue, 23 Jan 2024 11:24:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=uJS7tBRE; dkim=pass header.d=suse.com header.s=susede1 header.b=uJS7tBRE; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706009065; a=rsa-sha256; cv=none; b=f7an51vGOESVKcHw3lwPkhX7Uv+HlT3qWrW9orky5AkvaJarCqHbpdwplCX2vKO/HzwMbc oKZrGbfnO8xHT+Wjktnv75R+RzhK8ADXfzuXWbksBJQJM7Hs/LRVtovpvebhrjSA9ZMmsU yVQcmMxLgqjR1s8SgLVCb/Q/AJKa9gA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=uJS7tBRE; dkim=pass header.d=suse.com header.s=susede1 header.b=uJS7tBRE; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706009065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EJVi99//neE1A58SAwm+ZzkimX+ETFoczgCsxNWrcA4=; b=7iZG4lohtVXhxPjwjhaccwcVbUZorh55a/p+USxJ6ZhWn55mBhJuTzff2NUx+mmOYhK+m2 co9jwKy1coD9gAQcKSlHRZUTaXwu9MTXGDA7VLYAUEX2YodMVJCLYCQD736moytNKKdF3r IPkCLdbDe7JBT1bCesekjMY3aHLr8KY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6D00F220E8; Tue, 23 Jan 2024 11:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706009063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EJVi99//neE1A58SAwm+ZzkimX+ETFoczgCsxNWrcA4=; b=uJS7tBREA3lOTaaMI672V0I10P/arXodIL7GKOlYHg2iYYi/wYWT+Me/mX43BVnl0er4qR k56V1CwSQn7N+qCnoEggom7JjGE1jCeN3vFf2UTMhBHQCpirQzUZ63UMs8tNjjt9Bn6tZq 5OAnyHOUwT+SE2VjpvITD4r30XrQqnk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706009063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EJVi99//neE1A58SAwm+ZzkimX+ETFoczgCsxNWrcA4=; b=uJS7tBREA3lOTaaMI672V0I10P/arXodIL7GKOlYHg2iYYi/wYWT+Me/mX43BVnl0er4qR k56V1CwSQn7N+qCnoEggom7JjGE1jCeN3vFf2UTMhBHQCpirQzUZ63UMs8tNjjt9Bn6tZq 5OAnyHOUwT+SE2VjpvITD4r30XrQqnk= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 44FE4136A4; Tue, 23 Jan 2024 11:24:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OI/eDeehr2UQKwAAD6G6ig (envelope-from ); Tue, 23 Jan 2024 11:24:23 +0000 Date: Tue, 23 Jan 2024 12:24:22 +0100 From: Michal Hocko To: Joakim Tjernlund Cc: "david@redhat.com" , "quic_pkondeti@quicinc.com" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "mgorman@techsingularity.net" , "linux-kernel@vger.kernel.org" , "gregkh@linuxfoundation.org" , "vbabka@suse.cz" , "quic_charante@quicinc.com" , "stable@vger.kernel.org" , "quic_cgoldswo@quicinc.com" Subject: Re: [RESEND PATCH V2] mm: page_alloc: unreserve highatomic page blocks before oom Message-ID: References: <1700823445-27531-1-git-send-email-quic_charante@quicinc.com> <3fe3b3edd33cd784071dd9b459d20a79605ec918.camel@infinera.com> <2024012205-undrilled-those-2435@gregkh> <2024012210-outshoot-dragonish-fe8e@gregkh> <01010dd280badd149291cf4d2a4a88847113cf6d.camel@infinera.com> <98318c510e39cf83beaa07a4dbf33f18209eb358.camel@infinera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98318c510e39cf83beaa07a4dbf33f18209eb358.camel@infinera.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 406FD140011 X-Stat-Signature: er77w4rbme3sxf9uuqdysihkher5a6ye X-Rspam-User: X-HE-Tag: 1706009064-624257 X-HE-Meta: U2FsdGVkX18Q2gyOdJJPDAdX7yMZ94dKQI6rYOwGiKxs0IrDio7kfN6cd7VkFB4mzS+T3zYPPAm9mSDU/FJKB62s6e94ttU1RATmpHppz9oPE/nhUVJl9IfdL+c77nAbjvggEvNn64XDSeB2+SslWvuBPRQF9pKrl+l9MlHqTAlVmFNYgRp3m9P4Ey46Dkpo5oZ51JHTcy41W48NM5I5Chrr/+8u87fBlhmILSegBTxXi9vJxUj8XsJJbNOqy7lMa7IgblHfMjHCllFZzOFlIW3wPxVwU3XnQXWmSNwzHo/y15veGuPHeOqFLubcCQ1YaNuV/mRdp5K4en6q4ZLpNWsCo/l4w1od56nm7oY8bxfjjw5uwabtB/lGGDlbAya2SYCyd14axZVG9IPe2ylepSDbA+UJuArtYrKjrx0QffDe7gU/oUpscorc0ljDw46s9uBLtjCkWar/2jxwCB+TnCwJ0gLcaR+WVLGOPJWbjdNvcUD18ES7sHROsdgmhR2wkf89BZ2izXwKqsuyXdQfrvx63VV0i54Xfzqy7Z0R6uIQ5wJczdETyX9NR+NwqBSDj3tO2n4gksQJJzTOZcEZpVqiv18RpdlPHR5ov9gu0KA39Q4IjYRs2dmZx6bKDvMIhrIQ7Xw2+/DpIt69oDrfkI0EtHCQ+00qR7ozPIX3W9fupzvZp73ueqeEmn+LAmE1aq/6cJT4p6HiPVySv0HaQWMnAAktRgwZf8ZAvTeCmgKVCi0jOEiV7b5Ni2tDdvZCg/Zjxz++Tgfpb7KG3KMGaQxZb68sUDle+iOCyxbtqHWZbotSmUjmenjSfnO9G8Gqw2uqeZyfXIDj/fyrJhuVrwfhk+SoLMuxkfC9dVHnYuqNkSHOM1LPUKjXAp62Vha5xQ/wDBGuh5ZcxEl4lQS+B/hR/a/XC29a5xxHIGh0EwaWOpXMl7Ap5bVOp9X9D64Saga0pix9CJd8juETy8u EJ0FJr+F G3v5DSNi54TgMFQ5vxpuiBI9LA9hkIPjO3Ppph7AH+e4cVUUds+HqNsJujHcSfr/nrAaSgxy2KtFb2yFvCKsToPYO8RonRDZb8Y/nrfy6+tYz64nhECzjojWg+4JuZ0X/B6B6kGew+tEriOY+iqB1VxQLrFDzf4oBCXasClacxDqvClnoUajF0IV0RLmWxO85oaxm4q//91qhRkYLpMirzZcjuecIRSOWL60+uj9RXoGqqU/4EBTX9XlrVNDlJCTUsa4lHUnMBcDlmFS9DFNZyRpT2PuqCiS/i/7tMHw0TSbM11jR5NelpRN3FG8E3mLRaMAOBCaYmH6B4m8SN655Z7R5sg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 23-01-24 11:08:28, Joakim Tjernlund wrote: [...] > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.001379] Mem-Info: > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.003665] active_anon:18 inactive_anon:2435 isolated_anon:0 > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.003665] active_file:1 inactive_file:0 isolated_file:0 > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.003665] unevictable:267 dirty:0 writeback:0 > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.003665] slab_reclaimable:384 slab_unreclaimable:2223 > Mar 9 12:52:40 xr kern.warn kernel: [ 1066.003665] mapped:1 shmem:0 pagetables:309 bounce:0 > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.003665] kernel_misc_reclaimable:0 > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.003665] free:1054 free_pcp:24 free_cma:0 > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.037938] Node 0 active_anon:72kB inactive_anon:9740kB active_file:4kB inactive_file:0kB unevictable:1068kB isolated(anon):0kB isolated(file):0kB mapped:4kB dirty:0kB writeback:0kB shmem:0kB writeback_tmp:0kB kernel_stack:9 > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.061723] Normal free:4216kB min:128kB low:160kB high:192kB reserved_highatomic:4096KB active_anon:72kB inactive_anon:9740kB active_file:4kB inactive_file:0kB unevictable:1068kB writepending:0kB present:36864kB managed:2944 > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.087595] lowmem_reserve[]: 0 0 > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.090918] Normal: 206*4kB (MEH) 198*8kB (UMEH) 79*16kB (UMEH) 13*32kB (H) 2*64kB (H) 0*128kB 0*256kB 0*512kB 0*1024kB 0*2048kB 0*4096kB = 4216kB > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.104104] 269 total pagecache pages > Mar 9 12:52:41 xr kern.warn kernel: [ 1066.107768] 9216 pages RAM OK, so this is really a tiny system (36MB) and having 4MB in highatomic reserves is clearly too much. So this matches the patch you are referencing and it migh help you indeed. Thanks! -- Michal Hocko SUSE Labs