From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA7A2C3601E for ; Sun, 13 Apr 2025 21:34:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6800C6B030D; Sun, 13 Apr 2025 17:34:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62F3C6B030E; Sun, 13 Apr 2025 17:34:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CF686B030F; Sun, 13 Apr 2025 17:34:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2F41C6B030D for ; Sun, 13 Apr 2025 17:34:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 26E02160CEA for ; Sun, 13 Apr 2025 21:34:42 +0000 (UTC) X-FDA: 83330325204.01.BDE3913 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id E0CDF40006 for ; Sun, 13 Apr 2025 21:34:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tz+4SBcu; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744580080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NprLifJ2si08c/zt+3ORc7MOgkSki3DeRgZA8ugV5VM=; b=76c1Iho5g4N9hYWtNX/7ZYlpACkED+NMfQN9ZkhH/cL5xoU61m1NQLLjqmoSw4trjCPAAA jwgDsI8caApFb6BxSIJdf/YLuTZRgsmKohsKB+sGtlmv/6i+05ApXTETjHroL0pyUzxGiL Uc1IlAg73wzt8Dzz4z+gQZV+dU4VYjw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744580080; a=rsa-sha256; cv=none; b=rPfJ8FDlKqzZyFBjmYbpVlKvRM8lnEFuOXKxvSy8iiOLhvSCSGJ3N7YE7o1d0EVk9Ud4SF bpi7f9cTOjXAdPNrZ+x6TUD0Lhs/dMd6yQ3xB2NJRdiOlRhlG2ekpTYCC1TiyEhFlgze9b vO6nG9BX8kp2Ec/GTOoWPdW4UV1H0gE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tz+4SBcu; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NprLifJ2si08c/zt+3ORc7MOgkSki3DeRgZA8ugV5VM=; b=tz+4SBcucm3JcU7e28ZPcDRI7a B5GiHsNzSWbbKpEAelQjrN9/zMwGj2U/xAsVsTS/bsdqXXgntzvwEYUC0XoIO7OiSC2KlgIrJQb+f BFbVfS21m1LBozLMuxbej2YHXwuobTvwQAvAka81sxi0Fps8wBeLJPKVxHaD/FTGtZ7KV7dzl0kKp TZIH19OP0NY0aZCvY4qqJdl2435C97w1ZcCjtl/vK12egWLUCnuRV56G2QlGcA6/gGn3KFtGMdjLa HGCFRfoliXO8kFsxaVseSeJvMpRx9Qo80uiY0RPqwluVVMjzDpu+NhtCEMZy/UYZkQBT1b6MhkGJD KGSMVt1g==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u44yG-00000007IMO-3RB2; Sun, 13 Apr 2025 21:34:32 +0000 Date: Sun, 13 Apr 2025 22:34:32 +0100 From: Matthew Wilcox To: nifan.cxl@gmail.com Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, will@kernel.org, aneesh.kumar@kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, linux-s390@vger.kernel.org, ziy@nvidia.com, Fan Ni , "Vishal Moola (Oracle)" Subject: Re: [PATCH v2] mm: Introduce free_folio_and_swap_cache() to replace free_page_and_swap_cache() Message-ID: References: <20250413042316.533763-1-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250413042316.533763-1-nifan.cxl@gmail.com> X-Stat-Signature: ikdf6n78yydshxeuhnkry3xzs4zjgxe3 X-Rspam-User: X-Rspamd-Queue-Id: E0CDF40006 X-Rspamd-Server: rspam08 X-HE-Tag: 1744580079-477272 X-HE-Meta: U2FsdGVkX19j/qnopjYXqIX0Bw7+N17Hrr7b15grURZQjTV8d+kjR3AuWi2p926ZZmed/Xz4jG5gvZrRNZ81iWYfCCql9k1Jo5YZU3DEA6FpBDQ4y3hVPWzM3xtQG/AY1DTWCwuBej3rQvDEJs3bdxc9pQzyEPh7qr8G7H+A/pb/nFrGc6GdBccXz1Iu3mZ15pNXOszoMTTC3+srroWTRHSlSD4NnOdhbyykOjkeLQbi1712SIuRYuQAcndWI6qfKqMgtbKLnzTx7R/qHm6s2sknqlyIqfArFGGgHuI0fMQi9C9nb7hFSvrfIaKA9Kb++hWw0DsGE+NMhQICj0GQtTyRkQUqTtWueiK3gQKyY704GpINgaU/vE5yzUMlGVPVsq/3K742LBASsySMXt970upmnjpjy0hR+kkuEbHrRMzPa8rsaKg8or44FXVGsu8guoKpK8ZtbWuwjn697DN+UUVIMNr667t20baXe6yNkKwN43E44tJHks2Yl15CLJPEwLMd2ROrQQHaBbybbQ+EsN0sBEyVGQoTJU3k5vj9R2jZ/CtCFtvq1R1wtxSIaBR4uxV39dGZ/tuhK8TpFwYjIhrvk48UURF4rR2d3h7GF1ZctS9DwXXxOoJ50QhbmPrtxSKR66ThdFjZKua6xAtUSJF2IEXoRoP1+XEF7mJT38w1YqCioGvZBuH0BJmXAl3T9ATrASGMtkHarAEkxgtwrWZ8PmLjhc7M54xS/pQO9p+NUmbrqBSAumCJqd2i/6Xj7psYieJO1vDVK481KxLqv/3DDPamPq5Ruyel6HAkZMs+x6wpdywXzBQ0k79X9xOsref2tGS9pjef/CV/UcbrHNcS+RVz6/pc589r71fpp9tuS7mL7vbWBTCdmNzHc7guXljDgoKS0qJt/snkLRmPgMEAEFVK7UwORPZB8Fvp5+lbpsEnyj6NuTGuEYca4KSHyP6XGCT3BD3+t+QxqWA Xyci9j2C iPNLwPD0q3OtEENatWKqrnlN7gpFXtuzpIRcYsLGnTiOt6y3s8ZPwjCwDE4atVEYR4KCh2ajKp8Un4Lm5UJSrOUcilOzIt3LKNYot7OtnLam1q7n6WySU2er1VuixqQ/dwb+A+B7xxheVKXDIv6tnvvMIbJbIOfRobgBDez66HYIYUWVBs2Zsvj5cN4RCNa6Knb0LmWLRTxWIfGPrXWdIXBzlDL+j1xzs9phzL1jnXOYnPw9yjC3sGJFORS+wyV5cKKS8A3aRDbf6LRfKlyxqma7HLtm0opARxmmUpWywJussvE+L3KwFwWFjxT/95QNlbADDRUa1tm4WJDPXdtWKgdHC2vy0NcjUtySSLsrJltjMXpCWh2IaC5ZPrB3Ulkc/Jh7eN1hzNQJ+DMJZDjcVnQbnUU1J4U0x3GkU9HLDJugaYE4ZKjuhRS2yA5rSn3pObjwfTNYzT5hz4vdhCuOHURaYhh8+sh20o+OiAg/St6Nst2EEHp/8MxOiaQ1Hmub+lvqjpZtYX2/pwBmd2371wYnRoQmX3VFsue8s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 12, 2025 at 09:22:21PM -0700, nifan.cxl@gmail.com wrote: > From: Fan Ni > > The function free_page_and_swap_cache() takes a struct page pointer as > input parameter, but it will immediately convert it to folio and all > operations following within use folio instead of page. It makes more > sense to pass in folio directly. > > Introduce free_folio_and_swap_cache(), which takes folio as input to > replace free_page_and_swap_cache(). And apply it to all occurrences > where free_page_and_swap_cache() was used. > > Signed-off-by: Fan Ni > Reviewed-by: Zi Yan > Acked-by: Davidlohr Bueso > Reviewed-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle) > @@ -522,8 +522,8 @@ static inline void put_swap_device(struct swap_info_struct *si) > do { (val)->freeswap = (val)->totalswap = 0; } while (0) > /* only sparc can not include linux/pagemap.h in this file > * so leave put_page and release_pages undeclared... */ > -#define free_page_and_swap_cache(page) \ > - put_page(page) > +#define free_folio_and_swap_cache(folio) \ > + folio_put(folio) Since you're respinning this patch anyway, you can delete the comment about sparc. This file has included pagemap.h since 4ee60ec156d9 in 2021.