From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71FD4C369AE for ; Sat, 12 Apr 2025 14:35:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA38B680042; Sat, 12 Apr 2025 10:35:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2AF8680041; Sat, 12 Apr 2025 10:35:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA42B680042; Sat, 12 Apr 2025 10:35:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8942F680041 for ; Sat, 12 Apr 2025 10:35:53 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 992B9140BE1 for ; Sat, 12 Apr 2025 14:35:54 +0000 (UTC) X-FDA: 83325641028.19.AC012C5 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf23.hostedemail.com (Postfix) with ESMTP id 83F82140008 for ; Sat, 12 Apr 2025 14:35:52 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=msIIvf7W; dmarc=none; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.46 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744468552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dKA6CW8lkxsZYkZcNj1adEARS2rUQdUi3RNcgzxuj0E=; b=DO2TfMKBdGuay+GLHe65G+3rmaPuMZmaq81Akxxl3bZNgr0K5pSE4/WN+d98tfL9Gtuzhh vwOeHDHE8+QZnbjvtJyz8wnQpks++KQDNJxrO9hgdWv0dZf8mRdYCHOcaFkSwAy4BCnbRX 34zcjjICPAwK2sFJcza1hJrcMvW4dy0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=msIIvf7W; dmarc=none; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.46 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744468552; a=rsa-sha256; cv=none; b=H03UI4/Q3ycXrKSeX9dmF8G+2m0D6eIHNaHivmcMGIb4NR/see6H6gIA1Td+aYO5FUiaQ4 H5sDT8kGCX6rXVJxtVQV8Gif7IVqAJkA3rfv/h/m7B3y2eGt8tdqsNR+0u0ToSIFiTeJ70 yRdyweoedYhSI0jLLRVy9yAyPZ178/s= Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6ecf0e07954so40938696d6.1 for ; Sat, 12 Apr 2025 07:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1744468551; x=1745073351; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dKA6CW8lkxsZYkZcNj1adEARS2rUQdUi3RNcgzxuj0E=; b=msIIvf7WkvFu6hux7zF0l6f4f/pvZJbjpPOPsmsdCESRORxQjKjctVv6o1UOdaGqRR a4bcjM7rB8j8L9VUFpsDOMHJU3cE1oj3bxe2BusrgnzBCTUIas+Kr/L4UUfz5UGjSK/A gvN+iI7mkLYhyyuEZFgpVD/vaeNpSZmI4vY1YLy+MimVO15qv29WxSGs6p/7Du4Dn39+ lCJAqf9CCHaELP60UGAo+1jinFQ+PGOg8bMfKq0BVw8ErrArp0Y6ad7dyZPRNiyBuWAC oi0zzv2a+z/BW/ae3xFm/4YX3QjFVi9mzPq4PGSs7tbayoou/AQ58UnwbxTqjZHTx2XX sR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744468551; x=1745073351; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dKA6CW8lkxsZYkZcNj1adEARS2rUQdUi3RNcgzxuj0E=; b=kgFaGSA7yVblybwjjVnaAzDX3elZOuU/1RQQeM/gEJG68/EXqTobh5jdOY4+BZEfQr /gsPe8Df0JbDGZwjZcj4V96KNzBNLEHVQP+USTd60WUNYZ21YC6ytvuZGXHWa+yZJ4Vw uH3MmEs+utIoem2Te4ViUEDJrmcFrCrbtMl2ALM2sGtQ/s74zpFadf7oBWaRzNhJ4G4+ zaI/XvLrDfGOfcvWHFz+yspl2reMsM9yoPY+mgPdIbUqiwkLR2BheaeUqsZuhN9on9X5 5NaeHw/x6PhokH3KnatrH1xicDn5N7iV6vsLfRcRbEy7TOcy6uQHhV879Ho2oTolXMpM Ny1Q== X-Forwarded-Encrypted: i=1; AJvYcCWjLDXxIGNgQ7xOtPeucrq1pukz416CT9msn/UToPyTDYjMRCW22tsZMMA0i/tb3lXIdFW4s3wZPA==@kvack.org X-Gm-Message-State: AOJu0YyEFf4aC48XC+BwZkEzfBc5j3mhT0mRdejQPSFvEvNUX/6GoQju AA1yNqjOaxkFyB54Yp+mqGq2FbiB6mXUR1JsM5reweNnoTp83h50rOWhyGCGcz8= X-Gm-Gg: ASbGncs3a/0PEEbaSpYTgcjnt5JUHwwtMV8NzI7ZPQhTbi4B+spn0z+ZdbImmb1nshz eS15GkDGrv+a3NK9t+TVNVDr2YbGrf1EABqWtv9axIynkZyV+4b0xpph1LgC+HhxM89hDo6eQWa nBNEJ/sX1USfuq4KPqyTzX24+sNVlhoi2XOU/Hk1NHSB2xexPrDQH+lheGHVknN6d85s2Vgkb6b EszVTom1GwK0NFkk/Rhe06XRzYfoaPjcOUlkFG7mz40VSvL1Rmhwr4zmlbKSX/cyUbMnE4oF4LX y6cyo8do6QSJGQZ/zTFdkoISE6NDiOYZGzd4DyW42aC5mnGkCKHzjo9uWcX8z7xeW/fC238olZp UPLOBQ/4d7xqqKbZN1DlKal4= X-Google-Smtp-Source: AGHT+IGqSSEfyQRXlH6VjXNUEfEkbf0/sQSfoUZEWOGabEh6iMrD2lgAmfhikxDIs2A67ZjcfmNMdg== X-Received: by 2002:ad4:4eaa:0:b0:6e0:f451:2e22 with SMTP id 6a1803df08f44-6f23f15d640mr105210826d6.38.1744468551139; Sat, 12 Apr 2025 07:35:51 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f0dea215adsm50726506d6.120.2025.04.12.07.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 07:35:50 -0700 (PDT) Date: Sat, 12 Apr 2025 10:35:48 -0400 From: Gregory Price To: Ritesh Harjani Cc: Matthew Wilcox , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, donettom@linux.ibm.com, Huang Ying , Keith Busch , Feng Tang , Neha Gholkar Subject: Re: [RFC PATCH v4 0/6] Promotion of Unmapped Page Cache Folios. Message-ID: References: <20250411221111.493193-1-gourry@gourry.net> <87jz7p1ts7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87jz7p1ts7.fsf@gmail.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 83F82140008 X-Stat-Signature: 4fpye88ioh5bmf55zynesgr7ydmjgwjg X-Rspam-User: X-HE-Tag: 1744468552-159487 X-HE-Meta: U2FsdGVkX18/QnLYjQtgyVUhPprWoWHsNSQWB+P1bhWkwNSOLBvNZxangGWIPCn3vC62m3K8C7qiHEtNsn8jpUdV3ppm1Weip3D1WMdpaTRPBavyeuDWwsRtRrdfhVUWdL8XdNIqOAmhenF+MYFlpdG0vLhgricAAmta/aProucE22JMF0vj40KsuYDXBCdYl6791zCqJ+p22Lxpp6WHYMdgti2S5vG8Rm0JCMAU5zojIhh03qt5cZdMkkezoru3rCN2mr6OWhhKG2FLsIPjjpgQIlDPOXF9sc8SCjsoGp3hSHqR7AcjnASxdk+TG5WIUI9q3dDijxeXm/hsxgAVQvEYQ8TsYuTcTE/AjnwsIOLRnWRaeNhXymWNhg2Gv508r3sx1/Nuq8rU2R3jOGrk9aWy4rLMQ14J2Ehbi12kqGQFGvWfXU/lFFcSDkvGpic1tr2tUXKlEuuPJG/k9O78X6AG2lMniUobSDGjH3KfNhSr5rdtneVZTh1vEpFXs/yQ7xsFecpkT019o60fdWO0vUp4xH+Jick1huLZ71czbubCQ8vPdzqbym5F13sl6Oy1+dE2l6VU2qLvqIki7bP5rP6uZTRGcYI2uwuO1HuEOkJ+zGujK9Czbd6s/AccnyO/lOqGgmGFc5r4jlCHL3niF/0PNvTMGtkVeXmeqdswMnePgx8V5NIUPO+RRnG69d4Lu4MiHNVI6zhEqxXA7cIk2xOANhWEfcwR9tMTlNTFwRGThZpO94jaAIzmH8Oufn1LRW8ziSE0e1anY0lBHDCPGsNRCUGXZmRN+baGl3seQuYOEXOXKw0QhuYfp3mVLRY7r1DIpqdFoVG/7zgek/QTim7Bofa/j35FQs0hBF6BSzRe66zed8D0KvzUZxXBR4qBPHxtPOjD5TKmsRHqN8jUjrRutKYXjNsx8agU9H/Zu2wtzryJ2rWk/kAqjRDdXm9CAfcs7+R+WE36MF2lMHo N3EbQLeG U88XRJgzHQbzXOT+HrqNfQZZ+eqn/OGiXSn2kybCn8S7Iqz2FRxX3qRiIX8Pzs+vc0iv/YNpfZ+HaCzF6NKf3w/UiWhpsWEjvjj74/wm8SVEX/Sq65loMweplR+tvbiDOOjieeOiScfMc4IRxhyQ8PE5wMdG8EoDUbmWal181VIKQ+aqUE+FgoZGFRbocRknvB+fTtOPlRd178QBd1qd1iaU/rwDUj+J60OPjwFaXQUGAiZGhxAgztiZHj+UyrF7yev2gxoOX2VmGTML5w1RBVX9lOITq+sK2MMHI6z6FdWax4ycxnlG5mbUfF9+C5ly6uBLRNkeL6fXk1RRHblThB1ttoxmv6qjQkO+YZLc4pUSLtiBKSgO2YOS5S8Yx6YJy1UNRD+bo2QIRs42P5H45OGIuDhRq2sryUZY1WNuVQics+/J0aPqo1YgbQUAcuZDERjldtGI9NZRW90c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000028, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 12, 2025 at 05:22:24PM +0530, Ritesh Harjani wrote: > Gregory Price writes: > 0: Demotion disabled > 1: Demotion enabled for both anon and file pages > Till here the support is already present. > > 2: Demotion enabled only for anon pages > 3: Demotion enabled only for file pages > > Should this be further classified for dirty v/s clean page cache > pages too? > There are some limitations around migrating dirty pages IIRC, but right now the vmscan code indescriminately adds any and all folios to the demotion list if it gets to that chunk of the code. > > Assuming we can recognize anon from just struct folio > > I am not 100% sure of this, so others should correct. Should this > simply be, folio_is_file_lru() to differentiate page cache pages? > > Although this still might give us anon pages which have the > PG_swapbacked dropped as a result of MADV_FREE. Note sure if that need > any special care though? > I made the comment without looking but yeah, PageAnon/folio_test_anon exist, so this exists in some form somewhere. Basically there's some space to do something a little less indescriminate here. ~Gregory