From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94FFEC369A2 for ; Fri, 11 Apr 2025 19:15:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA5CD680023; Fri, 11 Apr 2025 15:15:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2F8768001E; Fri, 11 Apr 2025 15:15:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CEDF680023; Fri, 11 Apr 2025 15:15:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6AE6168001E for ; Fri, 11 Apr 2025 15:15:22 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9E6B1120775 for ; Fri, 11 Apr 2025 19:15:22 +0000 (UTC) X-FDA: 83322716484.07.446BA2B Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf15.hostedemail.com (Postfix) with ESMTP id C8476A0013 for ; Fri, 11 Apr 2025 19:15:20 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nl4YerJK; spf=pass (imf15.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744398920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z3M2ksm7ZNotH00YuRSfmtJ3TDHSlVqunlfQget/e54=; b=mntopU4pe8xe36zYTJKOHWCjy27GfvVb8x/lnDd/tpAB20oNyQ6WZB+BL/8sMJMh89P66e /Q1FjtoXQfnhiq/LmTj6KWH/vcKCckT3Xj57Jx84eps4W65HVruiG17jyrW9JOWf5nsmZk KuWTsN8PXphGuybh0iGJCksXq0QqaWc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nl4YerJK; spf=pass (imf15.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744398920; a=rsa-sha256; cv=none; b=gYwqbPDld0WNIMgbW3XTxLA7TRCdgBbvr0lLxwZb5N43xX/Vd9B6mS7yehjw+tiakyVP8C ho5ENn9c8hsWkmtkjq9UUZAu57ULW/ZIRIgFgekErv9IDKyc9tDlTJtOvWyBltK/oSDhGv jXoHDrRnfCmyltBYc7gDUn8x5eE4vWQ= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-6ef9b8b4f13so21837647b3.2 for ; Fri, 11 Apr 2025 12:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744398920; x=1745003720; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z3M2ksm7ZNotH00YuRSfmtJ3TDHSlVqunlfQget/e54=; b=Nl4YerJK4iDAnN0qy/dzeQlVsPIE3D7BAA/uBTa+qRHH4KA4hr69AfH+Ra94+ZNOid bGesD207QasdqaOdNo8hd/zcmLRs9QJIFK5S01vO1iU+O60HIB4KIpZ0c/3Bzvic6pNk QEX3vmXN1dwFtA2XGJ4fLMuHOFgE3AYJhPxV0ur76IZarPOnDp7nJKYWQEUVBun1FUaD eg+VmG5TVc+O1ppbjrezTTeNPgG35SXgcwNr0cgfub1eOSywSU8q4JNfqGlMF595y1B7 gyMsqMfm7u2B5LXuYaKT/Ibj8zmBdfISe15tp0jnUl98ZNpz0S9389M/z+xulBJaSROP 0XYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744398920; x=1745003720; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z3M2ksm7ZNotH00YuRSfmtJ3TDHSlVqunlfQget/e54=; b=TToyL1ibGBDuF6YulIIcZWHYWiLjgTp4lhCeLPLNGAAm06kyaDrJUVQJd1rYiCxE++ SICAaaWUBcUfQ8FMibokMrJ9/nwU2Grxgo6BVihECGnZ068aVemnU8WJnRONtTHHFaSX hOaPyL7Pflrlk8Pm5yuZ20D+6QM0ZYE2+5rZGVz0hEy0hGT7voD8nnoyhaJGfuNfbTMu QbGx6r6ZsnO3JlI5WGS8L27gKx/8c4x04YYT/JLySXsKu0EvTgqlebCCaRk6mduSehd1 fLonwN6118GYXxNkxAlbtofR+i42Mlz1exm/qC1/yc7hJXRWPbpvVBRv3/dgdM560GAd baow== X-Forwarded-Encrypted: i=1; AJvYcCUwFITjHZB3eU8QlTYfkAO8WwYas/b47S1lgCBwVY0tG9nqNLczd8faeYowfhIuzGirZoXIBHq4cg==@kvack.org X-Gm-Message-State: AOJu0YzKywjAnXVcIyTfV15jfZlQeToTScFyv2U3HSnIF0e29AIQlxoW jFJ3rg0xt9hg9gCpefh+N3nNoQScQjfeWodfN1FD5H9mEP2dYiRD X-Gm-Gg: ASbGncvZiH3+g4mFsNYYYpSi+/QFOE25+IZRisQN6u++FYSbH2fOnhi2EDL1sNzd0DJ n/k5NO6NVf8kDGddIxjK3APX/HPOw5Vucg9hp0v3Hddb0q/E55dVmnS16ol7HTRDKFkF2f0vtjY UzeRLohgKcmNZyOJJ9klNajzjq1pVxxSkWo9rh6+7L7//s1CBH0acHHZYJCEWVOvxM2J0b/uq6n jDE1eUxCcwS4y5c2Diyag5ZtKCMxYDqdmDJUmXJYxNh91JVjrvJdtcmmkpEO03htl8bROW9dell v/WSUllR0MNS7ABo2L6iVgM6eaWobssuLgNs0A== X-Google-Smtp-Source: AGHT+IHZtYGR4wzPKIni8qIrVhsiAmx3LfOm7Ku3doCQQI0y4sBD8aJvfTBj6p1X2cajBUvi4gj3pw== X-Received: by 2002:a05:690c:6d88:b0:6f9:7b99:8a29 with SMTP id 00721157ae682-70559a8ed8dmr63113557b3.34.1744398919754; Fri, 11 Apr 2025 12:15:19 -0700 (PDT) Received: from fedora.attlocal.net ([2600:1700:89c0:5780::42]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7053e372b6dsm15913617b3.88.2025.04.11.12.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 12:15:19 -0700 (PDT) Date: Fri, 11 Apr 2025 12:15:16 -0700 From: "Vishal Moola (Oracle)" To: nifan.cxl@gmail.com Cc: willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, will@kernel.org, aneesh.kumar@kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, linux-s390@vger.kernel.org, ziy@nvidia.com, Fan Ni Subject: Re: [PATCH] mm: Introduce free_folio_and_swap_cache() to replace free_page_and_swap_cache() Message-ID: References: <20250410180254.164118-1-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250410180254.164118-1-nifan.cxl@gmail.com> X-Rspamd-Queue-Id: C8476A0013 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: ufht38ahfjihanpbauzb3xcdrh7sdszz X-HE-Tag: 1744398920-802111 X-HE-Meta: U2FsdGVkX1+S3cQpJjfZ/xcfBYrN0E1Js2HrbzsHuqmr6SmI9CyWnrHH2AlGfiHdv+noJ6HgDrpPf+sYgOnjQABunt9LcNDhD9VnQeevFVHM5ZAthC9JMnp7qYPKWN6ultSi0icfaLKaKesmk3hdbHzF+Dp5C6OdXBWFysWDziaZbGX397qPOeM6wtRRD84zdsfbguhAsHxcTw8lOCU7hlXw0Z4QpBPTbnens0ts4shXvK4flN8h9Wq/bk0myXkqkmzx6NFyVg8hlRG5o4InQmu26WUJF7wGD8uM60dWH4BbNwD0W/CTau7sxs4UJAgpJoY45siuCOLZKkCMxHH9cpnstndia+9X3tZWf/Vud7jsKnK6+0LCOAcQq7xrYFADnQ5iEcl8AsI05YsnsHRdxOOmMJZUavlEzIV1ihMJAUNXfOxDG6cfvbzY+bH8R+wOH6qVWqRizfboAi3LsQWltfs8rZBFeWgftOUa7L+w85ZkS89lOIrOIu01fi+Yo6tkyCU9HqO3dU9rCWUw+7w3wp4Of/eaWa9QKATOnp4VEk5kYaFjL2yotnsGiYBffF59vVZTMnc1PtHCft62u8Q0/X8XWTs0/XdAHaueNypcXaxv9wEq/LMu/jD9xUFbRqONyRwHAeWSKV/LuFI8l8hSRM772hn4K2QrhCuDHiGaoO1o68IHhnXQez2MP4KEt2MVmHWLy7OGCCtIfb62MxEKRp8O/N0RclosfuXj32SBp6NviZn84+l6rsbCQCSm0ac7etsi+Uboq/cgQLlkVgARe1XmVv437FJjrOMx5pc35JClYop8CUjJGaGCg8UJAhKAb4WEhPfuYqfnjKmRyht3FpOVZziNzr+GczA4fjz7cZ5b3u511DLs1v9+alrdJG6jHt4+5aAvfEV7Z9jT37iamKy4PMD+E3xarg6jtsaGNDC/ESLEYy07FOYy7mXBlvHz/T4U7xMPPk4AgqFcLP4 rySzsfKG iSfu9AMDAN0jjNBKr1BTr7Y3XKHL5DmVW2Ytjk+iWv3sRI9qAyImR9+ZWniOWk34lksaHcoR/EtFZ8WMw/0D/1s67hlMl+NFimr0E/jSoB+YPXIIEdtbZfmr/OOq7eXYDUf2AOz98plSBZPKfyiVRM3GXm8c4cWkZadpXJahvV03h0UT4Fkr0aiZSFGhqWm8SnO5fCAXRa8DSPMMWqPzm9fkJAD2J882PK4xTfrJXEix5Zi5kw6pi4ngumN3ACmas4uF3D7lTm41EsNC9ejtctNhI94N3r+ZNuBUClDhxbkTGEMheM0SXqmOVIeFg9TMtwo9X1rd0l5ahNxm79piUjIeAo5pbSk2NslxFACL3oYPr+oQ1CouY2CKqTyTlTh+GhU/PjzD+BNCza9AoOgMwJyWrjyY/THOG1kwLJh7+xEcifoDhXn9HRzXDwX9w/dC1+bfYEyPSKhe8xWTmuarGP2SrQZfqyn3SY4m2BlXvwSUFJVyizi4n6DFk05s8/+9priDQXE7y2e0j+jCDZQ8FPqIQmuu7aRwBDhutbTvvC1RBVsN8w/XgE5ABzn72p97AkBBqtT0ocSJ6kdsheN6FhdoGC0UQ7MPaHGrJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.081418, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 10, 2025 at 11:00:31AM -0700, nifan.cxl@gmail.com wrote: > From: Fan Ni > > The function free_page_and_swap_cache() takes a struct page pointer as > input parameter, but it will immediately convert it to folio and all > operations following within use folio instead of page. It makes more > sense to pass in folio directly. > > Introduce free_folio_and_swap_cache(), which takes folio as input to > replace free_page_and_swap_cache(). And apply it to all occurrences > where free_page_and_swap_cache() was used. > > Signed-off-by: Fan Ni Aside from the unnecessary folio_test_slab() others have already mentioned, LGTM. Reviewed-by: Vishal Moola (Oracle)