From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: nifan.cxl@gmail.com
Cc: willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com,
dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
will@kernel.org, aneesh.kumar@kernel.org, hca@linux.ibm.com,
gor@linux.ibm.com, linux-s390@vger.kernel.org, ziy@nvidia.com,
Fan Ni <fan.ni@samsung.com>
Subject: Re: [PATCH] mm: Introduce free_folio_and_swap_cache() to replace free_page_and_swap_cache()
Date: Fri, 11 Apr 2025 12:15:16 -0700 [thread overview]
Message-ID: <Z_lqRPL9HIyN1f6P@fedora.attlocal.net> (raw)
In-Reply-To: <20250410180254.164118-1-nifan.cxl@gmail.com>
On Thu, Apr 10, 2025 at 11:00:31AM -0700, nifan.cxl@gmail.com wrote:
> From: Fan Ni <fan.ni@samsung.com>
>
> The function free_page_and_swap_cache() takes a struct page pointer as
> input parameter, but it will immediately convert it to folio and all
> operations following within use folio instead of page. It makes more
> sense to pass in folio directly.
>
> Introduce free_folio_and_swap_cache(), which takes folio as input to
> replace free_page_and_swap_cache(). And apply it to all occurrences
> where free_page_and_swap_cache() was used.
>
> Signed-off-by: Fan Ni <fan.ni@samsung.com>
Aside from the unnecessary folio_test_slab() others have already
mentioned, LGTM.
Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
prev parent reply other threads:[~2025-04-11 19:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 18:00 nifan.cxl
2025-04-10 18:11 ` Matthew Wilcox
2025-04-10 18:16 ` Zi Yan
2025-04-10 18:25 ` Matthew Wilcox
2025-04-10 18:36 ` David Hildenbrand
2025-04-10 18:51 ` Matthew Wilcox
2025-04-10 18:55 ` Zi Yan
2025-04-10 20:31 ` Davidlohr Bueso
2025-04-11 19:15 ` Vishal Moola (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_lqRPL9HIyN1f6P@fedora.attlocal.net \
--to=vishal.moola@gmail.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=fan.ni@samsung.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nifan.cxl@gmail.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox