From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15F0CC36010 for ; Fri, 11 Apr 2025 14:21:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D71962801B7; Fri, 11 Apr 2025 10:21:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1D9F2801B6; Fri, 11 Apr 2025 10:21:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0E3F2801B7; Fri, 11 Apr 2025 10:21:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A71792801B6 for ; Fri, 11 Apr 2025 10:21:49 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7AD9A120339 for ; Fri, 11 Apr 2025 14:21:48 +0000 (UTC) X-FDA: 83321976696.15.0A437DB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 40C141C000D for ; Fri, 11 Apr 2025 14:21:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KfmHQex8; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744381306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YtT01ajOsSmZLSUYde+7t7bxHp2pbObLzVWdGuotdHQ=; b=utsywD9QtOEjeVFV2hUhd80zTC1cZPh4ON7Dss6fHHW6/pA1+qW/yskzV+2ut5qb1amltr twJodyb477hS+OmsJWM960nzYlsW0aF1EmIxWZsvDVhreYdMKrofbz0jQpw0B8fsKjHi9U Jw7eZOVzx4PkdFrKiXgmi+wNHTaba2g= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KfmHQex8; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744381306; a=rsa-sha256; cv=none; b=XZ/RFVkG4yKq8B0uvQgFn3iu1vZQPw/GUG8Wn8LRfNX5+rp3uhEkCcRzE3BGefo1i/aU5M UXAgJuB04DNdh5vJ+JmledkhmK8rVAEaOhq6X4KDWQKRZWqYCTRlrl5IMONozp3//n5n52 ktB6wStXkYIHfG7A7N5/7srXyTionqs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YtT01ajOsSmZLSUYde+7t7bxHp2pbObLzVWdGuotdHQ=; b=KfmHQex8aMJwIORN5vrOuV7n6/ eyLo9D8CBDcLdEKIkPodWF8II4y9l7R+FQfmO90ZqVU56KHIK8CkuMGGfrOUX/mkbs+i7KxSgBCtM AvSjTQK5o5rWof890naGoKIIHNmCeHiOixCBMcBBXsUrpgAgGR3Zxx52/xEl7tVA9t/hAyyoXV1OP incV+dcc+2RwwtaWk74EqH4zRVIX6Qsh//FVWLjfZhktYpvx/BxVxCFuh/p6lr1tNyrGHul6/Akxl MN9tZIfMicPQ7eoFB+ziUvyRAnpif2ub+YPAosWZe9ildBdq8nuzqlaYaA7ORCWJEdCcJlr3yh0uu MZ5hEPRA==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3FGI-00000004Lk8-3IgK; Fri, 11 Apr 2025 14:21:42 +0000 Date: Fri, 11 Apr 2025 15:21:42 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: Oscar Salvador , Andrew Morton , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka Subject: Re: [PATCH] mm,hugetlb: Allocate frozen pages in alloc_buddy_hugetlb_folio Message-ID: References: <20250411132359.312708-1-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 40C141C000D X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: gctrgzbebcktamupxs8jj1rwpr3fnhu7 X-HE-Tag: 1744381306-737852 X-HE-Meta: U2FsdGVkX1+hlaAVxey0R+ppc4TO/cFN6KhXOuvSoRgsv61gOnfdaLiI2X89UGtaGrdWg3w+BC/WSQCNWbXpqPSy12DtO3LTvRlJx2UQzXDIMnmoEZLll00jgIPyjWHifYPCVFGfisVNqNHiVncVoqQjGU50jW996fCmPKx2TYfm9NMjD0Cgzz9HRo01o7w/1yhY3hvg23Ktok0m2XTyEkV0tSCzNLihA3klsY57X9XHEnkTzypisFM3H6IMr70aFlTiJ//jj/v6Y80LVUZfmcEq913w8hmmG68jgquT3cnOMH7DkwcPdEje7OMbVezsZFRzkrKEF6WPuPBo4Spu4AxctvkGYzYNwTA9yXhdNBv0SW80a0969eQn6W2Df3vPbOYkDSGHi2BCaBM+r1C5pRYdIiS/NNT9667+mBqBZkZ24AbYK5E6qCzd5oon/VPvm2brmapgnGE6KNxpXsDhGcPWRMkYutAMbs1FzGnJ+3gfiKVKBsM68Gr1y5p3oS6OitD8yr7g4tOChbd9xzawrb1n+d6VQcW/POTUCPt3z+/RJqwlEO8PBDztZk9D5RfY1d1r0wDTuItc2H+D+zEmLKoABH/SaedTz4otbl5ANIpZem7CIRfXL5sWkKO+1Dbd4O6Hn5GxqSSdYSwgvSClbqy0xFhJ9Bdt9IUzOrdXmN2Qs17FTOBRO7xQOdQ9umMJlxYiuXkXuwjuPNatbkG5zpDqB+YeK0OiffazB+uQJfD/1oletVnpp2MJJtKWEe8i9KmijRPjxJzU8vGibzhqQpED136lYs1IP4DR1RzNaVy0uM2Jk/Mmhj4bwx1RAv16GqZrSWXuTfTbvtN/VpadVfbWZYc5/YPzRsU7Q7mia7romdJnZJjOOUX22V2XL8lfXGVLvYFtn0kiQ0Vr5ei6QEMnwxIsejdIDV911iZLnYJbg00fdz45iI4Y7SmeOkU3VqGhpi2UuYkAfvnIeUx qnjqyJaE zhDccjB0EcwPKNNJjDqG7Nt3mYBLH8okWuRsUD49SKfN4Zc5668CuPyJmFVDT7kbfbi4phqWd3PuwUOGPX5vvyz/qR4s9SKiSRS+wZ9SmATVlWSUbVuCw6sliCO99tVPG8bsQd8psVHrNGV4AQeqh3orB7oPRYXZq2HnoBDyYD/YqEYjwLDlFgbFR5HSqIRNDMlsOuz5xurYQ/IWR3E6m80OyBP248ABfS+0IhXI0KnmO//n8g5vURPvdLNXfd+GeUUlOqJaMSyMm7L0CDxcOy69K/2wj5mxgep1y58vBuLss+1p7rGokQkKTAnRr5x6eeKXvxDG+rs04kIY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 11, 2025 at 03:44:31PM +0200, David Hildenbrand wrote: > I assume htlb_alloc_mask() will always include _GFP_COMP. static inline gfp_t htlb_alloc_mask(struct hstate *h) { gfp_t gfp = __GFP_COMP | __GFP_NOWARN; > But semantically, it might be wrong: __folio_alloc() will in the memdesc > world also make sure to allocate the memdesc, __alloc_frozen_pages() not. > > Maybe one would want a __alloc_frozen_folio() .... @willy? This is fine. Yes, it'll need to be modified when we get to the separately allocated memdesc, but there's a number of places that cast the freshly allocated page to a folio, and I'll have to come up with a way to catch them all. Reviewed-by: Matthew Wilcox (Oracle) Oscar, if you want to take on the gigantic allocation next ... - I don't think we need folio_alloc_gigantic() to be wrapped in alloc_hooks - folio_alloc_gigantic() should return a frozen folio - as should hugetlb_cma_alloc_folio()