From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C38C3601E for ; Fri, 11 Apr 2025 03:14:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C65CE28014E; Thu, 10 Apr 2025 23:14:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C165528014C; Thu, 10 Apr 2025 23:14:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB5A928014E; Thu, 10 Apr 2025 23:14:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8CA4328014C for ; Thu, 10 Apr 2025 23:14:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C96861417F7 for ; Fri, 11 Apr 2025 03:14:41 +0000 (UTC) X-FDA: 83320295562.13.C379539 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 9B84D4000C for ; Fri, 11 Apr 2025 03:14:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=nPIcN93G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wQ+Qexkp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=nPIcN93G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wQ+Qexkp; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744341279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/OdfG6AiAbx+J2/sOs1IgaMLUTVNE3PJ0+dUGIA+UEE=; b=0OrAn6mCiJlEeApbO4sZszNjijVobaMcLiRvWKqfxMOhHvlLCOumRqO4vEXLc/0KypVvv/ FBiPx4LjMsfnL0sYAplAVtCyb/nTGR3udacci985WXIIExb/pvxXIJS2eogTYzGCecrT0W M0qLstc+49FGLnXfbnLZRAOd05z71AM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=nPIcN93G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wQ+Qexkp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=nPIcN93G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wQ+Qexkp; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744341279; a=rsa-sha256; cv=none; b=E7GIvVKUypl1wfHeFO5kVNCYT0ZryUoMNqzS6hpxUUpCLaEbjqpadYyikY/TYpuFiNhhP/ eOBS91rfA2Vj6oV+HILlnvn4RFIy/oBS/bXvye6GQ5RWF3oLAVw46sq+flNU3IsmGovjCA 5nG3TafhbVe/mzvRTBohqYLoStI+B4s= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DBD7821163; Fri, 11 Apr 2025 03:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744341277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/OdfG6AiAbx+J2/sOs1IgaMLUTVNE3PJ0+dUGIA+UEE=; b=nPIcN93GPscI5eEY+8zCM0GPpOtSaw8mJUVyuWKDGEdWEJZcU330LQ5TMO1UB+r/Wc94uk J3U8Xa5XALjoYL4MzhjVDKC+Ajw/Qau/wQ9PtkMggNneZWEx23Ql/45KIQ3iemfmNzNodl LCUzJAYm/EuMDEmnHlWdOJWotoQeMjU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744341277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/OdfG6AiAbx+J2/sOs1IgaMLUTVNE3PJ0+dUGIA+UEE=; b=wQ+QexkpFwwFVX279DS7buUg2NDPDMyA2v2xTP/ZJhQlk687t+gEyxlfQtG7lv7xz26q/7 ZZFKfdyS2z0GvyAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744341277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/OdfG6AiAbx+J2/sOs1IgaMLUTVNE3PJ0+dUGIA+UEE=; b=nPIcN93GPscI5eEY+8zCM0GPpOtSaw8mJUVyuWKDGEdWEJZcU330LQ5TMO1UB+r/Wc94uk J3U8Xa5XALjoYL4MzhjVDKC+Ajw/Qau/wQ9PtkMggNneZWEx23Ql/45KIQ3iemfmNzNodl LCUzJAYm/EuMDEmnHlWdOJWotoQeMjU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744341277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/OdfG6AiAbx+J2/sOs1IgaMLUTVNE3PJ0+dUGIA+UEE=; b=wQ+QexkpFwwFVX279DS7buUg2NDPDMyA2v2xTP/ZJhQlk687t+gEyxlfQtG7lv7xz26q/7 ZZFKfdyS2z0GvyAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4DAE713886; Fri, 11 Apr 2025 03:14:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zaM6EB2J+GeuRAAAD6G6ig (envelope-from ); Fri, 11 Apr 2025 03:14:37 +0000 Date: Fri, 11 Apr 2025 05:14:31 +0200 From: Oscar Salvador To: Baolin Wang Cc: akpm@linux-foundation.org, willy@infradead.org, david@redhat.com, hannes@cmpxchg.org, 21cnbao@gmail.com, ryan.roberts@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: huge_memory: add folio_mark_accessed() when zapping file THP Message-ID: References: <23fdc11d-e983-4627-89a8-79e9ecf9a45a@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23fdc11d-e983-4627-89a8-79e9ecf9a45a@linux.alibaba.com> X-Rspamd-Server: rspam01 X-Stat-Signature: cnddxj4arrwbkekmhcxo71xfkjx346rt X-Rspam-User: X-Rspamd-Queue-Id: 9B84D4000C X-HE-Tag: 1744341279-123939 X-HE-Meta: U2FsdGVkX1/baqBm4uEAf/RnSPZ74SKSsEQOVlf0jblKdMCzYKjL1vUF1UqIu09XWcLORt/zUIFQCYlGCdxf5NEPWMooExKmFzDQrCLITNGcQJXI3ZJofuFXbykPzpxHrWelHXLPupJAgnf68D0J9MotxwPSVuq6E0VvlZFYzxCATSKgNoJREirUo7y2Vm8t+2tk7s6SrRa0DZIe5LQKnqKMt3PIz/4X4t8GhuaXsSz8bAncUW0nB1gAH8zjK0h72XkzrGz6AFjGCLoRJIHH6JlzfPSkBCrlbDnuRSIHtSd/MXQgbAklnYvB/wcqE9VhGraTIqHmPH/UBsNhuUGukeKdYKBDtiB9Bktwx0ZfRu2WTilwIgzFTbXIYzCGCjSI86dV4m7m8Qc7MdBrkgW+IeMBBEX+r4OxQPAF0JuOOT/9vY0LZl8rddKoypKZKgMK/sbFZl/0ZGyhyuwYZK5QhKbPj0yGL5VGrYs8KreVpOMUiNHqo+ObL+tbwezO6wLYBb62OMB5nC8Q8XZ6/4JBn3AooziAW+SwSTywtxppcDheudG8YNK4UudqF/+JwTCZZw5n+sciiUlUaW3dbhelS0yEr6lKVuKp42CmXtkuU76gLzM+hqnDvhC4c2ie333SxHuM2EKxpgq3yCyW6QI8UahlrUFeYfF9EiuFLxdrwRYIVakvasYOwghprTN6W1LLVeiOFNDc2bU5zfD78wYRqZLh/3+uxzRtaYsNzjBhqW2odX1MfrlKWF3vko6q3ljn8BWNzpzpN9XUNkCUcpfc2anJ+T+PJKY40Mz0fWLFuzTXiPOQc74G83kVS7DwG/rQuihCCd+oFOguO3+3sIOVgtVXk2LHhWMOJgrZ6zlBIN/adzsHm4snnSyg94LwHzJRrb26KTG3JBzVrCJSNFjwEHxWCoRo8EWpx/FyPS26oM3J1KOrX3+EQJUWbTlNrub1TxoDxQdqIF8dTIPggDq d3G7mGIS 3+MIavMpApq6t8ojU4kXR3yQIyYfPT5AQkYwN5c5FHSfhXxVZbNOXNIeuDGiH9JrXscSxFf1WV409sJE10S1xvXi0gYUVwrH/9WDiivx736TIHkEj7KHwntvJd/KX3IRwVuE0Yiy4MXcWrWE4mhaCiMDJ7FsbyT0In3jnnGS3Eh7DH2jGAyJ8DecsoEMiG8qERuvK9VqDT+nuNk4cBCKajTp67IxdU5LxdzmFdvf3slUEArZj/gyK6tVrfgkN1hGx2qvxRlYl7HkcYFg0H+hRh/H382VCuhQn3kc20vmvegiIoCHDn2w/LFXSgLh8F7utpdulh6yRxR5PB/E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 11, 2025 at 09:07:16AM +0800, Baolin Wang wrote: > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index b3ade7ac5bbf..93abd1fcc4fb 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2263,6 +2263,10 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct > vm_area_struct *vma, > add_mm_counter(tlb->mm, mm_counter_file(folio), > -HPAGE_PMD_NR); > > + /* > + * Use flush_needed to indicate whether the PMD > entry is present, > + * instead of checking pmd_present() again. > + */ > if (flush_needed && pmd_young(orig_pmd) && > likely(vma_has_recency(vma))) > folio_mark_accessed(folio); Yes, thanks, looks good to me, and I see that Andrew has already taken it. -- Oscar Salvador SUSE Labs