From: Matthew Wilcox <willy@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev,
Alison Schofield <alison.schofield@intel.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Alistair Popple <apopple@nvidia.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v1] fs/dax: fix folio splitting issue by resetting old folio order + _nr_pages
Date: Thu, 10 Apr 2025 21:23:16 +0100 [thread overview]
Message-ID: <Z_gotADO2ba-Qz9Z@casper.infradead.org> (raw)
In-Reply-To: <67f826cbd874f_72052944e@dwillia2-xfh.jf.intel.com.notmuch>
On Thu, Apr 10, 2025 at 01:15:07PM -0700, Dan Williams wrote:
> For consistency and clarity what about this incremental change, to make
> the __split_folio_to_order() path reuse folio_reset_order(), and use
> typical bitfield helpers for manipulating _flags_1?
I dislike this intensely. It obfuscates rather than providing clarity.
> static inline unsigned int folio_large_order(const struct folio *folio)
> {
> - return folio->_flags_1 & 0xff;
> + return FIELD_GET(FOLIO_ORDER_MASK, folio->_flags_1);
> }
>
> #ifdef NR_PAGES_IN_LARGE_FOLIO
next prev parent reply other threads:[~2025-04-10 20:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 9:10 David Hildenbrand
2025-04-10 19:12 ` Alison Schofield
2025-04-17 3:44 ` Darrick J. Wong
2025-04-17 18:01 ` Dan Williams
2025-04-17 22:59 ` Andrew Morton
2025-04-10 20:15 ` Dan Williams
2025-04-10 20:23 ` Matthew Wilcox [this message]
2025-04-10 20:46 ` Dan Williams
2025-04-10 21:54 ` Matthew Wilcox
2025-04-11 8:28 ` David Hildenbrand
[not found] ` <qpfgzrstgtyus3jkzrdpwxg2ex7aounhwca65bxwlqxws2drhk@op362gbaestm>
2025-04-11 8:37 ` David Hildenbrand
2025-04-14 0:32 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_gotADO2ba-Qz9Z@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=apopple@nvidia.com \
--cc=brauner@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox