From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B250C369A2 for ; Thu, 10 Apr 2025 18:11:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D7F06B036B; Thu, 10 Apr 2025 14:11:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 986E06B036C; Thu, 10 Apr 2025 14:11:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 876576B036D; Thu, 10 Apr 2025 14:11:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 65FEE6B036B for ; Thu, 10 Apr 2025 14:11:30 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 88308141132 for ; Thu, 10 Apr 2025 18:11:31 +0000 (UTC) X-FDA: 83318926782.23.95DAF0A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 83F071C0010 for ; Thu, 10 Apr 2025 18:11:29 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RKe35nLl; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744308689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yyuMpWN1TzmvBH3elyBl05iozN5VhyzZZE5A2u1FTkI=; b=vO1ArPDpvWtcG/7Uc6m3tSsA4cMp+ODcfefeftKXQnFHWfFvzklM0XySGAn2P6vMh4rtiS 3855tXkoGjcV5WfedhJkU0bUniKabOlk+m68MYUgfjAFv4e6D/r9RWb7nzFw2N0qstg8W7 mTHfRFxW0YOPdiveIFiM+S0baZsIzy0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744308689; a=rsa-sha256; cv=none; b=qS60N9N6AevyguXxYQ4NXPzw/zp8ALZ+ZS532rQZFN2a/SVDvAtSjeMjtwGCMSRwQ+dKD7 v2b1+QC9dBdSa8S/xnu98U9AY4oPShr0ucaa/qyO9pxVdKRgMVQx+j4Zl0pAD93o4FkQqs rowzsUoF6wxYcoyY3rB7RnwPTe0153M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RKe35nLl; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yyuMpWN1TzmvBH3elyBl05iozN5VhyzZZE5A2u1FTkI=; b=RKe35nLld+M1O+UUdR42XC0y9h E0/JYpSjH4ruxAAQqlFDX8GG83afIQumInqD4LOKIYSyXjemx1WXUqvmtujL6xHW0GWDyuTUfvNgd BmBUpwQuRd1EcLsRuUK2336CNMhcWAk+en4DK2L/mH4oej5b4sBhyNrjf3skJIVoSnsojKJ37Cefe 8owOATtmm4QxN6EvvY7Mm1mL+34MwQTc+j809hDrfgoytJy87W2CxuXNdqEtN6sg24QJMkU5bU069 SlLmWMtp33c9seSGf33gnRCRM5ioI9zBA/pfNQTLWFo251a4sijHZXNV1leCFqLaq/3Ac51zVGSwW ldi/O7Qg==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2wN1-00000003ERs-3FBV; Thu, 10 Apr 2025 18:11:23 +0000 Date: Thu, 10 Apr 2025 19:11:23 +0100 From: Matthew Wilcox To: nifan.cxl@gmail.com Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, will@kernel.org, aneesh.kumar@kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, linux-s390@vger.kernel.org, ziy@nvidia.com, Fan Ni Subject: Re: [PATCH] mm: Introduce free_folio_and_swap_cache() to replace free_page_and_swap_cache() Message-ID: References: <20250410180254.164118-1-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250410180254.164118-1-nifan.cxl@gmail.com> X-Stat-Signature: 3pfp9iiq5qinxjoad1mqwwipxp37pmof X-Rspam-User: X-Rspamd-Queue-Id: 83F071C0010 X-Rspamd-Server: rspam08 X-HE-Tag: 1744308689-18974 X-HE-Meta: U2FsdGVkX19Xqb9p7zLx2FlamPtTgFfvYAyNPs+CcUj6XfOHNlAhDm0fmAhmVY8IXPdefqiVNaZi4ffm/nP3reszQCsGPI0eHL+dRYo2Aw10AmqSbRtvI/yiiFYn6c7B9FN0A4txjNdr4LbXPqjQibeg1Sl8lDSaYpVpwMxS8WrqnfMh20sHQr+6SHIk7/YYP5uN1ib8H0Cjz2LxmDQ9NnnvAegMPujhZjHoBfoVvcedQNPADMEPmLqcoubPLd2ywCGbqEX2BgX/3TcMTOx8tRprWoxcMJX/Eabv65HNcMCtYLTPjxZz4SKDqjRXx92pc5tkFA4ZfZ8PXUrVYibq2ZHF7Y7yK1hpsd07jFAPVEE3CqXosQUvReL16iWecRJx7ZfZgJ1K9Fc0ZRBcE8jDadLQjRJXICIJrrY0xViItDb2LgzxuNXVkcFkSyJQsTtdqkyfGTiMPaq57emVvyUaRjJMYgaOuA2WTWdeciBerlf6xQEUEki92rI4lgfXcxF0HOQxwcmSfq+IKJ3MSOUc5V8CJdjFY4jBZVdpi0E4AK/DQVXC3HvLUx99pdof1M3MyRF6aKymRKDasO/SiEyZ/FsyUcEbIdwDE1ebvYyARs6jKqJ9SwxHbENEfaFkIiEBq9FkcTYeT7igSVayp+4+NaShvKRz7Cf0HKHudaAkAb4jeCNY1Zq4OP+X33FHRPG3VovOv0kwJwWWWyZ8wf98iWMci8E0y0ijcbNFqoSxazHIRHLvqgJBxII6Y3ZWFE+4TBO2oQELrEOGZefT9uzU7vmvC3keIZk5NgwVf6I4tCwV/fYIW6szI/M0e2XWHPuUPyHIB5EOY7P+jNx7wg4qaS9Xv+Swxk0WK7Td4hoEAZsejHvFFQ+wRHhdh/Rjt4KUQk5nxwxtmIbYSwMZNpPKTmnxI0aEAsjyeDmZT19OJkVL5SB98JKzURa3+QpG6fk6zVG4BYnLhqXWyZvXJg9 yNA0Pjd/ Qxis1vklnB2sXVGAnheCcNNq5DVQXiSMPk5Kof9XksRGUmRbo0SUZcyl32kZuQCattY88tFw3rgQ/DN+l+l8LE6r37AFc99iwBJVoOcXQRqvtERkBIuimSuauVaxN6oLanOpuBA0WQGuV7SuucyoimtQHRipPzrhpw77gCxlSeyruwldjK/EZ8viUNSknDdWGl/zlCQtnyoEX70FkeWi3BmQLvtwzawPPaq+uGpFZ4imvNesQC6q4Bn0ewYzumQYI/WNQ50Z7i2lfliVrzwUzrCigqNWWWl014bfP34vvQB5dIM5DnYgvvbkECeHcx0gW/iz2E9xAzkmXS46vBHSYfK8N7CysEPlCIxNQ3ohwGhUyIVmelXMYagvjFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 10, 2025 at 11:00:31AM -0700, nifan.cxl@gmail.com wrote: > @@ -522,8 +522,12 @@ static inline void put_swap_device(struct swap_info_struct *si) > do { (val)->freeswap = (val)->totalswap = 0; } while (0) > /* only sparc can not include linux/pagemap.h in this file > * so leave put_page and release_pages undeclared... */ > -#define free_page_and_swap_cache(page) \ > - put_page(page) > +#define free_folio_and_swap_cache(folio) \ > + do { \ > + if (!folio_test_slab(folio)) \ > + folio_put(folio); \ > + } while (0) We don't need to test for slab. Unlike put_page(), we know that slab cannot be passed this way.