From: Matthew Wilcox <willy@infradead.org>
To: nifan.cxl@gmail.com
Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net,
akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, will@kernel.org,
aneesh.kumar@kernel.org, hca@linux.ibm.com, gor@linux.ibm.com,
linux-s390@vger.kernel.org, ziy@nvidia.com,
Fan Ni <fan.ni@samsung.com>
Subject: Re: [PATCH] mm: Introduce free_folio_and_swap_cache() to replace free_page_and_swap_cache()
Date: Thu, 10 Apr 2025 19:11:23 +0100 [thread overview]
Message-ID: <Z_gJy1h-IoRP0JDO@casper.infradead.org> (raw)
In-Reply-To: <20250410180254.164118-1-nifan.cxl@gmail.com>
On Thu, Apr 10, 2025 at 11:00:31AM -0700, nifan.cxl@gmail.com wrote:
> @@ -522,8 +522,12 @@ static inline void put_swap_device(struct swap_info_struct *si)
> do { (val)->freeswap = (val)->totalswap = 0; } while (0)
> /* only sparc can not include linux/pagemap.h in this file
> * so leave put_page and release_pages undeclared... */
> -#define free_page_and_swap_cache(page) \
> - put_page(page)
> +#define free_folio_and_swap_cache(folio) \
> + do { \
> + if (!folio_test_slab(folio)) \
> + folio_put(folio); \
> + } while (0)
We don't need to test for slab. Unlike put_page(), we know that slab
cannot be passed this way.
next prev parent reply other threads:[~2025-04-10 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 18:00 nifan.cxl
2025-04-10 18:11 ` Matthew Wilcox [this message]
2025-04-10 18:16 ` Zi Yan
2025-04-10 18:25 ` Matthew Wilcox
2025-04-10 18:36 ` David Hildenbrand
2025-04-10 18:51 ` Matthew Wilcox
2025-04-10 18:55 ` Zi Yan
2025-04-10 20:31 ` Davidlohr Bueso
2025-04-11 19:15 ` Vishal Moola (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_gJy1h-IoRP0JDO@casper.infradead.org \
--to=willy@infradead.org \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=fan.ni@samsung.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nifan.cxl@gmail.com \
--cc=will@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox