From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60806C3601E for ; Thu, 10 Apr 2025 13:55:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47BA8280102; Thu, 10 Apr 2025 09:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42A1D280101; Thu, 10 Apr 2025 09:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31A07280102; Thu, 10 Apr 2025 09:55:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 14034280101 for ; Thu, 10 Apr 2025 09:55:29 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 63BF3B8667 for ; Thu, 10 Apr 2025 13:55:30 +0000 (UTC) X-FDA: 83318281620.19.E9C6086 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf15.hostedemail.com (Postfix) with ESMTP id 37017A0003 for ; Thu, 10 Apr 2025 13:55:27 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sOILeg+2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="Z/OXTelw"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sOILeg+2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="Z/OXTelw"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744293328; a=rsa-sha256; cv=none; b=NM5CbOHAcnmBcUzDiSCzmvtE2ghwF3GRcS88ZgrWR9D3jBqQEPDnBVZD58Khh5WBdCUDoF 7ttozXwAW6phJfoSlThlmtX93QzqVOJgXCqMQ50MocNaXckFmn5SRaw3divhUAKWE8F2WO w/4nFDNjwZJH07ya6BV7Wwa+7Jz4GAs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sOILeg+2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="Z/OXTelw"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sOILeg+2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="Z/OXTelw"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744293328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=slFcpUKngMaxeKh9g43/vSqYK//QRrWjwpIc7hgFzhU=; b=k8vunRTGshFJCLZzDKu0W8RyGAe/qURrQtiZeNu0fglPyqZtldMautTWWOUXKx5qht0pty NQ2WIE2LTEeEcWupCu1pCsKgLq2SBXBHGG+UdUrPXaP7wAfERGvhqhIi0a/kEuBAnHDxhT zWVLjtX0m27YWO3WRSO9Xh6Fr4pwefQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 835A521179; Thu, 10 Apr 2025 13:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744293326; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slFcpUKngMaxeKh9g43/vSqYK//QRrWjwpIc7hgFzhU=; b=sOILeg+27QLtlJZPA/dGwPoBBD2Clh7qgGAlLmwxmU71MErWsuk6gr8PtJi+CE8YKKWID7 4xc9RegdI7O16X9YO85b/+ObEMugpjkK7QW4d9DripqOCeo4/KFnsVv86Wb1GRx6u9ree4 HC1nkz9BuEkx1Vsoy60/t64h5CszUiA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744293326; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slFcpUKngMaxeKh9g43/vSqYK//QRrWjwpIc7hgFzhU=; b=Z/OXTelwM1h4EmZ+Q1heCXvmKQ3KDKAK+ebC7P/MK9RkhmgpedZ2+VuhbIJ/hHlzDyJrTv hTZ2RFa3aeVIUnBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744293326; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slFcpUKngMaxeKh9g43/vSqYK//QRrWjwpIc7hgFzhU=; b=sOILeg+27QLtlJZPA/dGwPoBBD2Clh7qgGAlLmwxmU71MErWsuk6gr8PtJi+CE8YKKWID7 4xc9RegdI7O16X9YO85b/+ObEMugpjkK7QW4d9DripqOCeo4/KFnsVv86Wb1GRx6u9ree4 HC1nkz9BuEkx1Vsoy60/t64h5CszUiA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744293326; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slFcpUKngMaxeKh9g43/vSqYK//QRrWjwpIc7hgFzhU=; b=Z/OXTelwM1h4EmZ+Q1heCXvmKQ3KDKAK+ebC7P/MK9RkhmgpedZ2+VuhbIJ/hHlzDyJrTv hTZ2RFa3aeVIUnBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D58A0132D8; Thu, 10 Apr 2025 13:55:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id J8ouMM3N92fncAAAD6G6ig (envelope-from ); Thu, 10 Apr 2025 13:55:25 +0000 Date: Thu, 10 Apr 2025 15:55:19 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Gavin Shan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, adityag@linux.ibm.com, donettom@linux.ibm.com, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, akpm@linux-foundation.org, shan.gavin@gmail.com Subject: Re: [PATCH] drivers/base/memory: Avoid overhead from for_each_present_section_nr() Message-ID: References: <20250410125110.1232329-1-gshan@redhat.com> <9deb3725-8991-43d1-8c3d-56523fabff28@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9deb3725-8991-43d1-8c3d-56523fabff28@redhat.com> X-Rspamd-Queue-Id: 37017A0003 X-Stat-Signature: cio8op6ocjaewbqbn4yzpbqqwrxqqpwo X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1744293327-691962 X-HE-Meta: U2FsdGVkX19zFVLXC98Z0MWGaptf1n6/+89FF5o7HFvhyVOBd03uH7DsWJOOoRCTmi7jVH87HI2E/ywaB7oZmmXES8+OAO8ikkN4ba6/KCRA4cSSqBRs0rNI/HsfTEU697ZDOebMfP50xmeEfLQcD0HcA2yGW40VYZuT/XQcz38peGfVBLJvs/856xO0N07896y5I2zWFYrPN9REgskdJ2z7U9JeNsFfh3Wq8wSeMJLr6+XR71ZiCnNhEzl50SgyQPJ0NvH83PEEdZ46xOsQJbobx1FimktZPTAUngA2SIVDyi3HyrPDBml0oAY7/1F6CTJmTQ7lnEzVMS0yIJFk5RypSZ2mArTb5AccmoNy8EHRV5umG4152x4yBNMB9vBRu17Ac0kp7ySWOURQRR4xYlYcui0+ZszP7pb6jTUA4r0bTYNC0k3fay6E1BvbX2AbVXyD2M4/hOJYvj0GgnrFeNem9rdWK+fl5RUeo9/Sn60BDGFIDgJ8kQ8gv3/ZCPe0nSPMeBY4igzbpaW2csmQzOlzz4xVvF/j0GDarWO1cJrFOV3DNvehyR/JZOD3U0PqhhOKqSk3mijdiNgG/D+sdIZgr8Unp5bj+C4nONH5z/5psYs+hPfpc6S9tl4O2HIphOIWVZVUq7rJ3b+WuHzBKWtXruNJQJS3N6aJUkhCFBdJv4oh8irYe4CD2CJIXf/OKcZQx4gLh2dd3W0tQvXGNSu7VMSnLgBeiMbMnglA2K5/QROyTshO7nsDlrVJ/kciTVonFkCy0CI1vMwPA41E1zB8fEsMvZyBOsguA87yRdX7nJB10/VcAI3HEbZSREL/TK6NBdCBEvF547pxPVonHw69GKG/6aj43nokkzhuG8YX1Niz1/CTxFMe7/yYUt7NonXBaDpsjdgSXJ8Dy6OuGQkBOeveZa8bTcsRn0nljY7FRAIZ2fRloTsY5jzTOb4hshoY0SLqfl3/i3gybiO HyTv4poI iG4To9+YFejZow+loWXK6FF60QyD98vK0hzBAZyarb0BydRXzEZpdb1Y5okEhmdy746QqqtWHE3wleSwYdGdeOXEpTQMB18bdStg8xHac1I2cpFfuZmzqVidnr4e5ySrGtMMbpTVWQfL9aVJMHj/8fsMvu6c9zc/lhdq9fgCpaS2xhnJbCQIKDSzdhECwmEVDXa0PVx/9PcJklKnjCnath5KB+R3GiFpbePi8lZIpeZB0UL2GN2t7OKYHydDN+06eWCAKAiBP7zv7LH4dEwSv7mqz5cKSnStMl7twF5E4V2vvUKy7Beb6dvQu4h1ZvWWegE+qcBel7rXdb8/Zl7Y/zZ0PaAp9qd3Kp1zvzMhlMbdvG4N+Ed+nwiwbeCE+68zy/Hyi X-Bogosity: Ham, tests=bogofilter, spamicity=0.140895, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 10, 2025 at 03:18:00PM +0200, David Hildenbrand wrote: > Staring at the end result and the particularly long comment, are we now > really any better than before 61659efdb35c? I think we are. I mean, we made it slightly worse with 61659efdb35c because of what I explained in the error report, but I think this version is faster than the code before 61659efdb35c, as before that the outter loop was incremented by 1 any given time, meaning that the section we were passing to add_boot_memory_block() could have been already checked in there for memory-blocks spanning multiple sections. All in all, I think we are better, and the code is slightly simpler? -- Oscar Salvador SUSE Labs