From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3759C369A4 for ; Thu, 10 Apr 2025 09:34:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35EF42800E6; Thu, 10 Apr 2025 05:34:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30CD02800E5; Thu, 10 Apr 2025 05:34:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D6E02800E6; Thu, 10 Apr 2025 05:34:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0044B2800E5 for ; Thu, 10 Apr 2025 05:34:23 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B4F7D58DB9 for ; Thu, 10 Apr 2025 09:34:24 +0000 (UTC) X-FDA: 83317623648.24.206D3C2 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf09.hostedemail.com (Postfix) with ESMTP id B66B8140004 for ; Thu, 10 Apr 2025 09:34:22 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=b45rK8n5; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744277662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TnbKxA6lsZP3NTEmyhRFBly3B+ZmNr9pag5vwciMRm8=; b=cB6Oo8spOu7q6n8uY1Z4Hlmt3S7nsoMeIXu/gqxI5i38udQhdchAQxBJhUteTJZwlhlhQc p7b8OXSwseHzE9k/a9+gcMJ9f+1SrsT3ADqnAfktuf3TyBFchJiZzTB22YiXaCr1daH6H0 xKJTiLfhhnGxUMsOdVGTHxRUTFP06rg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744277662; a=rsa-sha256; cv=none; b=tyD+vCr5AO22hOCP7h/ScurC1pxI6Q53zIbH2Fb+TQ+dJUaazSKlkvRZGtYWzcn3sI3fTK 4JgH74Vq4EDjSG6ZWUJrI8tbksow3HIH3oscYcpGyNEE8m/bPNOTAzfj7h7UM6wfsA2NEl A+GNJQyW9tMEDweaQ8JXA1+FT07fFSA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=b45rK8n5; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-30c2d427194so5702261fa.0 for ; Thu, 10 Apr 2025 02:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744277661; x=1744882461; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=TnbKxA6lsZP3NTEmyhRFBly3B+ZmNr9pag5vwciMRm8=; b=b45rK8n5kDBpyAC2Q30kW3ipO+IxvBVdBbH3NfTWKeExw20i+GWjwMMDw8jdocw61C seMmY1rZwyY9ksn/9BHcuqll0T7LF7iRExI+iz8b4XxxFpfBkSI591tNG4z7cSMrf4ql GvLUzPQ6ecT7uqViMsHBIFgW+rHnA77DCAI0WWV8RjacctD8EfM/P70txEnWQJAcX7qv ReuFRyRqN0TAIuzj7v/Fx67nKl4CkbC473cjd2EwZ0Kn2Xnb9g+LSFrO4EK+lz4y2MLk sLtXgKtweNelgj8lf4UnKcIkZLeHEi6EyqoPWVbzFlFoLLy2WQlh5F1t9rwMTgTr1Thc b0+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277661; x=1744882461; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TnbKxA6lsZP3NTEmyhRFBly3B+ZmNr9pag5vwciMRm8=; b=mGXC3APWpcRN7Pg2oRmJ4tixlV78gBh7bYXhCQmQTDGx0uKTpfg8W3fRIYVkrYr+ky Vr8yCTwr+r8kTJ4tfqBMru007agg6oY6a+JQgNQXZVOFJ8Sakze5ndKWDavarx0Xl6PT 7eQe7DCaoWgVBt7Nm+BW+29xBfVtdcuR9oxKkb85n1bArR09rO4Qoz7YVcgBvtBqaewf y4NDq2/YpRH+OJDsho3yRJ3K+20+PzUGyittDxVPX39EgRR9+Nq9I/e7CL4/1ieY3kBn Z08l+R38dVOl0J0155L4QObniBNzZemkWtROYJ0c9Ps5dDeoQrpBjcG1w9WUWb46hIn1 cIiA== X-Forwarded-Encrypted: i=1; AJvYcCXQzx6hsr51NzWYfZ6roaMouMogUmV4iqPx4B3ooBcF/PmjM+jPMTyvxY1+9iQMGAFQIqThoRE3/A==@kvack.org X-Gm-Message-State: AOJu0YxCL/e1BpKAKqUJt7zwM78jgcSXFBueT8amxfJJmbxeCh2qnQAK uXoxxOZE8zRTZjUptTzSjGnmyyU+Igrv1VPZirARcZxuTsoTsUc0 X-Gm-Gg: ASbGncsHx3W66G1CtONacaR9X6K1aD9NxeS52Y+NMM09YrSUrUPOj4l3rbkxTstZAUx HZXrYkiG6PbKBY2P4WGe3j8TRdhTtWwxFNylyW1jdcWYZTNxvYUbRGf92DLS0OsksTo9i3Gp3Od qhBMvX55j4mAU2i4WR0OI6ul0+4453OZL0JNoMvNSE4ksZQJgRXty9p62Tj4hxnWZ54Z0f4fKwN KNSTXSnhk8LFGd3XKB7nINl1+b87sBB5IGm0uxqT5wnB26y95yTnbWAW1Kat7Gs+zOfRtG915xN T4GW2NMOqMTK8ol/km4Mv8cQ6ELHHUmu2AyK5TXi9EsZCQTZhCZ3Y9HaDBVphl3tmtt+xj0= X-Google-Smtp-Source: AGHT+IGncMzME+9f61iMxAYOrzMSnbuBplArYyFnuUwO4WDMRKBFiYikSvdFy7p+n78+o5CKz5ZdzA== X-Received: by 2002:a2e:be2a:0:b0:30c:177c:9e64 with SMTP id 38308e7fff4ca-30faccbcc09mr7438541fa.35.1744277660721; Thu, 10 Apr 2025 02:34:20 -0700 (PDT) Received: from pc636 (host-90-233-203-182.mobileonline.telia.com. [90.233.203.182]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30f465d509bsm3982621fa.84.2025.04.10.02.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:34:20 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 10 Apr 2025 11:34:18 +0200 To: Andrew Morton Cc: kernel test robot , "Uladzislau Rezki (Sony)" , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , LKML , Christoph Hellwig , Oleksiy Avramchenko Subject: Re: [PATCH 2/3] vmalloc: Switch to for_each_vmap_node() helper Message-ID: References: <20250408151549.77937-2-urezki@gmail.com> <202504100130.OjlBJLkQ-lkp@intel.com> <20250409173217.ff56242a21b4edfe9ed87e57@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250409173217.ff56242a21b4edfe9ed87e57@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B66B8140004 X-Stat-Signature: 3kztys34piwau39n1s7dc5u8gfzko3si X-HE-Tag: 1744277662-149516 X-HE-Meta: U2FsdGVkX18hUXkdigDLiZzwLmvcno+6zENIxOBOUXY94O+E7mTogfNE9DD8fa43l4SlC4mPGLjjljB2S/biveoOA02Z5xsLGrfqtW3WEfZDd5ILQ/9iaivgGHT1A+Op1wiLnzkt7xxnWbOb5NEQHKjSldIl/woPuwK88uYnGYdfQ/Y62pSvhmhy8bR9evu2HrA9uyL/4bs+nYjdapkc+w+BAmiWXScXLT+tVYJDxEY/kAmCfLSZH6hDW6WzMCIgHxceIAPN45Iyx2O5aegCTkFBpWgal6qpYClFw0t6h24psRS0GCk6FAviZyLF64OOcZ584WOLyF+wtslrkHFUpSvQxOr4OC2ne5+FZLiSu5OpCl/5foJ34BcLGsGPBtVEPBMngXj0GCORH3zCKtsCW0QTFRUbYPRTpvMkS9kIPlt7hnxnU9Q7QD5QAo0/7PXRmxR7OrEHdJdks2lWqe41iwAEqBjc416sDyDh5wv03dpIospgGtgFsVpTpvCkUHuhoFm3mJKrxjK+qf+eEsb2T6rA1QyTnz3ygHS+KZaGEQJAZ4G10x18mQquCRx2nDs5COdiKg4Bg+PJOdSxat9IjQKSCZDNExAOJkK8imLH11o6fN0pplY88j+jyHAw+qXiDDmC0YjJ75PCvDqQ7pnUU4lNaZhqfC84wobImqYhHMhM/FO/ImofvkVIx8swb3HTAJucbYdeGZ+slukdvlzu+UkJKcXui4E1q5IaF/qim6ozqm4g757tyL4VF0sZzWehfm2DL7tLJhCN3rT+RFYjaLvqZ3u4NEZgIlfoDYHRAGtIf3g6ewF3Wty2LTmEBGSTCU8Uvu2BlcNpTSY0PwSuA11ESeyieP2y0Bgm+6RU6bEnOqfOFS0KcJL6uToYp1eVGQusN0eS6n9HqYo8NKR+Wdoqn9kCk71IkKFysuM9lPe4yx7zHhYiqnmVYc6OoPWeQoxi3CJwR35LTY0Sleu gcr9cmx3 G0Wkctz8TJvwr9dqwgoYCekeYJqME06dK4XxdQQtzIhyavDzgvn+ltNXqcFmiYEnrXS7euVDmeBO4wLfabRaIrQYi0V65yBUOmmHaETc7GcVXHRCZwO+dLx3UgzG2SUmVJJRNBycJGQPCRyCsjXQV9AVA0wdqyY8ogOHEXoiJZF3Pi3ZZdU9FgSzwxrsbBlWau+yy78dyqOKVVSniLDHAHFOeccPbvrcqVxkGSJ1wsC3RB5GNqS2t3pezEmcP4cPOtrw/++VxI7hzcotXAJFwF/6JrLysPjuyKpEmRt/9gLDC5R4qU/fpmCKpm8eBFSCKC7N+/VVHvwyt//ulyAolUxi3DBE9kbak0XoBMx4EtkI+JABIPrKsFt1tMr6N/H4o1LzdauND2/6aH35kICajC1FEjl3xbBQPt+sWMRpGAXJ5n6YVno75JYOp5I0Tc29bOFrWrByzl3P7gFOmzeGyoii4Vv4WrujTGaydv5Jc2OXRd4w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 05:32:17PM -0700, Andrew Morton wrote: > On Thu, 10 Apr 2025 01:39:24 +0800 kernel test robot wrote: > > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202504100130.OjlBJLkQ-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > > mm/vmalloc.c: In function 'vmap_init_nodes': > > >> mm/vmalloc.c:5087:9: warning: unused variable 'n' [-Wunused-variable] > > int i, n; > > ^ > > Thanks, I added > > --- a/mm/vmalloc.c~vmalloc-switch-to-for_each_vmap_node-helper-fix > +++ a/mm/vmalloc.c > @@ -5084,7 +5084,7 @@ static void __init vmap_init_free_space( > static void vmap_init_nodes(void) > { > struct vmap_node *vn; > - int i, n; > + int i; > > #if BITS_PER_LONG == 64 > /* > @@ -5101,7 +5101,7 @@ static void vmap_init_nodes(void) > * set of cores. Therefore a per-domain purging is supposed to > * be added as well as a per-domain balancing. > */ > - n = clamp_t(unsigned int, num_possible_cpus(), 1, 128); > + int n = clamp_t(unsigned int, num_possible_cpus(), 1, 128); > > if (n > 1) { > vn = kmalloc_array(n, sizeof(*vn), GFP_NOWAIT | __GFP_NOWARN); > _ > I was about to send a fix for build warning. Thank you Andrew for sorting this out :) -- Uladzislau Rezki