From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B6CC3601E for ; Thu, 10 Apr 2025 08:52:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37EA26B0303; Thu, 10 Apr 2025 04:52:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32D576B0304; Thu, 10 Apr 2025 04:52:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21C4B280064; Thu, 10 Apr 2025 04:52:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 049416B0303 for ; Thu, 10 Apr 2025 04:52:13 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DD0AD1206EE for ; Thu, 10 Apr 2025 08:52:15 +0000 (UTC) X-FDA: 83317517430.09.A40DABB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 428D514000C for ; Thu, 10 Apr 2025 08:52:14 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="eE/YC5E2"; spf=none (imf09.hostedemail.com: domain of BATV+8af77f6ab8959e5caacb+7900+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8af77f6ab8959e5caacb+7900+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744275134; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w734qNmfPjjUyGK5AWYk6ZTdyX4jI/1lrU4xryLiCiw=; b=ZE5A58z6qUEu/J/Vab04GhGPUgNBdGdgn7+WjWAeESRzhRWHrcUhtvpB1xnV9qZOR/5mZu IEOtCQ/owOAzQAdJeFMecH6Br+/VOjNMGsYman8KUT8bFyGIp8aJpmCneu4wbn6dOgiUkc aSjNeERhqTGO6tyH+bvnR+Q94x7G91U= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="eE/YC5E2"; spf=none (imf09.hostedemail.com: domain of BATV+8af77f6ab8959e5caacb+7900+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8af77f6ab8959e5caacb+7900+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744275134; a=rsa-sha256; cv=none; b=VLWOowKB70ZknjtvkaCt1NRVmkjN71xHOcJ8J3TXCkWwDEK9OJpqeh2dr4rGDiCJ6vTZL/ 41mXtVUA937aYbxIiLvzgiJ/dBgS4OVVC8DY7WY94xK3Y+2f/2oQcgpNFVk/zLTLqZuS5N nu7NrKijTZ0phXF3hgKpZjzYLGCvadI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=w734qNmfPjjUyGK5AWYk6ZTdyX4jI/1lrU4xryLiCiw=; b=eE/YC5E2w8IJoZ1kxYYSZVgzrB Q53hcFgxyxr4xUIElq7H8YiFX3SuRuSYIDEwc0fNqiBHzWjuVCzDP5l0g6P7kx74Q69Pp/Xwq8NNz x2j/rlIO63W1W7Gom7VYfDEg/1GD7yVgxiCpOjIxKzvxMvdJNjD46EheIuUsc7v4Z4ntunVg3dUGC 3GTiiMU2R0DEXNZ3EhbvHpqqlNAj/UxeY3qPOlK7wKZm/mhq/jhgBkZ+U1ublE0T454IE0aneSmhn 1Cy6XOP3J35VJWgJK0NPiOn51jKZXn2hC7ezc04wpbevU9M2HvlWZSjUch2JM5cRXItB47IeXroCU LVQI+ZJQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2nds-00000009osm-17wQ; Thu, 10 Apr 2025 08:52:12 +0000 Date: Thu, 10 Apr 2025 01:52:12 -0700 From: Christoph Hellwig To: Andreas Gruenbacher Cc: cgroups@vger.kernel.org, Jan Kara , Tetsuo Handa , Rafael Aquini , gfs2@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 2/2] writeback: Fix false warning in inode_to_wb() Message-ID: References: <20250407182104.716631-1-agruenba@redhat.com> <20250407182104.716631-3-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250407182104.716631-3-agruenba@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 428D514000C X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: njcphurcbnp16jp9t4uzqk61suxxq1ea X-HE-Tag: 1744275134-579717 X-HE-Meta: U2FsdGVkX1/YwFE53VEAUFrUq4HRS2wLCR+etEdeNHjPjN/viAsXjVVuoAPJJgcA33xa80Xpexj7kIOCWYSeWF49ZbHMbAryHcu+PoiwDNvyZFZqLQN1/RKl6DjwFdt55GnVfFdcuuDBMjcgxDGhthM1O1EgpqgPx/K4hNBlieZb6O4v0QibFk3TngbnRBpO98Sfi9ZidghkjuWUkn8eVpzrjH51UkYVKo1barkeqZ1Z0PADF3FB9qP3DpT67aRIjnXVZG6NhY2+cvQWztfFIZQlA9jpexZm+RZeYWOW1X5NJJMt0MNKXoTZlwb4tYo+QliY2jiEoiOP02BeXmZqrnEoQcJ6nezw/zsO181CboM5qAGAL4N4v3RdpFH7bz1/6o3d9l/8Z+iI9pRYG3DzDcb3eMnNX6wKcxbbOkBZMvn4N42xv+8Q80BzJV8sGUCP+gxMwTLSLsac8S3CT1oYzSh+LlW7bcMm1h7d8Tzs8VbZjrGHl6hjQBvWt698KYfOdbpyPHzRmnP+LZRoUmSAGej0ocjue5fvTeDOxGBJbcmFKJHih05Q9qOyb+KvL8fb9eo1iHEK8/XWE1xfEY7Dq3nO1BMgtEeaigsCoCXoBTxqlAmZ6URkw+4M9eolkdiGF7PEMRlZCNtkMldUEIyZovcXmQYlEaqYmpRpaqEmSvkuWOQeobrEyvC7fGukLZGicgIeujYNaeKL2SyeIE7yMvQzG626vCzok7q/1PULTNnJ+Yx+peTwu+WodnjnA0K7651/Fi4NQMlGaYrsyLwEZh/G5gkuBw596ka6YdBtFodwsYdPBRSfb+wxCBMzN8awI3Q7EDDCyD5243IX3sQe4nXEdpJIeC+OfOTugcym+IXFpX1E+aNGWJvbX6yXJzxFOEI9EYFnlKgt/JrsNtJWMPgQ/mSo9U6nZFAuDxO28w4Ow1k67FZIxEDxkZix+ldyMtTthClC1f/23On67iI BlZ9hXBV rUPMPKsZAqjyqppMY/UlwNVPTWEdOEWNwbty1q2tcqS7CFHhn4ECThuX3CD7cfFFnWso11QJOKzgAXLP3sVL8wEG1L1+VlgUwWazfN7tcl2n73DTBT7j8iSJByPzQMuJun50ri7GCjzbvj0I5Mvhm0x2dV9CVQ6vFlSh2D0BXUBl71waZLRrq0jLsCvsh/L0eAeWbIo3Mli4KXvS4z61gxyJYslhgf8E8L+cCo9Uz5CdBLElh/iLHQgGpNkNCymSmUzF2XcyVnIxomLvwEE1nsZ1vJAH3G57ulomYXaTr67+7DEz/OoxcqyfxDFK1jwHFWG5Y2MGFIEw/6uaJFzrbLgT/ZmaGl27AOZU4FGrPLpflFasejuJ5a48dXz8Szain4YpH5XRmVAm8rr7vI0GJXAfwEcK+rrt0Y+/EWxPsOH6FaFdhkUK9p8b58KKGDrr/wlZ+4jaWoX0kHCy9Xf3vmdAIjCrx7arqh8JQ7jTHGyRcfMr2sy+u+WJUuwHCJ4Veuf0HSbk2cgJXpzFcQsk3j1zKCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 07, 2025 at 08:21:02PM +0200, Andreas Gruenbacher wrote: > -static inline struct bdi_writeback *inode_to_wb(const struct inode *inode) > +static inline struct bdi_writeback *inode_to_wb(struct inode *inode) > { > #ifdef CONFIG_LOCKDEP > WARN_ON_ONCE(debug_locks && > + inode_cgwb_enabled(inode) && > (!lockdep_is_held(&inode->i_lock) && > !lockdep_is_held(&inode->i_mapping->i_pages.xa_lock) && > !lockdep_is_held(&inode->i_wb->list_lock))); > -- This means that even on cgroup aware file systems we now only get the locking validation if cgroups are actually enabled for the file system instance and thus hugely reducing coverage, which is rather unfortunate.