From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D75C3601E for ; Thu, 10 Apr 2025 08:42:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 129566B0174; Thu, 10 Apr 2025 04:42:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 101C36B0177; Thu, 10 Apr 2025 04:42:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE1A66B0178; Thu, 10 Apr 2025 04:42:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CEF286B0174 for ; Thu, 10 Apr 2025 04:42:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 881971406B3 for ; Thu, 10 Apr 2025 08:42:09 +0000 (UTC) X-FDA: 83317491978.20.2CDCDF8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 4C0291C0008 for ; Thu, 10 Apr 2025 08:42:07 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=N3Ua8kfb; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+8af77f6ab8959e5caacb+7900+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8af77f6ab8959e5caacb+7900+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744274528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CdU/+uF+1QwwmbOg7lgLdyQsB2ocHXgyQIfpYxGq9qI=; b=SoXOFsYG+yfR5EzbvvX4UCv06o+PMtNWnvPSbo+Ur2Xzee0Il9xFPtZqM8amHbqT5jbcuK eF0yQwso7K7fCYLMbzwnGm/vIIsU+UovARB7Tt2LsRGzsKjaH3qXZl7fiN0ecV5/V0ElwD xZb/BboKrqpxsW5KROqnzAbZJNppNFg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744274528; a=rsa-sha256; cv=none; b=EAYzjPwLNqE41z92XqF2a21lgGHv1pywORtzWv77UOB3WlIOS12xz1KwiNR/By6ZcPrDvt vQJ5oITl5sdUo5QXq+NLp0PrurOfrvx9IMKMtrS3JUYOwhutJuNKv40uOP5rDhobpxfRWj JpSdkkMJDmhoWLQ9f40bheO4T6CVKuI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=N3Ua8kfb; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+8af77f6ab8959e5caacb+7900+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8af77f6ab8959e5caacb+7900+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CdU/+uF+1QwwmbOg7lgLdyQsB2ocHXgyQIfpYxGq9qI=; b=N3Ua8kfbKXQSsTiia3Fjjx8Se+ KvkXrtS7Yyu+JaDA+9J0jEqnfBSpI/VZGPeVPzX3rw3RUrNXjz8hu87tGc+Jzuah1GTKfd+n8AD+S oNzYZWySn1r65SV+spNsSSDSnqRrrBnFKsdOGHIZOWn4nlZx/ucoOSYOOokHwpROZJ9nRT6SXiM75 m0cXSqASn9T9rvU8TB5N+V1uDPZpRwUcnBZ15CXIB3mjmOZwWIPwT8eB12zsKIFrJ0QcrSDTE33Xc RDo2Ic/27KAibhFQWRofsYT1msrs5vtYVppIU6sCYeSNHdsg6wZKSawW94fASdAs3kRyH9mcEoNY9 g98HLiTA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2nTu-00000009mmb-06hM; Thu, 10 Apr 2025 08:41:54 +0000 Date: Thu, 10 Apr 2025 01:41:54 -0700 From: Christoph Hellwig To: Shivank Garg Cc: seanjc@google.com, david@redhat.com, vbabka@suse.cz, willy@infradead.org, akpm@linux-foundation.org, shuah@kernel.org, pbonzini@redhat.com, ackerleytng@google.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, tabba@google.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev Subject: Re: [PATCH RFC v7 3/8] security: Export security_inode_init_security_anon for KVM guest_memfd Message-ID: References: <20250408112402.181574-1-shivankg@amd.com> <20250408112402.181574-4-shivankg@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250408112402.181574-4-shivankg@amd.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4C0291C0008 X-Stat-Signature: 9r4rnnijxzeq5yrw3prsxc7ouucoxpnd X-Rspam-User: X-HE-Tag: 1744274527-572833 X-HE-Meta: U2FsdGVkX19RNfeagyHe+DyVukSoErvkxOYZ9fcn8924LSla1k5JhUMvbxnOltpbKxR3EhfWJiF8RThf7LBmtMIiHDAAH29WvVdDRbq9FJsrtL8+QTYPaZ+GBykJQhCkqvAOp6qhQSIXRrJ73leMLl8MSGKAL5hAjB8a0CLeOIMLIcIvdBzmghp9yqod7uYME0RX48+PpU/5VBMCNtzQt8rzyUfV8gvF22WaSJcT9jyiQYFVZwdUjJifhdqG0VnaKz6+uQpR+z3Q0Th6jiVH5JeG2hami5uweVKsq1izdOPoCX1lDqCykmid+gdxdozfJigsdMcE/jZoThz7pez8iILUIVzEUxB5nSGpPI2XURNZrngOXsq60ALCNGTCBjAOywUDScQCxEAo0dAr8WYAX6q/843Lojv9hkq91cnpkwNEnJKZmmGlrGQ5MDgPG8ZI5qxvMeHkdpqTCkYOAVGsz+QYvziFqBKoN/2r9qUKF5WOloHXP4PwGy2pZtbIJ3dVhJy/v0fULauDC7ZQw+mISMQEnPeKLZKAtqHrFXlTAi1DtKb+RkzEt0uunp6TSuiOOlzrkdpvcRGSXYXWXIMp/Mh7ZbcZygak0/bC2/u/IDKWWiuZinNc/TkKJBVSAd8+VxfFh6TzO5x4ghqLKQk/HU9UtmrVATMZjfCMVfAzaxbjM1kzTh8lOC/BfrSOnnnzxr1mY+MO8oSRdafAOJoq6d0JhRqNYzF3YLjj2VGfGv63AGq2M7DsEWw5UYonx2H+Zk6FBXy3fwVrqtlEysdMx28H5qFqK/X72BYMwK4eR6Rh9jw9tk5W6sLPm2p9H9y8xrwxYNWfd/F4bDTVaUgAGonBv5caIrqTo8N6N39y4jgzNVBFXOPXNRrLFfH2XnbbNb5KqUM/+ho69SLoknAIVzUvQm1n+6f6feYRyj8PD2uUrNvhvZC3a+TXMH4dkE5ZcXC7dyN4J0MLx+SIP6I CX0xEGPw yuMWx/wwxTc9+0U5iF8tExSpY+27j6etZ2/YfeCmiBCYN4Dn/NPLw9bVJOknYG9Ddr4TFVr0hzshfkMot7k99+kep9mpTBw+arImCLKlOezj7Z3c/RXSFZMdrmRKp5KsdZgwtqKNv7pND/22rxU9xSa2A0J+KY2djWsE27fV60oeGyafmI8P7+TyvDnFI9z4tMhH/NENC5Klq8W3W0j6981nakK54dxN1B8AZfwZalAkuC6raVpCxD0y/LnIuOXNs0wdi1gHXPOf9V/cHpLmD6hC06j3QpF4tvvOrXtOhNgPfzR5iCWIs8k4KPLq68TEGWyr4pLX6XHeH/hdjTqH/ancFkzmdgLdtiQk7osIxiA06s0Q/7wjDB6QLRV1KybJqUFVD7t/VQ7rzmFUgOwT4LC5YIZdmgFHF5GVYVWNqhAt9y3PRUrIm2qVGCIQvDqfXPLtrfx8EnAnwCfxWHArrVObfEpPPswDOTB66gUPDScVKX0XIbrO+kR3SRiowhG55DY+B7tOhWy5wLsTrBE2B77eDNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 08, 2025 at 11:23:57AM +0000, Shivank Garg wrote: > KVM guest_memfd is implementing its own inodes to store metadata for > backing memory using a custom filesystem. This requires the ability to > initialize anonymous inode using security_inode_init_security_anon(). > > As guest_memfd currently resides in the KVM module, we need to export this > symbol for use outside the core kernel. In the future, guest_memfd might be > moved to core-mm, at which point the symbols no longer would have to be > exported. When/if that happens is still unclear. This really should be a EXPORT_SYMBOL_GPL, if at all. But you really should look into a new interface in anon_inode.c that can be reused instead of duplicating anonymouns inode logic in kvm.ko.