From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3014DC369A2 for ; Thu, 10 Apr 2025 03:49:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A10D86B02C6; Wed, 9 Apr 2025 23:48:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C3066B02C8; Wed, 9 Apr 2025 23:48:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8148E6B02C9; Wed, 9 Apr 2025 23:48:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 611B46B02C6 for ; Wed, 9 Apr 2025 23:48:58 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0A78F5C2CB for ; Thu, 10 Apr 2025 03:48:59 +0000 (UTC) X-FDA: 83316753198.27.5403B9E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 731CE20003 for ; Thu, 10 Apr 2025 03:48:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=t2tqz7E5; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744256937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NuOHOihSdxAhAsOO7Tz+6Gqb1rGv1U6I4lmfQywOTZ4=; b=BYDPCOiCwNEdjVyr5rajNyda3Fgi8B9c1yDrlnZS28e+7ZXVW5s8IhGICYLynez0UHiJSd ipbvzY20sRtqeVHAjRZI+6O+1iur4Cai6CS+gQOQnRg2+7okKwWznYdxbDPKyp58lY1xou W9KmcOtbKs9JXCXO+ZCuN9luKu2gXzo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=t2tqz7E5; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744256937; a=rsa-sha256; cv=none; b=f+49BAjUtjRo2sD/GY5sf09xCHQb06PEoXArMVtj7YHzpLlqgz8pZLgZP2fy+bvdnnTduA IwtHCcg0wN5KAkZv5+UFWkoK1DEYp5Pmgvd9bY7QO8g09FIytPj2oitG9WiuOiIzf0RjEU JEx+5esS7qzebWV/V8OQoetbRNKhasc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NuOHOihSdxAhAsOO7Tz+6Gqb1rGv1U6I4lmfQywOTZ4=; b=t2tqz7E5cR7z+IdIdciZ+gvKZs kpf70PDcKWItZEOKfTLH3K2wQK7vwM7VfAYpihXk9e6grsGMmnS0MFzawQjijq/NNgeE6Rc/mmDE0 N17FZF0VbTVNGsc+OwveqqOyfV9XC7tsjZxwI9j8J2cHHlf8zt6hYF7Umo3HcbwmT+R0j7jfmoZEv zxOZ1Pmwqome1uKVwgxFrtGRIt6XacblMOoUzZoXoQ63phHBJyai23nF85fjJ838ZPQYaED75EfyX //QKEpNQQp/iJ5oj+o68o+gIm/mn3aMdyBjrAHBWNqI0gQ/Zudiw5kcEy0FSrWZXgS1BE8fr9//U/ rTK8QiqQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2iuI-00000002LEs-1tS4; Thu, 10 Apr 2025 03:48:50 +0000 Date: Thu, 10 Apr 2025 04:48:50 +0100 From: Matthew Wilcox To: Fan Ni Cc: muchun.song@linux.dev, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb: Convert &folio->page to folio_page(folio, 0) Message-ID: References: <20250409004937.634713-1-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 731CE20003 X-Stat-Signature: q3nuok9yusawqsoc1ya88zj1rs9mut7s X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744256937-110778 X-HE-Meta: U2FsdGVkX1/dpSnx30R4/HwUFKmZDVkYyHBplJjKO/eyXvYCo8RtYUZpDF2cdpkvv3jsWlG/mam25UU6CacbnudbZf/Rl9pqQ5wdnNsVTSR/L+azvvcdHT8jYU1Eqnf8CqPN42lgd0mAY9RkD5w+16hM22Q/jWFXgoJ0VYFaKmW2AzOlG3AeaL81C9adYpB6ad508E1xa24++giLV4rszrxe5xk3AfGd6Q4KY3JqiMb/Hs7Kyo1aetXlKlgnc3UOKinY++98vR4wLl6GLOeqCMdehDM8sVEa7cbaEbl3JmLZVa75qssX+EIyRb6gEC6GnCRc/DOFZG16R4xonL14ATWTUnuiVSHrDVbVg/8YrGPuKsqs9qy7CkVCZU+vnMhyAVV7r5Rvan6i22JfykiiY6bnBe3czRNx3FzLC0VBhgjztSqP1iI6tHlH6zX5CUWlOmqe1jl3gzrIYILKslemngU/uy2iFAwQHRycC/jGcDylfx4GF635V3kiiUdjfzIEaMr9bA2cWTQqULROZm4Kz2lm9qWEeCK3NXbvZufNPCuObAw+QFHLYn52X50MG26z9HAqgUe/8GzdhrmHjoq0RHzFT2Y71cA75x9NpdJqveqLf/1t7KqxoRroMs9aTaAopF7IaG8jeZYkQs3eYxYqBBHqWuYUfxLKJ1jnRhx5I7OSL1igIoD2e39BTGdFW9riVTAAGiTybgmXQGWT61kMyviyTiVb9ZbQWK4kGWPn6SxHTscd6uy4L8PK/oljs8S628M9UEdyiJLEkELj0ZTMKcKCQg4oPDPmSwgobYuIuZXLle9unW76CFhbg6NzLYInuplQBTFA0TVCNGBystvnzF7X88TkngAr28t+Y+I2BaADlZfN/w26FVkEMmjhYZAfMDB06xG4Eq3KFKOOceMV43RrFCBL96WacpKLC+rSpXBqFIcWFOpxTqrzKEsfhVoSzxc2J4lh0m/9D3g4NAm ApTG15bB 1Ipop/qhjQxaC1k/zpCItJTFD3VA9U9PXflYLQKL7WxGFC7EWMoykz22tuUAAd51E7QErybyfNVa76UqtajFj44cqPYexKToC/bxsLO5gqDa6e3GefFm9dw2urC1UGu6X926q/pMpuYV9Xk8Fruo7/LYemG94X4cU90wVgvZ8XXYrr6zxLWCXgvHCz5x3NiOxLumQfkD5iPoLwO8JJ7KHcSxXFsaRhbD2TYi9egnYdmOWo2Kf9z1wo712TUPXnS+R/oNF0v5uZApQ0YJUro6HtCxl9RDX0T7YaM/tYvaczUUQwxTfGbStKiuj388XU9VCrWc1beCImGGzf0hz1u4cHmwfakz+8i+LJ1BYg2DdG6+zS7PvP3CYdd4JMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 03:07:50PM -0700, Fan Ni wrote: > On Wed, Apr 09, 2025 at 04:15:30AM +0100, Matthew Wilcox wrote: > > > */ > > > - free_page_and_swap_cache(&new_folio->page); > > > + free_page_and_swap_cache(folio_page(new_folio, 0)); > > > } > > > > free_page_and_swap_cache() should be converted to be > > free_folio_and_swap_cache(). > > While looking into this function, I see it is defined as a macro in > swap.h as below, > #define free_page_and_swap_cache(page) \ > put_page(page) > > While checking put_page() in include/linux.mm.h, it always converts page > to folio, is there a reason why we do not take "folio" directly? There are a lot of places to convert! $ git grep '[^a-zA-Z_>]put_page(' |wc -l 472 ... and that's after four years of doing folio conversions. free_folio_and_swap_cache() should call folio_put() in the !CONFIG_SWAP case.