From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F24D4C3601E for ; Thu, 10 Apr 2025 03:19:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97CE76B02C3; Wed, 9 Apr 2025 23:19:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92A7F6B02C4; Wed, 9 Apr 2025 23:19:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81AA66B02C5; Wed, 9 Apr 2025 23:19:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 656166B02C3 for ; Wed, 9 Apr 2025 23:19:06 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 77B57AC801 for ; Thu, 10 Apr 2025 03:19:07 +0000 (UTC) X-FDA: 83316677934.03.793F970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 4BEC3180004 for ; Thu, 10 Apr 2025 03:19:05 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mCEElIs0; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744255145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ljKJOmsWbynBd4FZmekRdfQrkUbaBvmD89GjQhG0uSQ=; b=KbUNNVkpg67r3V7QVE91iPh6jGcGAPQ0m8A2+5a7GKJrQ2aXx57Kdw2nZOALWeZaOAVtpa EtmwJ3clHgPKsmAQp0RwAsWrDkaXEyqHHg126xTCfLTm/DD8cMwmp+Ogt+Z4X6XgnIId3I pX+Kr+H1JTLT8T55pHCOLVWl1UyoYVA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744255145; a=rsa-sha256; cv=none; b=d7+3eQSTwjBDQeG8LUvy+SARGnIdJNP2i7lvY+SnewrXa/dMsNU3ovo7a4DK/vlxqObGL4 NuZ0cNh34wGSwfFOPNZx6PgZrr+7iRRlu3P6k1PE+leU5COp4p7+3OeqGh81d0J/mCXVa5 Jq/YIyna/+7/kfZ3c/mByotvPeFAcbE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mCEElIs0; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ljKJOmsWbynBd4FZmekRdfQrkUbaBvmD89GjQhG0uSQ=; b=mCEElIs0+DTDV1eWLUS5E0AV8R htQrK03I82aCZqN+M+naQeahCg6yyCX1lOVqwE2ETxdfWtgwhqNPU6aj6aIn/7AsCSKql0y4gi4PH fg+WELo9aqTGP5UYddpzzl90Vj2tQYjyeNcS7WusDxzKS9aSp0ilHwdtmM5dBb78lPHAJKNiYTprT m2ZCiFf6d4qK4wvzNFrIFa/HnBbWFkzbuVbLuUSMYv2UMZGTP6Qvz94SXNmEFOJA9sBXa2ouIh+0h W2VOuruSeS2OE2BvNcQ90SAlj+IWck2DtnUjo+KHFLd8zu2p1+E2nu5QwwVcZdqZkB3IGnyDwjQi/ QpQkB2GQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2iRF-00000002Jfz-0HTT; Thu, 10 Apr 2025 03:18:49 +0000 Date: Thu, 10 Apr 2025 04:18:48 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: brauner@kernel.org, jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, dave@stgolabs.net, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, syzbot+f3c6fda1297c748a7076@syzkaller.appspotmail.com Subject: Re: [PATCH v2 1/8] migrate: fix skipping metadata buffer heads on migration Message-ID: References: <20250410014945.2140781-1-mcgrof@kernel.org> <20250410014945.2140781-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250410014945.2140781-2-mcgrof@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4BEC3180004 X-Stat-Signature: bni3iyk8eso6js6kk7eeb7kimwht86jm X-HE-Tag: 1744255145-106527 X-HE-Meta: U2FsdGVkX1+pt/fkw2j43xzSnC2nx2TPMniI9QfI/g1ZnxWCR5YCEdKbGQrViA/OXE6wvPYlfXjI3FY/7rzcxPP0GQq0wXBm6L4z7piXy6NUQ0+EDSkvkWMBD7qIOedllFoabwPMr3/z5hJnCmvvwtx+Y77qdYgpDvJbtKYdfDQBiWV4Y8rC6vXQiD/jfP3toNHIzN35aNJ/65Bfpllsok78Jzv6hst85sA/SHoM/MiUXvYQ4mfF3Wc7Hn7sRGwR3a6wr8ASG4GdRdjKSQ4irTivy607zR47e3ZSo842n2MmUqn6JMof1mb6vedxjzsDCQdeSf2Aqw+rduHnUvVo2wfo1fgmrpxrXdzj5NQJ+DNCuDbYIFnu6Tt1QY8St3aBEvc8yem3ZSdcZCPhlLQFbXkb14GPGWUwAVlp2sUo6IJ3zsVQQeK+SbvXq8MfiIregOwdPTMlt/VvA/ylPslzkdYk3UuFWa+lBnw3SQbqpsiCqiMsMr4h2t5wmxHviFmmnrTYJ82zJGY1TzHqlxDqTTK3HdJuIjCxNf043abXqUK/QC4zW13m2IH3iFWL1gN3sXI0Ik8MDgAYir4h5th8VMicsU4NVS4hZdcbaLJo0wOPJqDkj4syHegp5a9M4G/hBJ2/mFP1MPqkvnUJumNn0cEHW3viIcNAaKGWJUfhfxqUSkwRordMFdxtvtRKL+eB0XHr9UBG9kisYwr4WUDkj4tlcgT6z0i7eLX5Y4KNax/bjHdV7EBhuq+CrxZxQVo2ghw2nICY9yFV5wweYM1OT4k6OadulqALpWEoYsj5EEW76L8f9UOxqmxI6S2XXNwwBq7eAdrPZ30UJLaG6G6ryycy6R06Lp3McX9s1mkAJrHVNyTWFXPJ2puYOjrG7aqORMt3/K6+WNERoa8LkFxjrvilnQ1wkqGLscEBKZfr8frONNj+OULT6H7HyjXvEbTSTlwTG0OR7PSZbK2GkM2 BTEz47z3 ti/OSZkxxAZXVOu4g5BAFq5nSsO2Gf6zu8UwRPx5y+5xHZ8wQNlWGOtJecQavXPHAw0iYR4OL6EXQlZ64sdBC7732ESiuFg/GvmTAfPDkcwyAeChyNksxHk1XuG81oZDLyWYDrfiCWM/pYOYFryVKWH0xciYkalX847KeWyDrhIt/7ICDrt9royi835vgeeogtESynIva8rIHIvciA0eOK0UtWP6IDIi9Z6JsCwVa+00vBuUdrZHntCkjKhSHcYJe6jZXR25FTOc/CV4UZ0U2wWprPha2jtXb4KE92rwwD0/68AGKpVCspsOYZx/UaSU7sUs7S9rM5w1kvMY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 06:49:38PM -0700, Luis Chamberlain wrote: > +++ b/mm/migrate.c > @@ -841,6 +841,9 @@ static int __buffer_migrate_folio(struct address_space *mapping, > if (folio_ref_count(src) != expected_count) > return -EAGAIN; > > + if (buffer_meta(head)) > + return -EAGAIN; This isn't enough on filesystems with bs