From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D987BC369A4 for ; Wed, 9 Apr 2025 16:58:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF2916B0156; Wed, 9 Apr 2025 12:58:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA0FD6B0159; Wed, 9 Apr 2025 12:58:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C418B6B017B; Wed, 9 Apr 2025 12:58:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A53B26B0156 for ; Wed, 9 Apr 2025 12:58:17 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B026C1A11BB for ; Wed, 9 Apr 2025 16:58:18 +0000 (UTC) X-FDA: 83315113476.01.1D56526 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf20.hostedemail.com (Postfix) with ESMTP id 635881C000B for ; Wed, 9 Apr 2025 16:58:16 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="nG/KNcwD"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VryLfxF4; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="nG/KNcwD"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VryLfxF4; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744217896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+/yNPsqF0kJWQivUHk1FCQy7nHAfxv9twVK6iPfPrdA=; b=qlfpT5vFgpZ3bswCDzCROkofAD+SOobOQR3zhNSpAVDVz6A8fC4TQgHOzYsI9sHoFuNAj8 qw9DkIoMrENnEwe8qpGZZ+C6glVkJ3BEDdD4lIDSEfOpWs55CN+OJ8tkreGsGqe/2oi8rL rx/gb1x2Ruxbz60wEFOZzyTYmh36e20= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744217896; a=rsa-sha256; cv=none; b=pvScBOY97lRjBhKhQBazig6+eQLnG/OxI9XU5+1vWMCcrNaDHc9c9SBZEM89ADfZxtcWTb MwnRH2YTj6+Ja6DIJaEX3XIfBbV0DZ4gD6AGUGtvtODa9a60c82xg5g2kYBtxstkD5mdAe xbZIPHaJMvE0ypHs0Po3+bh4Ze5Nsmw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="nG/KNcwD"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VryLfxF4; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="nG/KNcwD"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VryLfxF4; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B38D31F38D; Wed, 9 Apr 2025 16:58:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744217894; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+/yNPsqF0kJWQivUHk1FCQy7nHAfxv9twVK6iPfPrdA=; b=nG/KNcwDcIsW/uK7FgBg9uFMxMMbMdgKZGFJqQD7g3wxCWGMXFZwgwtXesBnup+RsqLqjh +FRG1uXjzuimm+0liQYvoojNFFIlZIhM5CCcAkay3Uy8mKpTc2m0Xqef4ONihrRIASiy1X WUddoKC3bIXYV2Cf4/3E38RbkMLK8IM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744217894; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+/yNPsqF0kJWQivUHk1FCQy7nHAfxv9twVK6iPfPrdA=; b=VryLfxF4k3vzxpwJSDcYomsatCSdfnOM2r12zx8StboxFOFWYF5/aLUivSLmH8VjfTuPrH PIRVX/TDQI4iRkBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744217894; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+/yNPsqF0kJWQivUHk1FCQy7nHAfxv9twVK6iPfPrdA=; b=nG/KNcwDcIsW/uK7FgBg9uFMxMMbMdgKZGFJqQD7g3wxCWGMXFZwgwtXesBnup+RsqLqjh +FRG1uXjzuimm+0liQYvoojNFFIlZIhM5CCcAkay3Uy8mKpTc2m0Xqef4ONihrRIASiy1X WUddoKC3bIXYV2Cf4/3E38RbkMLK8IM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744217894; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+/yNPsqF0kJWQivUHk1FCQy7nHAfxv9twVK6iPfPrdA=; b=VryLfxF4k3vzxpwJSDcYomsatCSdfnOM2r12zx8StboxFOFWYF5/aLUivSLmH8VjfTuPrH PIRVX/TDQI4iRkBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 15B9013691; Wed, 9 Apr 2025 16:58:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ot2VAian9mfLAwAAD6G6ig (envelope-from ); Wed, 09 Apr 2025 16:58:14 +0000 Date: Wed, 9 Apr 2025 18:58:04 +0200 From: Oscar Salvador To: kernel test robot Cc: Andrew Morton , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , David Hildenbrand , linux-kernel@vger.kernel.org, Vlastimil Babka , Harry Yoo , Jonathan Cameron , linux-cxl@vger.kernel.org Subject: Re: [PATCH v2 2/3] mm,memory_hotplug: Implement numa node notifier Message-ID: References: <20250408084153.255762-3-osalvador@suse.de> <202504092104.MyHeSV43-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202504092104.MyHeSV43-lkp@intel.com> X-Rspamd-Action: no action X-Stat-Signature: g4g9gh8am9pgq9ad8gmwhzr94nhg3kom X-Rspam-User: X-Rspamd-Queue-Id: 635881C000B X-Rspamd-Server: rspam08 X-HE-Tag: 1744217896-88859 X-HE-Meta: U2FsdGVkX1+NHMrejl27Kr1EuelOyzSOCWAeBoAYeCAb4+K5e3LTPNlalGGDBcujJJL45yxGcUOTeq75zEGlc9eXMGjiEpRzztNTJj8z9TOAhWBfvVVrRniwIsill8O9GvypuxMcaYFl2XZIo+kMzNxl0GvndZcfiXvpXkDhD+F6Sx6pObVHo0Sf8TKJ9B06YZRMIhoeZCcQe+bcrOVMSw8UxYe2i6Zp0q7hEw7BmORSxCTSaA9L6i4of9+4WJAloNyge+q9OQxSI1VgLCd6L4+FJhmMCUfvzfrF78rnvouzTiP9ebFNBz3JsHAEGI6BVahRQvzb+EClAZTYqW/RGZ42HKSI/NflGC+EhDIGqerbCwezKQXLauKwQ8YxX3E2pDr2STWq9G+OEiq1KgbL0fiukKsm4fprvu/pGe+W7SLcqKPmIrIWOFdbu98RoFkCne+KTgD4Wg62A+pOA9YU/+C8ZZsYnfVtwBRoYaRvg6VY+Ls5x7X1y8ALXbgfobCMIGQkZ04lRfgW/psDTUAlIuDfmhYK5rhxxkxAIRu7RESoZn1SyauHZB0sn1e5cFG8My9YXF7JT9Sadf7AO8vdLswoQ+hLcIlcmH8P7QqUvbExE+zCmc+67XPNeKKYuQmnvQWi01ysh1Dt4HtgRKmUWwAXTqQQYt7gTMHwNIUL8CPx207jFODaD7zt0HPvGqx1oXogHFOWeD7D1jGST+6hSvfDtaGXIQ2UMt99B33GAG3E5xj53uRskkq7byHCD87SVZgW4hlAaOVIiuxtMRHV8gmY0bu1RhRV61gOgUNrJ6/3Subr9+0dtLFhoLNz4PbkySmFcMMQ4iepQuFk7b3pe3vaYzZW7pChwsLpGVXKFODpdXmslqoGXMGzuwOIkAsO/m1KZJShUmKLdoVF7Kd+Zm3tTloNwnCebuZqjs9BD7choYX4Ake33Ijr+eEkM3xP9F2wB/cJ1RM2s/s612P RPWVX8Zh SG/C+HXuFa7C0HGzJWOtzcbNdu66awzaSf0/NW2aOJ/4Lw+vGm9ljefaeiNmNKmIffqBlNYp+4lJ3ewN7G5Dbwwwi2QLSddt9Vqz9YA+uoVKHhVHe0Opq1yllVM5iyJHBfy/e3iHV9L1Gle7dg8tH8ZkidJd2zUeGHyYhUO4EJ0I2/oQQVhfoVGXKe2/Utrk7I2yH8M3jdDBVQlgA+HkfCbvLpXfFkyMyfEzv+0QHmjpIY3BBgEjclHCO6Rs5OYIBu+R0BgljEcVVgxoZHg2g58fwuUIzwGSUiIvXln7la3BxAlNsLMj2yAWmvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 09:44:52PM +0800, kernel test robot wrote: > Hi Oscar, > > kernel test robot noticed the following build errors: ... > >> drivers/base/node.c:115:5: error: redefinition of 'register_node_notifier' > 115 | int register_node_notifier(struct notifier_block *nb) > | ^ > include/linux/memory.h:172:19: note: previous definition is here > 172 | static inline int register_node_notifier(struct notifier_block *nb) > | ^ > >> drivers/base/node.c:121:6: error: redefinition of 'unregister_node_notifier' > 121 | void unregister_node_notifier(struct notifier_block *nb) > | ^ > include/linux/memory.h:176:20: note: previous definition is here > 176 | static inline void unregister_node_notifier(struct notifier_block *nb) > | ^ > >> drivers/base/node.c:127:5: error: redefinition of 'node_notify' > 127 | int node_notify(unsigned long val, void *v) > | ^ > include/linux/memory.h:179:19: note: previous definition is here > 179 | static inline int node_notify(unsigned long val, void *v) > | ^ > 3 errors generated. Ah, I see. When CONFIG_MEMORY_HOTPLUG=n those come into play. That is not a problem for the memory-notify thing because drivers/base/memory.c gets compiled IFF CONFIG_MEMORY_HOTPLUG=y. I am thinking two ways to fix this: 1) Move the code for node-notify to drivers/base/memory.c 2) Surround those functions within a #ifdef CONFIG_MEMORY_HOTPLUG ... #endif Thoughts? I lean towards option #2 as it looks cleaner to me: diff --git a/drivers/base/node.c b/drivers/base/node.c index 182c71dfb5b8..3b084d71888a 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -110,6 +110,7 @@ static const struct attribute_group *node_access_node_groups[] = { NULL, }; +#ifdef CONFIG_MEMORY_HOTPLUG static BLOCKING_NOTIFIER_HEAD(node_chain); int register_node_notifier(struct notifier_block *nb) @@ -128,6 +129,7 @@ int node_notify(unsigned long val, void *v) { return blocking_notifier_call_chain(&node_chain, val, v); } +#endif static void node_remove_accesses(struct node *node) { -- Oscar Salvador SUSE Labs