From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8CF5C369A1 for ; Wed, 9 Apr 2025 14:26:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C03A86B00B3; Wed, 9 Apr 2025 10:26:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B88836B00B4; Wed, 9 Apr 2025 10:26:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DC5C6B00B5; Wed, 9 Apr 2025 10:26:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7A61C6B00B3 for ; Wed, 9 Apr 2025 10:26:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6E132C0178 for ; Wed, 9 Apr 2025 14:26:17 +0000 (UTC) X-FDA: 83314730394.11.6CDDC4D Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf20.hostedemail.com (Postfix) with ESMTP id 7456C1C000D for ; Wed, 9 Apr 2025 14:26:15 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=E8Cw0iOZ; dmarc=none; spf=pass (imf20.hostedemail.com: domain of debug@rivosinc.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744208775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VWCFSwSJdWVyuiq1FZlofUemWkrK3y3F0Kcxx42yGpc=; b=PmC4pO3arcX4V/+6/mVUJVNa1Xk0XsUabhRgo5TIHG41xpsTQ8IWzJuUq6l2jjZ7B+rADM JFADS4VKDOFB1DZ349UkIhU2xgx+OeCUkt5YWrYFxS3q2Ct+oREcQfWoKznfIP20cup5cS CtZqx2hu8VY10heWJM+SLNokNxpQGrY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744208775; a=rsa-sha256; cv=none; b=sbAfpYIxT6mmfikrqQtH1VjKuMujZz5WFL4qsKIDVBqrq1HxC2bl+o4RNOE1zTry1AXMdZ E3NV9m1d+PZVR+5M7ONzvAm9MJLN8mnqRQNRjonRevG+w88OQsDQQmuSTISQm6ZNIq8iuo G0x4H2gMgaoQ7HYGPwdxxiXC1HtC2Ps= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=E8Cw0iOZ; dmarc=none; spf=pass (imf20.hostedemail.com: domain of debug@rivosinc.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=debug@rivosinc.com Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-736ab1c43c4so6677324b3a.1 for ; Wed, 09 Apr 2025 07:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1744208774; x=1744813574; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VWCFSwSJdWVyuiq1FZlofUemWkrK3y3F0Kcxx42yGpc=; b=E8Cw0iOZDIHIym+UJCUbWTI7nEQg4ENY6SEl48ln4mhnU3wU2vo0m14rHfz98jpHFL tMsFLF0Ml8vwVqycVhArS29/1ywPgtwf4ZwpEWX9+NktVEiMuj8DFgaMC/Vf7HNGfBuP xod43eER5F6Fyol0qTBzInYSniKlCUFX+dAZvin6XX/KApm9gYZpAsJfw1AboYUElMk4 wUTpTGbxFPKyyc2eJ1q0TdnXP23SK7lf7Qh+HvAK+revFF0J0ORjMLBLmdc2YPm11mnJ 844ptA/eV83gBoypi53FJknDaa00ih0nbXiavW/MRxqoUdOcLix5UgwTupcgQo7aei5m meag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744208774; x=1744813574; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VWCFSwSJdWVyuiq1FZlofUemWkrK3y3F0Kcxx42yGpc=; b=et5xG73MVPty1yuEF3hCDGUE56XeKkDxQZxFlzxY5YPE8mQR3VfGnrNPRtfYiKPQ6E CZ4PzZcD+HgPP7Qpt6h41H8NP8CJw6f6DVzgPq8QKzwHQZRr5rJ++VGTtokZWv+1Ss1S LCgSeKxIxN5aInllqxnpeBPpqJdxeKymrUp/RIaX6hG8aWDzW7Zcz4pph3NhX0IpjFCJ wBzP9qXjb9eo+INGm7Z9sbfitjnd3GQC+WeM8q6U+FcQWblO4TLNsMjS0gRV2HWQWTMA 5Qtwd5CjHpEiCOvtTNkLG0ypS6oBdbjZqiafmPKcKusrPcXiwmeQRspHOiTMSnmu0pG1 CWtA== X-Forwarded-Encrypted: i=1; AJvYcCXLA+Uhh+IlIPIKAxELqOG+NfmmoRAS0/GlR+AXWS0Q1UwE9lgc++KlU6fk2ZTbEpfx6SAmtdiHkg==@kvack.org X-Gm-Message-State: AOJu0YwDXisSBbMRoNNM2GGEjHFm3CZ2yUJVn+L+S+ucM7DpqP02WCEB sPj875xaV/Plc0L6bIJ/BAiaP7FYpKd5Ihe/Ary7DOnXb2w6dWfMa36DFh7WVeI= X-Gm-Gg: ASbGncvOVREx0sqenqfW+x/2/6gltC1IVunij6RETHtyo/RTFIflYHPct8Cj0jTF6x2 bZg1ee3lJiC8gzYF25KUgf5HZ/4j67/xi2QANXJn+gZuQ9T17zDKY62RuXQdDcMuw/uT3/Ah4f6 NvuJ1Cpar5qcwewOcsujB8eHWsbgtUMUdIzHFljjYgi2uEk+ZXi70I5HRLmZ3yXJiRcevdF/tbV 6tF1VkI1Uq6pHQQ3OaiBqh9Dx/DCwSrtZi+yLR2+iQxCfN9Bltcw9YFkx1yS4CLES7l/+dLnWBy ou3bnrNXKVaKVIvsYTI4NdDOXJTWH2jFTPXWcyRZUpASN6xqLww= X-Google-Smtp-Source: AGHT+IHFFMUtgc5GdaqhKowOEcwpQuVaNNQv/0+QvYg71I8MlHsNAHS1sjVjRx/1bLRC7yOHjj+PuA== X-Received: by 2002:a05:6a00:e12:b0:736:a973:748 with SMTP id d2e1a72fcca58-73bafd6a4a1mr3511930b3a.22.1744208774241; Wed, 09 Apr 2025 07:26:14 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bb1d2b108sm1426136b3a.19.2025.04.09.07.26.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 07:26:13 -0700 (PDT) Date: Wed, 9 Apr 2025 07:26:10 -0700 From: Deepak Gupta To: Alexandre Ghiti Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , Jann Horn , Conor Dooley , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, broonie@kernel.org, rick.p.edgecombe@intel.com Subject: Re: [PATCH v12 13/28] prctl: arch-agnostic prctl for indirect branch tracking Message-ID: References: <20250314-v5_user_cfi_series-v12-0-e51202b53138@rivosinc.com> <20250314-v5_user_cfi_series-v12-13-e51202b53138@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7456C1C000D X-Stat-Signature: i3kt17yzwfrw461tjmxwaqzao6qxjebn X-Rspam-User: X-HE-Tag: 1744208775-852368 X-HE-Meta: U2FsdGVkX191K4JHu/o4ow+pDuzytN5YV7qc/hksckKkRtsG8Zis5qWTfEKj6A+K3Q661U+gpclCmUiyZtsM8rYWCQGJRYe8DqxfxtQaz6MpEYTNgXq8MOOILBI6CEGR1up2BX8irWCCXq48k5db1addvJxaGUPGmhnPLIfCeDGqPCdj0RJGyI1ngkcXKSF+OhXxVBUhtkSfSJnjrpbFGBJCzabmCruViRyw1/VGspbpnPZzbyHNx2gHMaMjOJTRr1LiP+MfPnCRngoFqcnI6uMj9yiexI21fL0qd9m+Rm6wU5rDzSsO8vSBE7NSvj81Zp2mCpg2QnDdwRorB9mFN1wiuy8koBWeUHGj4ytX1OPjOpp/ZNavHpSk4BIC/eBDP+d3wZcRlqlRemH4BZAkT+Lb9OhBjXLbFSmTi0OracORvgWmAXN+kMs8TAkFgR6SnykEKRyvUvIfIwJAWJU8uZmImexZvNy3Jt5t5kQAbw/vvKwS+V1crUUAvcNvHJxboWQIlStgytFAqbTcptC25o3lwjvKLts13ZX8ghZGa3w1IX08Hw+zmZ99W+RoEEs8W0RfpoCAS1jA7TvdMKETO0Nn/bRMBZTcfdJhjVpyD8jngL6Dhvl36xahcYNxH2fP+L7af76rGLuY5u0akR1ulFE/vFC04xiXF+qjbD4cG5+ZlaPA+TiEy5ORQYWVinR9LsrW7Vl+Me+qlUCTD40pp0Tn9cjm1kv7e1dXRQDG9Vk82LYI5G4X1uc5zr9+pdjzIv9nXrYzYpkCRO8qircUFSw3np7/4GGU+HSfDndSvTDBxiPOVLGQbD9fdjWd/1oYBBoUCFXY+HStF0iOIu33sYwqPSLGXOTjWNCyhMSHJsyIgrdKr6Beh/JYACTmOU3jjNiSwyMTcFE7U97H6teQW09wBppSM1ScHlGahwcVJwmQx4DZmjReBbnRV6d5De1cf7fvovpP3uNADfX3eM0 cO6ZqwNl fWgxFi9dm208g1f3dcBOQoWjz1osaPSJQ2QvDzlZXhhFYT/9eB2kyRvpm1ccUShsvgKJlfyTWfYIGi1NP31E36YoaXBUzQIYbNo7BAhh9ZJ6W0o98rWSprdMfUxaOpUXc517FE0bCB825780Qr+OX92cZh25jqNbvawPYnueOt8PYFHYUcL3SvJqkomNwrDhdtLbuVZWOJQhtXSHpFQrSi5mN+ofm9oAk2ssS/cB/Wury9bR+w63KjpmFFF/8yp3EyfQfqmSX0s2Ec1P4brKPDrlAFTuexyeFIpiTL0l9kCBM9zhcVOQSxGH2Sg51igvAzwNkVRbgMsYbgo/mVBJkhqSkUy3JMG+ftdoX/Xu/zV6zsrIYy3D1l0DHmOpvRS99G+1y51v/kjY7f2e5rcwOakLirg3Qb4JtDgUGCCtaBRn86KFbFOR6lFcsuaLYtA7rPgnln+VtEquv7rLDjijBO3uxHxsu7/nV/qoKSsP0phKOB50dTdCi+3w05lktceTDqW6u8pfjzppdkg4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 10:03:05AM +0200, Alexandre Ghiti wrote: >On 14/03/2025 22:39, Deepak Gupta wrote: >>Three architectures (x86, aarch64, riscv) have support for indirect branch >>tracking feature in a very similar fashion. On a very high level, indirect >>branch tracking is a CPU feature where CPU tracks branches which uses >>memory operand to perform control transfer in program. As part of this >>tracking on indirect branches, CPU goes in a state where it expects a >>landing pad instr on target and if not found then CPU raises some fault >>(architecture dependent) >> >>x86 landing pad instr - `ENDBRANCH` >>arch64 landing pad instr - `BTI` >>riscv landing instr - `lpad` >> >>Given that three major arches have support for indirect branch tracking, >>This patch makes `prctl` for indirect branch tracking arch agnostic. >> >>To allow userspace to enable this feature for itself, following prtcls are >>defined: >> - PR_GET_INDIR_BR_LP_STATUS: Gets current configured status for indirect >> branch tracking. >> - PR_SET_INDIR_BR_LP_STATUS: Sets a configuration for indirect branch >> tracking. >> Following status options are allowed >> - PR_INDIR_BR_LP_ENABLE: Enables indirect branch tracking on user >> thread. >> - PR_INDIR_BR_LP_DISABLE; Disables indirect branch tracking on user >> thread. >> - PR_LOCK_INDIR_BR_LP_STATUS: Locks configured status for indirect branch >> tracking for user thread. >> >>Signed-off-by: Deepak Gupta >>Reviewed-by: Mark Brown >>--- >> include/linux/cpu.h | 4 ++++ >> include/uapi/linux/prctl.h | 27 +++++++++++++++++++++++++++ >> kernel/sys.c | 30 ++++++++++++++++++++++++++++++ >> 3 files changed, 61 insertions(+) >> >>diff --git a/include/linux/cpu.h b/include/linux/cpu.h >>index 6a0a8f1c7c90..fb0c394430c6 100644 >>--- a/include/linux/cpu.h >>+++ b/include/linux/cpu.h >>@@ -204,4 +204,8 @@ static inline bool cpu_mitigations_auto_nosmt(void) >> } >> #endif >>+int arch_get_indir_br_lp_status(struct task_struct *t, unsigned long __user *status); >>+int arch_set_indir_br_lp_status(struct task_struct *t, unsigned long status); >>+int arch_lock_indir_br_lp_status(struct task_struct *t, unsigned long status); >>+ >> #endif /* _LINUX_CPU_H_ */ >>diff --git a/include/uapi/linux/prctl.h b/include/uapi/linux/prctl.h >>index 5c6080680cb2..6cd90460cbad 100644 >>--- a/include/uapi/linux/prctl.h >>+++ b/include/uapi/linux/prctl.h >>@@ -353,4 +353,31 @@ struct prctl_mm_map { >> */ >> #define PR_LOCK_SHADOW_STACK_STATUS 76 >>+/* >>+ * Get the current indirect branch tracking configuration for the current >>+ * thread, this will be the value configured via PR_SET_INDIR_BR_LP_STATUS. >>+ */ >>+#define PR_GET_INDIR_BR_LP_STATUS 77 >>+ >>+/* >>+ * Set the indirect branch tracking configuration. PR_INDIR_BR_LP_ENABLE will >>+ * enable cpu feature for user thread, to track all indirect branches and ensure >>+ * they land on arch defined landing pad instruction. >>+ * x86 - If enabled, an indirect branch must land on `ENDBRANCH` instruction. >>+ * arch64 - If enabled, an indirect branch must land on `BTI` instruction. >>+ * riscv - If enabled, an indirect branch must land on `lpad` instruction. >>+ * PR_INDIR_BR_LP_DISABLE will disable feature for user thread and indirect >>+ * branches will no more be tracked by cpu to land on arch defined landing pad >>+ * instruction. >>+ */ >>+#define PR_SET_INDIR_BR_LP_STATUS 78 >>+# define PR_INDIR_BR_LP_ENABLE (1UL << 0) > > >Are we missing PR_INDIR_BR_LP_DISABLE definition here? PR_SET_INDIR_BR_LP_STATUS with parameter's bit0 clear will disable branch tracking. This is what arm and riscv settled on for shadow stack enable and disable as well. > > >>+ >>+/* >>+ * Prevent further changes to the specified indirect branch tracking >>+ * configuration. All bits may be locked via this call, including >>+ * undefined bits. >>+ */ >>+#define PR_LOCK_INDIR_BR_LP_STATUS 79 >>+ >> #endif /* _LINUX_PRCTL_H */ >>diff --git a/kernel/sys.c b/kernel/sys.c >>index cb366ff8703a..f347f3518d0b 100644 >>--- a/kernel/sys.c >>+++ b/kernel/sys.c >>@@ -2336,6 +2336,21 @@ int __weak arch_lock_shadow_stack_status(struct task_struct *t, unsigned long st >> return -EINVAL; >> } >>+int __weak arch_get_indir_br_lp_status(struct task_struct *t, unsigned long __user *status) >>+{ >>+ return -EINVAL; >>+} >>+ >>+int __weak arch_set_indir_br_lp_status(struct task_struct *t, unsigned long status) >>+{ >>+ return -EINVAL; >>+} >>+ >>+int __weak arch_lock_indir_br_lp_status(struct task_struct *t, unsigned long status) >>+{ >>+ return -EINVAL; >>+} >>+ >> #define PR_IO_FLUSHER (PF_MEMALLOC_NOIO | PF_LOCAL_THROTTLE) >> #ifdef CONFIG_ANON_VMA_NAME >>@@ -2811,6 +2826,21 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3, >> return -EINVAL; >> error = arch_lock_shadow_stack_status(me, arg2); >> break; >>+ case PR_GET_INDIR_BR_LP_STATUS: >>+ if (arg3 || arg4 || arg5) >>+ return -EINVAL; >>+ error = arch_get_indir_br_lp_status(me, (unsigned long __user *)arg2); >>+ break; >>+ case PR_SET_INDIR_BR_LP_STATUS: >>+ if (arg3 || arg4 || arg5) >>+ return -EINVAL; >>+ error = arch_set_indir_br_lp_status(me, arg2); >>+ break; >>+ case PR_LOCK_INDIR_BR_LP_STATUS: >>+ if (arg3 || arg4 || arg5) >>+ return -EINVAL; >>+ error = arch_lock_indir_br_lp_status(me, arg2); >>+ break; >> default: >> trace_task_prctl_unknown(option, arg2, arg3, arg4, arg5); >> error = -EINVAL; >>