From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F21C369BA for ; Wed, 16 Apr 2025 18:14:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93E3328013C; Wed, 16 Apr 2025 14:14:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ECF128013B; Wed, 16 Apr 2025 14:14:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DB0728013C; Wed, 16 Apr 2025 14:14:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 600D328013B for ; Wed, 16 Apr 2025 14:14:57 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9540FB1D0E for ; Wed, 16 Apr 2025 18:14:55 +0000 (UTC) X-FDA: 83340708192.23.D2F416B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id C68B71C000B for ; Wed, 16 Apr 2025 18:14:53 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ua092Kur; spf=pass (imf21.hostedemail.com: domain of tj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744827293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wNyP9RVZXo/0Ty/jUC49MDHSjD0paYjFlp3Q4N/XV9Q=; b=WK1X/bIBnUGLrkBcfB2RG/WrcPzISwm0ymv2og8WEne2juO4s9dDiIIZaDzF+Xn5HmqgSo HVpjag6LHTBsHxgNsKByxZDkcuNc0PPRdQiCcohsyy84FKicvnBfHZ7zVnwzfuKP7yA2MA Th2QMoetsTSm9MscRVA8eiXKBxVFXKM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ua092Kur; spf=pass (imf21.hostedemail.com: domain of tj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744827293; a=rsa-sha256; cv=none; b=VbykddONv3mUy4bpjiBWuH83KGJxpPpYITS5S+AA56YkHIpGJXrEeo83TCgMmqA5FI1Fmp ZY9VQP9BNt/iIc3zTxbom/i41KDjfjkoUJ6u4COBe+EmCWynpRFsM+/UMJMTH+rdUzBFo2 +qp265Tu6SIr8wCjRvB0Q9YaoSH3Yis= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C64675C100D; Wed, 16 Apr 2025 18:12:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65AF0C4CEE2; Wed, 16 Apr 2025 18:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744827292; bh=2ERSk5gLUMBQhHX8zmqOzbkGspPjBe55p8jfmD2CgZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ua092KurcynR43dGLaZ/Xyqm/Z247RRN7DBkY1o0tiS+zoaN/2Fv22HDc5m26CrZE u4gBV8r6VRGzBZ74qXIyv5k10kom656SZRD5pt9sjfzbqHZCms1YfppEcx4XytlG4w ujuyS0pCpE5TNwP5QHWHSLIPpFnRttvRyko3XyG7eO7g5EGxpTkElThLqTFv97UrWB ZwVdKoUSj+fGuyn0yA0nUEUDaeolf8ZGILcx/kBnJynYfon9X8WCzl6+tZpWhlVikQ pDO36X3nJsz65DQpmTrOo/iPHECFQYxLaTY6Rhp//LvPQMLhY5GmgnlnwjE4c9kggl nZ8Nx9OWV7Oyw== Date: Wed, 16 Apr 2025 08:14:51 -1000 From: Tejun Heo To: JP Kobryn Cc: Michal =?iso-8859-1?Q?Koutn=FD?= , shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 5/5] cgroup: use subsystem-specific rstat locks to avoid contention Message-ID: References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-6-inwardvessel@gmail.com> <3ngzq64vgka2ukk2mscgclu6pcr6blwt3cwwmdptpdb7l7stgv@vhpyjbzbh63h> <6409c074-501f-4fe4-826d-5d5004735f00@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6409c074-501f-4fe4-826d-5d5004735f00@gmail.com> X-Stat-Signature: i9oubaycaathgexkbcur1xj5mszoagex X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C68B71C000B X-Rspam-User: X-HE-Tag: 1744827293-962394 X-HE-Meta: U2FsdGVkX19SkOwTaUEGlU9oVBTxcANoA4IIaQNrU1BpqGCSrWKMH9nz/A5ilvgPzAJ8MxZk+EAXwbVfHl0MfePf3qh3YbenmR/zFK2mJpUCyHchW88xdxbcZ09frV/QqE0azDLLOomxOK3xo8eTohEU5OAl13u68fCW7oGUyhj+sBml/Y6qlSUMTzfYjywiRqoLHvxHgVSZsrYyhhIJ4R3JNpXCoqdPFIa+Vq7/+nTrcROeueLQV94zik7RrDg7F+1LBt+mPYlSil8KfWbX1G+fcCnNFQgVf+DO7ZJezE+uJG9mTdCNG+aHyvn69oAZZNr7Ujx2SYPzMCHh3qr6GAkDy52UL3XNYyO/Z7HG0pF1978VRaR0z90ewGoSMYHX2UQZtKrc+N3Kf6QM+uh7NYJY5IGfYlY/NYy/aFKmob3TyMVJNuBukAtfgTm1W3irEOw3gnm2cWFDh1wO50clzv16oVz1Mkob7t20Q0tUKPMp/9gIPj+nAf7Yo3npiZRRICdw0z8VpQiVTzl8DIAWLPQhR3veNI+7qYgFEATKnZpf9ygC6sJC/m1y8WgbXPEXDbRZ/gAITDJe/Onxbo099JES7Lv0PoxQhz5jftdKwJvA0tWhnBwOh13nCqPvaUQ2DKVhFu3ABYL3Yfs1mS6DVslyg/4lAvxEQpczWvQmrAVcBmpybhXAILrO+5Hv/1nsD4b1IG7r+fwmZ89D9fzeCNU1FwR4pGC2IMleXWl91eGQuzbLWAaBN2UjLPsaQRc2Z1d+8SdZlJCMDBGiSeGe5mmL48EMSziHke6USccLzr78Ft+nN9LeHxFuS492ImMh1fbH1/fnZvotxSkhcfgWlCWrHDowtpxWcliP0XtQq9rbwybcS18QLkxZbEApDbH6fJvnEtF09C3KCBjrpm460esbCKPC/Auywucb16p71Q9Ra2is+EGhEWLF7qFpA8gWDF6MPmkpXSguBng8sdV Z4BAdH1O a64H8nh340HtXvixvpuZk5MBUgJvalkrVB+JcJ/WM0319Ilnpb0es+66C5EMQjbHGOxp/M5tNDa78fbMFL/xAOfnPYiiJOLtBkTb/pr6h6/2vXSe+mXovlDer1mIoBdf9IVVaTRk7+QOcVC6jj7voS/Iuq9juNH2Sfp5NU2qAIuUUVII6wUgDxVDRG1L8OaYIU4F/jIFr1hLKIk4rFUyOHg6UUW0eOl4O8QQK7DJs6ll0IZOsmBDLEmtTesV3ZccJ7nYj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 16, 2025 at 11:10:20AM -0700, JP Kobryn wrote: > On 4/16/25 2:50 AM, Michal Koutný wrote: > > On Tue, Apr 15, 2025 at 09:30:35AM -1000, Tejun Heo wrote: > > > I don't know whether this is a controversial opinion but I personally would > > > prefer to not have __acquires/__releases() notations at all. > > > > Thanks for pointing it out. > > > > > They add unverifiable clutter > > > > IIUC, `make C=1` should verify them but they're admittedly in more sorry > > state than selftests. > > > > > and don't really add anything valuable on top of lockdep. > > > > I also find lockdep macros better at documenting (cf `__releases(lock) > > __acquires(lock)` annotations) and more functional (part of running > > other tests with lockdep). > > > > So I'd say cleanup with review of lockdep annotations is not a bad > > (separate) idea. > > Maybe we can keep these intact for now while updating the text within > to something more specific like Michal is suggesting? > > Tejun, let us know if you have a strong feeling on removing them at > this point. No strong feelings. No need to churn for it. Thanks. -- tejun