From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F3FC36002 for ; Wed, 9 Apr 2025 11:59:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3BE96B0194; Wed, 9 Apr 2025 07:59:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBFCA6B0195; Wed, 9 Apr 2025 07:59:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B60A76B0196; Wed, 9 Apr 2025 07:59:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 945D86B0194 for ; Wed, 9 Apr 2025 07:59:28 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0CE17C06DB for ; Wed, 9 Apr 2025 11:59:29 +0000 (UTC) X-FDA: 83314360458.16.66622B1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 582AA1C000A for ; Wed, 9 Apr 2025 11:59:27 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WQDoHIFF; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of mingo@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mingo@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744199967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I6iBfxeNFks1YyuIzE6McSy1B29zA6WaDDELWGdXvXQ=; b=DFvrOj+O9y1pmmDf2tj7t8/lfQOMbUeHTz5nqEflVzduzOV5W6ravnt6LhVd6Q8Xy82YHZ DoMqNMso5vqqmu+LGldTUkAxUUBtMOFG9lHZhcNa/34mm1UXj+6VzfHhB4Cl6T9LGunbB+ oyV3y03aDFulcjn0qhdmoiOjGqPKuQM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744199967; a=rsa-sha256; cv=none; b=TVhJ4Br/dkDe4KcoMseQ/xgDMfJIWIT2zxvTRFFBhhUfe9jAwOjn09nrmiW9ZM8epojnQE mYR2Fsy0Pp0gnUyacCI9MvkYQFepzjwrQ8ndUADkRfc9EtPKwiT9v0HlvOpnS/bbnSb1bQ tHwqw4vHWFg8QI+MfVrt/MXDl4WTEa4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WQDoHIFF; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of mingo@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mingo@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E0E6F5C0E6F; Wed, 9 Apr 2025 11:57:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB4AEC4CEE3; Wed, 9 Apr 2025 11:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744199965; bh=2gwN+a30sBQomtnlkPQhso40CkRjZBCRGbCpnXiMN/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WQDoHIFFapA8BdAobaU/wpbdXLbaYJOiQ28nAtKJfCORk/V+NQ02t1cjKzTqslcJ0 K6uPo3fUXPIlDxxfi+qzaZ3y5/PHZWBg4UY+haNfEYL+m6mKgk3lILf5urxjgHNwg9 JqtU3V6iJaylymLbDG8pPt06ZkcIPGm9ESuxnSaKdzE4Wx6GSS/qtV0LPt9+VPF5e2 NTD1+LXTBTJLZ9yEYr5rgz87VzsZzczxBan5od/4wDELiTytYaJ40CNSe4bC6LeT4h cXum2eLJbxgAhY+CpVaazJGDO7oynUTwC3Cwxdr7K/l9ozhevMLsw72FwC5iXwsrPo 3+FJeCdCR1rZw== Date: Wed, 9 Apr 2025 13:59:19 +0200 From: Ingo Molnar To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kernel test robot , Dan Carpenter , Lorenzo Stoakes , Andrew Morton , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Rik van Riel , "H. Peter Anvin" , Linus Torvalds Subject: Re: [PATCH v2] x86/mm/pat: (un)track_pfn_copy() fix + doc improvements Message-ID: References: <20250408085950.976103-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 582AA1C000A X-Stat-Signature: jfrxnn5ipboufmcdbjgku5wfnao11mch X-Rspam-User: X-HE-Tag: 1744199967-911747 X-HE-Meta: U2FsdGVkX1/xMXxIl/uc6vnnK8A+fUEGrOz/wFToNpeN0H4YwsYWsGJ11LntUPBxb8cbHWcObL/5g90b2DzVX7BWGZdneuajE/PXnxrCFj0gbtpBREmvMyttgnSubY81UeqztwiQZ9nYvc9ID6UlxGbh5YIZ+1PvDw40w1VBylDVotsSZgbEDQ1uy6i3NF6Ck3D9QAZaXXlzTYyPeWZ8+FivuXKAkQ41RPfVuFX5N4oqo5t5FKliuEXPqlbQMQKGFw2Cb0DNH1gneeGYxA/gI1O3zOw8E4mYOR2Q6lBSbpBjOhFA0tKew4y4HGYoO8l0pf0ya5B9mYCtjUlJW/rcIhlselhWnNDQbTTRoqQ9Zz7q/CDwg73E6Ug+Pr/qsdFbVYFW6S4ysMqzgw1+3DzJkKBfL+t6Jw/HTnjwquSzuxEZuJWEKigcBkUnKYfdO64J2aCN6AxOcyUm93FBIp5R7LRsMF3ZT3WKcxVolgUE73F5/BVRf+6b+4AUVQs1LHw9hRGGkY+jGZLe7bj5xB6Tc1KX/kSs+sWYMMxXLg83cpPTMCv+zaDWjY4BxsoMx2k0ANEhg9JOdYQAwT0fKLS8R3Meq+cjkQKduA+3aLovLTNzUU3iXyY+2+pDvFHsZQONWflclvOcgulhAcgNt9XJPi7xHpWN9VqIXaLseVX1KJmjQQoaHXdTwVP0Hu60EpzpXmAJpcYgHXvI4tgS/kwkSGIPUQ89JQl9WAYJKNafBwSVBiJewVM2ffEsY7lCnH0mV3F6QW4pi6hE+Vp1Ycacwg4lvQfLvgpGMrb/BrdwAV9qreyIJQAsQ2rKqhMtbZHwAQiVBR4d6G8QfnOF6AiQzrYQi/A7k5Ko+m//+xAdc3CvVxGOjLRj0ZvvOJ4284t61+prR5yjnE4C2KXpa81fAVlFTUUvtEsnoaefCPxcVQegv2DjCbVIldpfBX6i4QgmwIVwhjI9fzSrIfpSNYp meuYhJqL h55srVfZ3z8gSaWbva8j5OlWTsGp3Q1PQ/XBTc3Oacu/Ua/OOc/NK4x2Mi15ZdR8Jaa5kdXv/PDOtgaemWFQdfxsGw2dwcm8fO9ao6NMGFGyZn7UBkIC0KgWBMf5peqcvG3UW6AgdZmJOir5rGwOnDhe2ZjI8Nb3tLVR6gnayvjePzq59XZgYJzdABlut86nkIhqEPBrx0jcM6m92d/U4swZV7OCTuq7qg36+gUnvfPolvpf8mhITCj8J7rl3+bUDXCsfWpF90QHp1fR8YwAF/BO3UESIlEbNLpNKLr+9MtEP2n4NHbt47j8djw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * David Hildenbrand wrote: > On 09.04.25 12:32, Ingo Molnar wrote: > > > > * David Hildenbrand wrote: > > > > > We got a late smatch warning and some additional review feedback. > > > > > > smatch warnings: > > > mm/memory.c:1428 copy_page_range() error: uninitialized symbol 'pfn'. > > > > > > We actually use the pfn only when it is properly initialized; however, > > > we may pass an uninitialized value to a function -- although it will not > > > use it that likely still is UB in C. > > > > > > So let's just fix it by always initializing pfn in the caller of > > > track_pfn_copy(), and improving the documentation of track_pfn_copy(). > > > > > > While at it, clarify the doc of untrack_pfn_copy(), that internal checks > > > make sure if we actually have to untrack anything. > > > > Note that the title isn't accurate anymore, it's not an 'x86/mm/pat' > > patch, but an 'mm' patch. > > Agreed. Who will take this patch? If it's Andrew, can you fixup the subject > please? I was assuming Andrew would pick it up: Acked-by: Ingo Molnar But can pick it up too via tip:x86/urgent. Thanks, Ingo