From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A7BC36002 for ; Wed, 9 Apr 2025 09:43:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D0F0280059; Wed, 9 Apr 2025 05:43:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 780B8280058; Wed, 9 Apr 2025 05:43:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69674280059; Wed, 9 Apr 2025 05:43:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4A64F280058 for ; Wed, 9 Apr 2025 05:43:17 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 443D91602FF for ; Wed, 9 Apr 2025 09:43:18 +0000 (UTC) X-FDA: 83314017276.13.FFDFC03 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf27.hostedemail.com (Postfix) with ESMTP id 719F740011 for ; Wed, 9 Apr 2025 09:43:16 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Tz4G8OLX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744191796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XdLrlLv8Krq8ZjCFv2/El7bqBEiJ4H/Z1+nC0yvpdfk=; b=XpzB2/OX6U7UHEUAwHvlyxKtxteq+FwskpdnhNwFvh93va66RLde9fg1GxBYBXpnzao98+ w3vVJgbrQ5MrSAEQm4dvwoh0sUv2kXGzUzmUg5e3cYAU+NIWBT0wF3wwU56hTXyNXfjyoL ssFVdESfU1r54vg4/8IdI66s2VlPnPc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Tz4G8OLX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744191796; a=rsa-sha256; cv=none; b=OzCyYrI3QBCqWu/D8GYinkR7WChDfHnhFUVlEIYjKd4HVvLj2a6hKOuFdFeB4Ge8ZlVISS 2utEwU8HStPtxCeNnkvYmQOKvI0DREKU5y9KBsPAFeg4IiqyV0AIcwoF5l7OL9LFg9Kn2o zZtaZYGprs7H1vZ09X2AXCnu2u8bhwM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 9DF1D45223; Wed, 9 Apr 2025 09:43:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62D74C4CEE3; Wed, 9 Apr 2025 09:43:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744191795; bh=FjJ4QbW9SU1iP+ML3U0A+ucRm2GiU0e71LPKaPgthFQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tz4G8OLX8nnog0v22oBwDuD3JId5z/TPCCskKfAVQorpXd7wLsaFqhlnrza8EuDMr LjSnxnsFChBhBrq58wtx6DvwfQsfs7tAiWIIKakzb9Xg9v5uRbB8qkgMkPeZwtzxaQ TVhfhlHk1twuHM91sNPkjfQ6MjrSyV2+6ZvkUlgZUkYqmtQQRiZQgb5yhbxsBEmuMN rAIwMAQPKjWVXqAhNsd794HAiVN0G2Eoq/x4eOZgFSgw5Vy7MDHX7QTtaerCV8vohN OGG1pkLzIMzw5GUh6ZL01fFSd/lTo7OpijYZUThfFL+l7TLpzEAExukEGjyXZj6dH0 87Ol5Ac251Mdg== Date: Wed, 9 Apr 2025 12:43:06 +0300 From: Mike Rapoport To: Yuquan Wang Cc: Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rafael@kernel.org, lenb@kernel.org, akpm@linux-foundation.org, alison.schofield@intel.com, rrichter@amd.com, bfaccini@nvidia.com, haibo1.xu@intel.com, david@redhat.com, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, chenbaozi@phytium.com.cn, loongarch@lists.linux.dev Subject: Re: [PATCH v2] mm: numa_memblks: introduce numa_add_reserved_memblk Message-ID: References: <20250409040121.3212489-1-wangyuquan1236@phytium.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250409040121.3212489-1-wangyuquan1236@phytium.com.cn> X-Rspamd-Server: rspam01 X-Stat-Signature: u7qomfcuz1sgbtas49yeomchhmr1as9g X-Rspam-User: X-Rspamd-Queue-Id: 719F740011 X-HE-Tag: 1744191796-272913 X-HE-Meta: U2FsdGVkX1+0DEATLDeYA2LJfdKo4hbGIY4p2D6hChyhQw2bCeMsHOuYFlkYuHOmhyE/W5Zf/ypqQJnH9Thl04NKpQiki9sWm7K6umu35u1sutCA8PvUIk61vNRNOate+pBY4wTEFJt2IzKzu3iowEcbtFdS2WHL8kAWYgN824l/Tdij6M/FNC4OHDUxBIrun5A5TcoYKrE39EXsHb8tRT30K3rYyKJqfhHewORfBbTqjh1OT3g4TCOJgfxaR8swJ8ubmt/X9B2ZQ7cFKLZEU5iJRzMNPqO8lFnjx65x09paK8fMOtfH/P9uiEPPIM/et00tCtX1T/jdnGfG+DqygMtJ23eHR7vy29rF3bmoWpCDFYQmxRQUU3T+8dZJqB+Znwody/w524jySif5GDzQU+dY85+Tl95JQY4pDtf/gEHbHA5zKhmfYDfcH85EBqQW06Pdlhc9Yd/LxLFaAIvJaK2/KTXhCalYZOSyVuQe1S/JSgRzyS4OZN7gSgtDxeBkmw+FkBPAWYJHocVqRnmj6oqYQCv+zUVWsg5buiywExtIwsjYn1dBt2NrocZYmkCjfZ41ibTF/GG5gZE+s/qg6bE25pdcENR40YWUGCK1UsVaqkg2o9yEyevlZO2DGJFM4Amsj+glUp9Uf1HjYkuethY3IVZUK9mLngZoarp1N23WX8oTbk0DEZkveVaQKsWNAz4ybAaWZPdClJ+xJTEsnjGnQ1tO+QVe7++mNormiH7vY3LKaJJW8vjmsV+2z7FRIL3tVUKX0Hf6gbpnU02BvBOCTtqKsfH46FrBWWSpVVhk4FAuewKdGFSUbUkazPKN2EVNZqTDan1UeKolPZA4lQKGD8xgYUeaq5FhXCOwFlk8SpF0VkaMAPdvFiTm1AsSAcw3IOjwftWBCR2BCWceEaqYUv7GzAtchNsMW3+uPRkZxpvxVkl3Lku1OOdT7wLwPYBXRqiztqDmXkB6sVE +TTz+DcN i51w/rn1vqT1oTYgAN6wQ/jSbETSF9Q+gdxtjGfZAI2iXMIijqXYRoktwxpmhNVsrXBro3BlGaGfzEvKVv6Fg5hLoUittTK535CbPIGCHVe6LnpJh9nMxDo1zBiKhQZpIFpjop0IK67rlNxmiai+0SMe1bnKA0SGEq2cOho5n3sPB/PWnTBITLYaFTXV/vgcox5luZ+rBfgQdHCMrUCBNrI9+pQ1lHufrJ0iZas7ncwwp0k7y5eA123OOV7EQbLEVttkRxGgQ5hiBnd5xPiOgIXABNijCOZBLVdxtRCixXeDeyrpmehYr5LfRPOdji/gZ3/DCn8VCK6wUUAKinCej1EJuuW4QzAKwxLI4Ai5Ulae6OrUKvX2JMGD9wMmBIybtuocq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 12:01:21PM +0800, Yuquan Wang wrote: > acpi_parse_cfmws() currently adds empty CFMWS ranges to numa_meminfo > with the expectation that numa_cleanup_meminfo moves them to > numa_reserved_meminfo. There is no need for that indirection when it is > known in advance that these unpopulated ranges are meant for > numa_reserved_meminfo in support of future hotplug / CXL provisioning. > > Introduce and use numa_add_reserved_memblk() to add the empty CFMWS > ranges directly. > > Signed-off-by: Yuquan Wang Acked-by: Mike Rapoport (Microsoft) > --- > > Changes in v2 (Thanks to Dan & Alison): > - Use numa_add_reserved_memblk() to replace numa_add_memblk() in acpi_parse_cfmws() > - Add comments to describe the usage of numa_add_reserved_memblk() > - Updating the commit message to clarify the purpose of the patch > > drivers/acpi/numa/srat.c | 2 +- > include/linux/numa_memblks.h | 1 + > mm/numa_memblks.c | 22 ++++++++++++++++++++++ > 3 files changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 0a725e46d017..751774f0b4e5 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -453,7 +453,7 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > return -EINVAL; > } > > - if (numa_add_memblk(node, start, end) < 0) { > + if (numa_add_reserved_memblk(node, start, end) < 0) { > /* CXL driver must handle the NUMA_NO_NODE case */ > pr_warn("ACPI NUMA: Failed to add memblk for CFMWS node %d [mem %#llx-%#llx]\n", > node, start, end); > diff --git a/include/linux/numa_memblks.h b/include/linux/numa_memblks.h > index dd85613cdd86..991076cba7c5 100644 > --- a/include/linux/numa_memblks.h > +++ b/include/linux/numa_memblks.h > @@ -22,6 +22,7 @@ struct numa_meminfo { > }; > > int __init numa_add_memblk(int nodeid, u64 start, u64 end); > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end); > void __init numa_remove_memblk_from(int idx, struct numa_meminfo *mi); > > int __init numa_cleanup_meminfo(struct numa_meminfo *mi); > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c > index ff4054f4334d..541a99c4071a 100644 > --- a/mm/numa_memblks.c > +++ b/mm/numa_memblks.c > @@ -200,6 +200,28 @@ int __init numa_add_memblk(int nid, u64 start, u64 end) > return numa_add_memblk_to(nid, start, end, &numa_meminfo); > } > > +/** > + * numa_add_reserved_memblk - Add one numa_memblk to numa_reserved_meminfo > + * @nid: NUMA node ID of the new memblk > + * @start: Start address of the new memblk > + * @end: End address of the new memblk > + * > + * Add a new memblk to the numa_reserved_meminfo. > + * > + * Usage Case: numa_cleanup_meminfo() reconciles all numa_memblk instances > + * against memblock_type information and moves any that intersect reserved > + * ranges to numa_reserved_meminfo. However, when that information is known > + * ahead of time, we use numa_add_reserved_memblk() to add the numa_memblk > + * to numa_reserved_meminfo directly. > + * > + * RETURNS: > + * 0 on success, -errno on failure. > + */ > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end) > +{ > + return numa_add_memblk_to(nid, start, end, &numa_reserved_meminfo); > +} > + > /** > * numa_cleanup_meminfo - Cleanup a numa_meminfo > * @mi: numa_meminfo to clean up > -- > 2.34.1 > > -- Sincerely yours, Mike.