From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03466C369A1 for ; Wed, 9 Apr 2025 08:36:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CDD46B00F2; Wed, 9 Apr 2025 04:36:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 956016B00F3; Wed, 9 Apr 2025 04:36:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D2926B00F4; Wed, 9 Apr 2025 04:36:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5F0536B00F2 for ; Wed, 9 Apr 2025 04:36:12 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A586E1C9365 for ; Wed, 9 Apr 2025 08:36:13 +0000 (UTC) X-FDA: 83313848226.15.5D5C902 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id 19994180006 for ; Wed, 9 Apr 2025 08:36:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jxl4EkcT; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744187772; a=rsa-sha256; cv=none; b=DAtC/RrfDFWao6auxwI+3YLjiagdwTMzhy7HzlX5lO+7x4aDacqkxWL19sk6gPzquij6TG Zv/XtFYoNR8h7EonChZ26j63RlizWLn/jPPfudkGSx0V2BYcIZ3PkIPNJvZgcF1glMpsKa darZYdRM1CXcgOgdOwZsUOmk80r6A1o= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jxl4EkcT; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744187772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XD4NsjIFCyd8Ex529NDCunOYWuzACOtjmPfQb41hkJg=; b=VjDJTFzppetXGk1avfD57E349uUfbtfjV5haVCIJuie4/xhdsAoHSrAPznnil7Sl6tLq6X zz+2PO5iMksUEM/9zELvLGi1iDeh06gJIEGjo0P6XP4vdCrOxqV00BahDMP+EyLIW4kKO9 qpBIHVA32cILFPHqB8rElet54IficGs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A2F36A49875; Wed, 9 Apr 2025 08:30:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2D8EC4CEE3; Wed, 9 Apr 2025 08:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744187771; bh=AjITk3Md+AG+a9nq5/1M/7k+M+xWBDNKTQp+Pam8Qec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jxl4EkcTYBvpu02SHiv4NYKjhRHuI1QV1VXtqxPQ6xmZhA9y0GaGbXlIT3hyEO7S7 5viRVWZH4JiIx/RIg+ayZEQEhaWtFgahx62A+n8kZ4DU/nRT9mIhBjmCPfoY4hZ+Yf +4RAFEBv3UpOO5m4cOfJTXaDBDL8ygyC6Du55rytLyi2dvoGXmwMRTZEir/CqwlA62 IbcINznr+djTduj1Sy8XSTZEaHL6tM9ze/2nO6qrmacw1KrIyPMyWeKZ1S/vhd1ywP et0eFpvt+49XTr2LuywdEfwAr8kc3vv2m5q6Mxv+lnvokkoxZkglhy0D/BNkW0rWmR ZOpPouY0e55uQ== Date: Wed, 9 Apr 2025 11:35:55 +0300 From: Mike Rapoport To: Jason Gunthorpe Cc: Pratyush Yadav , Changyuan Lyu , linux-kernel@vger.kernel.org, graf@amazon.com, akpm@linux-foundation.org, luto@kernel.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, dwmw2@infradead.org, ebiederm@xmission.com, mingo@redhat.com, jgowans@amazon.com, corbet@lwn.net, krzk@kernel.org, mark.rutland@arm.com, pbonzini@redhat.com, pasha.tatashin@soleen.com, hpa@zytor.com, peterz@infradead.org, robh+dt@kernel.org, robh@kernel.org, saravanak@google.com, skinsburskii@linux.microsoft.com, rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com, usama.arif@bytedance.com, will@kernel.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v5 09/16] kexec: enable KHO support for memory preservation Message-ID: References: <20250320015551.2157511-1-changyuanl@google.com> <20250320015551.2157511-10-changyuanl@google.com> <20250403161001.GG342109@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250403161001.GG342109@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 19994180006 X-Stat-Signature: hz8hnzhays8uqdd5da8t41n7fdp5pqmh X-HE-Tag: 1744187771-270743 X-HE-Meta: U2FsdGVkX1+J2uf+j3UhYxpKFpzd6Y/yUV1M7+BYNkt1VZTr3brogm67TwFsuxWgfYPJp4ivqCbSjz0MgS6+rk2VAe0JrxzyCitjIS+nzIw45/V28ovtHVWVh0HToxA5NzyYDQFyhZMHLFE50SjUTCkEUVES2Kaqhm0WeSIVIoL7QLP+pJjA99oZ1GhBKGXdTRHx5A/0V1aWoBPWs1tP4W2MxR/1/QUWoRgSRVqDyJiKTfwblhVLSh7J7wGYGrlfB5y5Kp/aq0zWDc5tne1F/wVA66FKeGMkM0uaRXMp/f4576huzekvEEaUL2jGWRzfm2KtuFrMhpKeF4Tp7ATZNtJwLICnAApm/RSDZpuiMxTnB4O9CzY7B+98o+EOQOCkxnr4LGF1/EHAXlc9c/z23fVTKW5LAQOH3qO2idCiNAm0Mw7WdeJoePJ6Gh4akYoY04mzkzKjWl8avu3dR5Gyw0fDpK94USi41zGuF1qOCrmlppmF7LXzq1a2bhLV28sYN156QBsGNliVGcbVm/WtvP85lJgEVMb+0NzAU2nrBBKHKn7jHLRnqXIM40YEDlUgLN7zGUd8Q1IFyAML2oOF10lGfFRmLh/HrB70Fp/D6deSUwXX+7Z2w/d+5MlDNAtzg3n+oVkPC86iKbvX7s+cANiNo+0P6WNUf6EXPV2banPeAR3lfMbkNV0K/Z5EnoVo0QBtg54KgA/fqRFHR+SGy0BHCdQe/HPQqvdlwhbklBh7mMvcHuQDpnWC+yk5qkUge5JguYodnGzeFIK/OqOO4tsn0hKD1uh/S9IPpxC0vYWHYlGAA5zY2vBEptF0fn2konMbt/TzW8YxQEaf3J+tuKTvOBG68f1RetZ97usbeeo2htFT+IOzT7NXHz7LqBhpcpZ29KyT27YlU7974kN3V5n0cXSwmHFy/wC8uGdLQwDnkUgNE9WPtgdhLeqMjSQKETvmJ27kbn816ngQkPw ve6+w6ZL E3HTgQFuypjAibGUTcOlTKMNhm6dhVn7cVob/dZQkjaWFUb3On27PgqFjq8IJAmGaayJbHKQi5HfYDt50vRrDLOf5zIwxticM8JRXTssV1EVE6Jmha+3v6NS4NFXb9tHWdgDgsSUVzlU7ZHkTwAayfpiBhfhRe3UieSrCRQ2ov+C1T+q70LZwxEGn/jRji084cQO0FQbrKCQtNdksK7e4J1a0SPXIvOrbLcM9z6qeaLKTanM5e6OFoRi6oJCcxOoQ00ZwNZx/u7ZaI51+/u5xhzbLICtymBA/gmJswtxS5ZTFkMOegXi/p/luqMOF2Rg0W0ei1rNmyruuK8o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 03, 2025 at 01:10:01PM -0300, Jason Gunthorpe wrote: > On Thu, Apr 03, 2025 at 03:50:04PM +0000, Pratyush Yadav wrote: > > > +struct kho_mem_track { > > + /* Points to L4 KHOMEM descriptor, each order gets its own table. */ > > + struct xarray orders; > > +}; > > I think it would be easy to add a 5th level and just use bits 63:57 as > a 6 bit order. Then you don't need all this stuff either. Even 4 levels won't work with 16K and 64K pages. To use tables we'd need to scale the number of levels based on PAGE_SIZE. > Jason -- Sincerely yours, Mike.