From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46B3C369A1 for ; Tue, 8 Apr 2025 18:06:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72430280018; Tue, 8 Apr 2025 14:06:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F90F280017; Tue, 8 Apr 2025 14:06:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E9D7280018; Tue, 8 Apr 2025 14:06:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3EB99280017 for ; Tue, 8 Apr 2025 14:06:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E3651810E3 for ; Tue, 8 Apr 2025 18:06:45 +0000 (UTC) X-FDA: 83311657170.16.8E25424 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 3BC14100011 for ; Tue, 8 Apr 2025 18:06:44 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qZTRLlZs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744135604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h4S0iD8/ZDdU57MHHJkBYxAwC6Se2ibjdSh4bG2ifYg=; b=VoLkCzeOkSflXt+6sFLR6NZfHBE89KGfTC4NYoPZ5No3RF8AwLxtl8JVdn8hqWAPM6Ti7k aCEgRleP248NyVV3dDSAf8O3/kfygfaV0WkOaa6IyWTL+x8zMsgtN15xJEkhQayYPijP9a TgMrs1Y/vzd4KR30qllwpXfdXdILnoU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qZTRLlZs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744135604; a=rsa-sha256; cv=none; b=zHEPEewnaheebb7I/xg+FmiotByh+XBIMX1WZ0Xt+wuX1hm9ivDEqxSNhh1/p3+cKCXGXt B2Mk4PiY4VRIv1tuVsTf2klS44zjvR0fNznQgkQHtMjQXax1twCmuv46C33E264lUa4+Yp jxxq12IHB0WZ0wDZ1iRBrv7lUCUwDWQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 206915C3AD7; Tue, 8 Apr 2025 18:04:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4529EC4CEE5; Tue, 8 Apr 2025 18:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744135602; bh=Tp1KLkGydqnHF26lk/Kt0Weyj/mcdsm8Zy6mmUhq+L8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qZTRLlZsgsR2ikOa/87ONS7coMzrc9mQFK88J/FCDu4fbyg4rMW9QHcYs0EyeojPA p8B9V7aznJ0rCr2wJXhiLnnxpcXNCwhAXxafIFjA3lRZCTjsDLD8nLDe5i+cfymVzC AbrGm890ErR1Jysv/8XD9PVOvKMjI4Uga2lTWuW08MoRdNofGbbSLpg6bstfH1ss1U 9wtvy8mePK/+dINHjjT4qdRqwEJClrtoxctv4cAPzd3A4vt5K3OApxB1GLk1Uo62SB bhzDWg3AS7cyKAHBlYSWGtvy0smd656QjTCkiWR+n9s1wjoJ7UrRMLDNCP1H63vfrD Mh2rhPNo0BuOQ== Date: Tue, 8 Apr 2025 11:06:40 -0700 From: Luis Chamberlain To: "Darrick J. Wong" Cc: David Bueso , Jan Kara , Kefeng Wang , Tso Ted , Ritesh Harjani , Johannes Weiner , Oliver Sang , Matthew Wilcox , David Hildenbrand , Alistair Popple , linux-mm@kvack.org, Christian Brauner , Hannes Reinecke , oe-lkp@lists.linux.dev, lkp@intel.com, John Garry , linux-block@vger.kernel.org, ltp@lists.linux.it, Pankaj Raghav , Daniel Gomez , Dave Chinner , gost.dev@samsung.com, linux-fsdevel Subject: Re: [linux-next:master] [block/bdev] 3c20917120: BUG:sleeping_function_called_from_invalid_context_at_mm/util.c Message-ID: References: <20250331074541.gK4N_A2Q@linutronix.de> <20250408164307.GK6266@frogsfrogsfrogs> <20250408174855.GI6307@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250408174855.GI6307@frogsfrogsfrogs> X-Rspamd-Server: rspam01 X-Stat-Signature: 4pjne5ish8shick7rah8c3soajxqbghe X-Rspam-User: X-Rspamd-Queue-Id: 3BC14100011 X-HE-Tag: 1744135604-868655 X-HE-Meta: U2FsdGVkX1/9jQynRW+V07SP+cJHqF7RYhKI3f+z5rNMvyTXwL25Vxi7EsPsq8hI9XSO4wMIv3izp1ntYrx8LKMgFeRJ90/UYmDeoMKHtf3pdWpuzMsr2AJwvbiWepAYxv9pvLCnxL98Bc5+Xtxl2Sl8nlEOgspMuFx1HoI8b+ruqI15YgCzaaK+jZyANtHr/XjhJnrt+Efu+Pww1+RhJXp4V6co4lb+4pcg44xHbyHzDF0lBrq1TloDhVCCntbOmci+J2828h/XcZjLRXqxPPJ+EiPbyq/murJ/Dc6QI24Ezm5RC1xk13AzZbVv5Ju5p9ICBet6E06S8arHgiWM+OCMqCLs8qpE4+Immwfd+aBD50tDDornTM358viRKyAXnbvDs6Fy9YxT1/Bl8pLnpWx/LcQ8+U6Ead3N347TVhJ4xIdpzowkXoqwC7x+xM3SciYlNSHMfZgRQxenZrQGiM/7pMY+9Lif1wijUkISeOB7EoklHyIGQc42b7fkduB64iFw0BwZFtxZu+oGzpbB2FR3kpXIUHYXHzZJUIWuZRtQVmFSeby4JijPO8tN6+surmlVhMGJk013K7GC/w41AZaUHnZ+CLmS+OYBfoufxbUtl7klQX/6LnLeGxrDBzv82udVyplQJ6ZzJl3nZ89jaArmNE2hHsonZCvexxRY6AVc6WSYlMYa0uaOUNz+mFzBtd6m5ejPQkxeFw96p1TASJlRdGsfVV3ZAJffzeCBUrCFbmNEc23lzrNOTnGY4yklbsQk17jTvy2U5yVMdlmuS9tWkxhbUNpuk0sOETYFe0YzpFNjpMx5yZBo6u4oMmWNGXAi4/keFkggVdf0gfPhWcGIIjSSHMwKFTqMR+AvIbr5tRHy8jRraEuarCR0BQrrIcczT9ZOmA2U5Hanf0Zf0Dg+4nLhfbgJYql0sDlUqaOuYZVT8pUeXf3WRNg//8Nu37QeAu4TF7QTW8suP5b GWbU7s7b Vj4gw9T5NJ+R5HQ6yWQoMN4HlNPki0B6hZdyDoScqro+IhzYcGb3tyCg+SjcrwEP6JKJizGz6RhqNhWwH65Zi/FZ1xaTurEaV9IU0cOjRtepZsG36drArUTinicx4R7oDCZvggf/IHd9UU0Rq1M2wkbr8rATljOms1cOVr2nRjMsZdx/3HzZlKzEMUj6IspK0A6zFXv/VtbVB99zUwvXKg/GF6yxVJF9T0TwOhGfpZJIU2hM3JdoUjuLIYva2940XqLXpZu+BfJxD/ZlOpKZRulBwR4N2Og87wv7sha/h19gEVjBiEhQ1+PLa0ZZuZDxWOgSJ19aUbw0rkdEOujmPeTCNa88WuPV9n/HC2Pavh1QliTKg8wBzasLByQjY0EGv306Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 08, 2025 at 10:48:55AM -0700, Darrick J. Wong wrote: > On Tue, Apr 08, 2025 at 10:24:40AM -0700, Luis Chamberlain wrote: > > On Tue, Apr 8, 2025 at 10:06 AM Luis Chamberlain wrote: > > > Fun > > > puzzle for the community is figuring out *why* oh why did a large folio > > > end up being used on buffer-heads for your use case *without* an LBS > > > device (logical block size) being present, as I assume you didn't have > > > one, ie say a nvme or virtio block device with logical block size > > > > PAGE_SIZE. The area in question would trigger on folio migration *only* > > > if you are migrating large buffer-head folios. We only create those > > > > To be clear, large folios for buffer-heads. > > > if > > > you have an LBS device and are leveraging the block device cache or a > > > filesystem with buffer-heads with LBS (they don't exist yet other than > > > the block device cache). > > My guess is that udev or something tries to read the disk label in > response to some uevent (mkfs, mount, unmount, etc), which creates a > large folio because min_order > 0, and attaches a buffer head. There's > a separate crash report that I'll cc you on. OK so as willy pointed out I buy that for x86_64 *iff* we do already have opportunistic large folio support for the buffer-head read/write path. But also, I don't think we enable large folios yet on the block device cache aops unless we have a min order block device... so what gives? Luis