From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E0B6C3600C for ; Tue, 8 Apr 2025 12:49:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5FDF6B000A; Tue, 8 Apr 2025 08:49:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0F216B000C; Tue, 8 Apr 2025 08:49:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B0C56B000D; Tue, 8 Apr 2025 08:49:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7A9946B000A for ; Tue, 8 Apr 2025 08:49:49 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D21CD1CA36C for ; Tue, 8 Apr 2025 12:49:49 +0000 (UTC) X-FDA: 83310858498.21.C5D8484 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf19.hostedemail.com (Postfix) with ESMTP id B050A1A0012 for ; Tue, 8 Apr 2025 12:49:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WERNnnpT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0e6k+DqP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OQ8ybMv1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OrAaAqSk; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf19.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744116588; a=rsa-sha256; cv=none; b=5cy2IpEuj1a531yepon8GFXzahPFji9+w7l4QlbHSSgis4+8YiIm+wQ86rSRcCxluRk/os kAHqrof0442vLmOLCYb1kD4/P7zBnc4Ege2lL+cTFVU0jzhfcVvcGmgfChavIJoUs95Ck2 9g8tBPRrMObo/hrIYCLAgAozLyYJWwU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WERNnnpT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0e6k+DqP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OQ8ybMv1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OrAaAqSk; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf19.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744116588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P5zMIUf/aj6q3SKRrmU7YoUI1fIw3u1hN5+0Mrx9/Jg=; b=UyPRYRKe0b3Ob9P4yNpACB5bncevlcXfy1Jmljhn73QqCYND6LHSp/ZuWvdVbeQm6EEHLQ /sO36hJ0trKUiYWO/6ynPesaPjqhzDV+bq0sqmg1VryVZji/kayswCFYEm44y6hPxLlo8E cKrtfpogvo25m1AS+0Si4gaNedQLisQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EC38321186; Tue, 8 Apr 2025 12:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744116586; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P5zMIUf/aj6q3SKRrmU7YoUI1fIw3u1hN5+0Mrx9/Jg=; b=WERNnnpThQMaIFrxN5WARut0+BisWisdIAspRt7xsps/VCoLFwNv3i6H+dXTqyZGfQnVwX jm9IB2kwRI4hSocsN2dCbi8IhNMTQBmxg8RZcdUYHXpL/UEakEQx4JImtaRqwwwMRd9fdU PMoU2hy6lvRgRL4k7l0NR/aI5Zg2sVY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744116586; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P5zMIUf/aj6q3SKRrmU7YoUI1fIw3u1hN5+0Mrx9/Jg=; b=0e6k+DqPZPlx9rBenoFr5tw2Qy2GTjrlYDUoVUEC6I+jshc08PoUZsYQ2mp/C2p3Isekcz lEorM5E6/5E/p1Dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744116585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P5zMIUf/aj6q3SKRrmU7YoUI1fIw3u1hN5+0Mrx9/Jg=; b=OQ8ybMv1L5Jic5/jjeZ228l3CnI+uzK6QsswZGEGhr7UFug9EtYXnAuxiBRpjncHw089lG ikcgGGyx+gvYVvATJJoUuzUFRMYA99BLhdv48msHS2JWg9iDX4FSgQtNIsScH+8xok520N rgyqswEpfCVB8ZXX3KPagsGFLfmb6W0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744116585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P5zMIUf/aj6q3SKRrmU7YoUI1fIw3u1hN5+0Mrx9/Jg=; b=OrAaAqSkJTMBqEN073m2gSqZrUoErcXMtiOBnFEZYE7OW09Zg6RvTQPur4hVK9fRCimB4a ZBcKCODktAmsXoCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 67F8813691; Tue, 8 Apr 2025 12:49:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zne0Fmkb9WeYJgAAD6G6ig (envelope-from ); Tue, 08 Apr 2025 12:49:45 +0000 Date: Tue, 8 Apr 2025 14:49:43 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Harry Yoo , Jonathan Cameron , linux-cxl@vger.kernel.org Subject: Re: [PATCH v2 1/3] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Message-ID: References: <20250408084153.255762-1-osalvador@suse.de> <20250408084153.255762-2-osalvador@suse.de> <92ff4f7f-90d2-48ab-8f7d-7fc3485276b5@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92ff4f7f-90d2-48ab-8f7d-7fc3485276b5@redhat.com> X-Rspamd-Queue-Id: B050A1A0012 X-Stat-Signature: 1rdyyeb7auu676ze7ckh79mkr8y178nd X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1744116587-921938 X-HE-Meta: U2FsdGVkX18aLwIqU04hhwlhCoW4ue48Qf9YlWYzoCwasan8OA/HeKchCV1Uq9pU3yjsRN4BOHs/XpaqX/6m4VSV+p9vxJ77ALkfdIRz9NyRxfw1/sm/LceuKrdfVQ1lRjrgv5UBW5o89eS9LhbLcbkda0Nj3O+AjfsNNYU3juOK468t64GsvhaUYs/+BpOKvAWtj7+/77lXa3xJ39u/S+srnhtVV6uhfmvE8/ukPgBl5UEzLX3GTsWNcmAJXzNUI0d/nhKvsTbfOj08O/AZ/aEzp4J+gYEC/uYoLRyskl6CJfizdxg2XyypvPIspE8WO+sZp1/wdVL/Pcuy3XdJrpRNn44d6feGIDEwDy60HILf7O964cFPqCFFfrwfkbCkUdc236D+xQzEj9LCpwQgWqhULgN/eTUPJewHOwAT/aEtt0E8l8gNT3rY9Xqc3tnGJWwPZEog/XT9jFRW/13FEtKGRgQ7IxlnZQbRJfwLrSczoZF/QE1ptbX5gZETmJxSDFvBCAKvgY7DR2d2fKU25SvkNkshJiX388swqC4KooSf9qc6nRJPZX2l+hluM+5xpterCn3fCm3sjIVCPckOmAWjhk+sxw249FZIT4P2ZjyTaFWqtjIg7G4QFIHHElJEorTrEPgHWKQNfmyPw12jTbxA7e/VcqSLip6cJI0t0V9JWzZ4acSdGY45tlfhr5a2IbbJEYDnY1CSiQwzlBCBdXR5l7qNwrEcgHgGuhLyS2yUeiqqmhQ4KDuf4/G+bqhfGAyDtDWAly5wy9oOucZZggvckzCfZm3S9qV4cpDqLkE1Hr8AfO9TSv/bFD/DqHz5mMZyuROds9OJE10SUWDUgjFT+Me3QPZJmgJ9/ZqQD3I+KmHak1VYQMpvKSUoiOOIxbs5Cpb0VBrqaSymbQryNHnI0g0a2ZgwAj93JfeMuZ+OhXRj3qNiD2okh42fEJ34X6LTJb9aV0diIQfXd7E 8XbfVirT wAnYhYT10MIck3cnETDTRya0csKWUQ7Sfm9fMlI0nln+gukmJ/t6zGcaYwsecKoKcUACJNTMEk39VL6H+iGezJt7OZmTBAlB9LyloYLgYkHddZlqLRFNurLStiCNH/VeqxHUU3p8lSzRySSIO8TuP/NccBKMOUlJOGkbaUoEyLZB85zE5hpJm1Pi3iRJ9UQXkfbSULRbAyJ2jmJunaow0J5odS6yWT3LLv+7dpID0o6l+R2BMnjAs06XeYryUGwd8tjFg91m25hJnLHF/x1VMU4OT/nWhcW75+xd11zwfdOdMs+UReGQ5w/iSkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 08, 2025 at 12:17:52PM +0200, David Hildenbrand wrote: > Feel free to add a Suggested-by: if you think it applies. Sorry David, my bad, totally missed it. I shall add it. > Do we have to take care of the N_NORMAL_MEMORY check in kmem_cache_init() ? Likely it > would have to be a N_MEMORY check. Yes, should be N_MEMORY. > But, I was wondering if we could get rid of the "slab_nodes" thingy as a first step? I glanced over it and I did not see anything wrong with it, just a question below. So, if Vlastimil and Harry think this is fine, we can indeed do this. If so, I would combine this and the #1 first of this series and add your Signed-off-by as co-autor. Is that fine by you? > @@ -3706,10 +3698,9 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, > if (!slab) { > /* > * if the node is not online or has no normal memory, just > - * ignore the node constraint > + * ignore the node constraint. > */ > - if (unlikely(node != NUMA_NO_NODE && > - !node_isset(node, slab_nodes))) > + if (unlikely(node != NUMA_NO_NODE && !node_state(node, N_NORMAL_MEMORY))) > node = NUMA_NO_NODE; After my first patch, slab_nodes will also contain N_MEMORY nodes, which makes me think whether that check should be N_MEMORY? -- Oscar Salvador SUSE Labs