From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CDFDC369A2 for ; Tue, 8 Apr 2025 14:45:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0C156B000A; Tue, 8 Apr 2025 10:45:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB9856B000C; Tue, 8 Apr 2025 10:45:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C81076B000D; Tue, 8 Apr 2025 10:45:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A9BB76B000A for ; Tue, 8 Apr 2025 10:45:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7F59F16100A for ; Tue, 8 Apr 2025 14:45:43 +0000 (UTC) X-FDA: 83311150566.02.A1A6AE0 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by imf27.hostedemail.com (Postfix) with ESMTP id B11CE4000C for ; Tue, 8 Apr 2025 14:45:41 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=gJwPLIJ9; dmarc=none; spf=pass (imf27.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.182 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744123541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GXhtl/J93/flobwWnEYYmzPTVSjnG16U4TGmrJDFslk=; b=KfGhC/h0fXnjDrK6qMHYta06Cs7372+WW5mzlNQgHlzemJE6cS+3oYD+0Zg2j8i8Og+dob 2maBk3GtlFG9aDXU7y+zrAHuLj4Sb+JVRcnk0hQRDCelLZzD5NqToqcZvRrnYQuTo0wdrX wO/hSe3DnogRVhYh7Vqmm048k57M+i4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=gJwPLIJ9; dmarc=none; spf=pass (imf27.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.182 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744123541; a=rsa-sha256; cv=none; b=s6V0+5du7saWNdWxlQP6iyoe/JsAeUh8jnH0Q5WuchBTu++pkYeMGs/nrLYUYt8D9Sl3tI jklL13fxIXYhFy41LFax6SzQaIutXVoSImyox/QHPtdcy2uU0MXlBvp0xFAu5QlA0QlbRh gmnC+RMKLuZ33sg2RAhp2O/8BUr0wOA= Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7c55500d08cso532197785a.0 for ; Tue, 08 Apr 2025 07:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1744123541; x=1744728341; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GXhtl/J93/flobwWnEYYmzPTVSjnG16U4TGmrJDFslk=; b=gJwPLIJ9BweqZyfF7GFNoHc8w5NiBDErNTwSGtK/mtvA7qB+BKs5zzeLrBi0Gal/9a eohfJyavBma6NV0WuZkbpe/OiPWBA/KDK5iRqaQLCdqZYBrF8H5naAo+lc0YHhBRJzp1 +3lgSysrr53FdttgUVoWq68271aosZLzsHk/uUhOlik6XCuq7tEbYggpkiB09Tzi6W2+ sVfTH+SY07w5poNbuuoHuvNaEF689CuoqXsAqn9egzvPZMeIMfKdjIijDyDeBfUZMPan yxC27utWzQC6wOwrjDTYgoemEb5dH1un8w/24YgW7Zh1d4BAu5ubEBqykWfkj7csHGsa hFzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744123541; x=1744728341; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GXhtl/J93/flobwWnEYYmzPTVSjnG16U4TGmrJDFslk=; b=Ahcj5lS11Og5mIaFZAuPmhd7xukgW4UoSZDJYCC60jLpj6qwtAmXPEn0tD4z9fYyqP SDFhL6CbL5GxALSwdpdE+b6JvS4Eco3WgOnks7shYHFhQ1jnwGFMlZyBSWBmIcVIwcQS uQg5UvOYEKr0xYh68O4P1UB8Xl0Iu0/hm73bCDVYN62PRjpsbe/+R06gOT5c4RS1fwbd RRbXaTPZkDQpl7Qxw2YB+HnxBHj9IKI/wIBK+bEF2Wh4ukiMCtUitXOimHYcBqhRuh8z F3jCUIUtoV5TgGZmDqg3tH4pk7c/10exuDWMXUFv/tKN66+KO1TrBLdYjZAzFdVcbGRo rJMg== X-Forwarded-Encrypted: i=1; AJvYcCUIUHDVuPdxmDZcSlH7sXfz6XRBdfxjzKcrzW1rkJlhAFldRxVC1KAEj6WyYddc55bnnURY5DxvVg==@kvack.org X-Gm-Message-State: AOJu0Yz6v6feJIwoa1UTp0q/DOKtUc18XmEspoZihlzBVZ2TM3rOXGpg Ny9GI70z0ULBbIBzr3L5GlAcS+xmsls6uLFfgXjISojz/w/RKmP51TbdSo9+abs= X-Gm-Gg: ASbGncsLyiWJrDCbuuCE0DiXGsG0MxiL4dE/BQDhkpEZ9lLBP5apRjlcczyx4x8hoNA 7LAhgeMZKXlkI+hJi/VqQnK7rvbyAvGtluPJ44hhE/wVGjFcArbfg2tYGlMst7Pg2NpPUjZDeO6 vVGNy04SaO0hI8uJmBAipgTBEigi/nFr0F5CY0DqtrmHPRaIkm7zj/JZp84mqmQA0JF3WwpBXNk AqMVnuhQoCeSdtV3F3Tc85wp3+BO51zo1Jwz3tR2PiaQD1duf32rtfs4yBYlqQ64Z/pamBH5eD8 dQFRhTqaKEp4G16KuXm/ItRq0qFO/Dbi0+HTDbQrY9y99hy9aSwcWP5MYUULdO77BdICoPREpYN vgGKsppvilyMEPljzfMEf5CPxZwk/auOup/C+TA== X-Google-Smtp-Source: AGHT+IELkfwSMv11q7mhNQ04DdBgUD6jbBVI+gQh4UyK0hWVyKNA9oi119Et85nPhE76OzCqXdS9nA== X-Received: by 2002:a05:620a:c4d:b0:7c5:4c6d:7f95 with SMTP id af79cd13be357-7c77dddd504mr1963810685a.48.1744123540676; Tue, 08 Apr 2025 07:45:40 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c76eab1667sm763544785a.117.2025.04.08.07.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 07:45:40 -0700 (PDT) Date: Tue, 8 Apr 2025 10:45:38 -0400 From: Gregory Price To: Rakie Kim Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, osalvador@suse.de, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v7 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Message-ID: References: <20250408073243.488-1-rakie.kim@sk.com> <20250408073243.488-4-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250408073243.488-4-rakie.kim@sk.com> X-Rspamd-Server: rspam01 X-Stat-Signature: ytx4fc9ucoq5pxsgww8ad3h6cmo86ean X-Rspam-User: X-Rspamd-Queue-Id: B11CE4000C X-HE-Tag: 1744123541-793274 X-HE-Meta: U2FsdGVkX18ptPKC+WNcAmCIum9rAIG8ty5Zvivc8V5y2nccWs1FbefQOnfrD2BquDAgu6xs4xM197IAJ7bGx9F0OxAu7q4KaapWeyBUbyiXXkYs51Y4KRPanaAk62x1hXHUcNynY8Z/2ezJP+gyv5Q2pWOgPao+bk/hTI3tMKZg3sOOkw/3gIgiTEd843JfBa6MzM4DXvFjJ+UymGGuwJjV8VV1t11bEzC173rxXKdX7ccchUzzYdUlkED7XgAj0bBq23cpthtD1EG5QVKWhNrqUkopRgPt5Qi8hFAuMLsizU8TUmC6E63+5b/OaxaQAR+QP3L8oK92q8sfR58VNiYaYheR/rf3EWjSkCPyE4kYDrv+PlGzqcSXbYs1haXOvRR2w6yeCvZy5fQPCqCNvMXKChyedtiOzpzA7Mj/cErItQLTGTgXr8tm4APSOQCiQMFzlQOcM+EvStQPWryqRM3hTsxGbaxH/Lot92Q557UHbtJgtP51ZoNk+Q5HahWgzcgD2k/ZE7PKuaf3j98BeFfa9aBGGsdwBcFbuDZPMgK91AWcsWLG1+8QdXRgZVW7LDZyuE9s7dDTOHZDoHmyePAESNO6vrVRPlgHLo1gQ4whClAEpzg+IXS5VQRgvRTGkgEFoWkw1s6EuAtDwgwjV9cx+UZ9kmYOuNw1rhMicWiK5kpf8DwtX85Aqiy1DySjPhyUZigNA8+7/9gt6heOYD9eY1CnXrm0RPoUsfLbZpyKS212XV5cZxO28uYKq3a3TPlw0IpYraYGYiW3A/+xZyKsyeZYlC2uN0RkxEXKkXyPmb9rTAQAqmwT+CxGW79J5KEVPC0sTvwuUEYcr88rtx4axtl8y8C6OR9WKowFKWf/D+KfAcfaqirYpHf2amVphvXNQinU4URn58XJnygd9vwqHI/Fmh5K98NwVy1paAHpojheXQaUsnJe4e5cfwjvHPVVZRfptDX9a2aVPn5 ezYVqmBp B/M/AMmLtydRSvq91SSHo/oL0LV8di95pxAQLx2e0eoqjPFV6igWYKRiLBALCvk9efLk4r/7ENZGONcWrU/4gKqxWdnfWhXdg+soZ9tBJs7anjqY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000125, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 08, 2025 at 04:32:42PM +0900, Rakie Kim wrote: > The weighted interleave policy distributes page allocations across multiple > NUMA nodes based on their performance weight, thereby improving memory > bandwidth utilization. The weight values for each node are configured > through sysfs. > > Previously, sysfs entries for configuring weighted interleave were created > for all possible nodes (N_POSSIBLE) at initialization, including nodes that > might not have memory. However, not all nodes in N_POSSIBLE are usable at > runtime, as some may remain memoryless or offline. > This led to sysfs entries being created for unusable nodes, causing > potential misconfiguration issues. > > To address this issue, this patch modifies the sysfs creation logic to: > 1) Limit sysfs entries to nodes that are online and have memory, avoiding > the creation of sysfs entries for nodes that cannot be used. > 2) Support memory hotplug by dynamically adding and removing sysfs entries > based on whether a node transitions into or out of the N_MEMORY state. > > Additionally, the patch ensures that sysfs attributes are properly managed > when nodes go offline, preventing stale or redundant entries from persisting > in the system. > > By making these changes, the weighted interleave policy now manages its > sysfs entries more efficiently, ensuring that only relevant nodes are > considered for interleaving, and dynamically adapting to memory hotplug > events. > > Signed-off-by: Rakie Kim > Signed-off-by: Honggyu Kim > Signed-off-by: Yunjeong Mun > Reviewed-by: Oscar Salvador Reviewed-by: Gregory Price