From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC934C3600C for ; Tue, 8 Apr 2025 09:40:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28188280002; Tue, 8 Apr 2025 05:40:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 205D2280001; Tue, 8 Apr 2025 05:40:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A67C280002; Tue, 8 Apr 2025 05:40:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DE2C1280001 for ; Tue, 8 Apr 2025 05:40:35 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C6ACF16096C for ; Tue, 8 Apr 2025 09:40:36 +0000 (UTC) X-FDA: 83310381672.14.501BD90 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 91512C0003 for ; Tue, 8 Apr 2025 09:40:34 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c7kcmOvD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=BsnSN175; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c7kcmOvD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=BsnSN175; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744105234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l3p5sLGIP2X+bIKQwxkFToIWZYHS0thNE8Wr00aRmuo=; b=IKbWN3rZ5xRWpz+PjPtoKXz9O0jvL6dE4/H+rRGFK9JPXg+Te8r2nH83QiwteTDStezk/D TS4uC8UsI+JmU8PVpm40zVf17cf4pfdN8+eDmDk42azA0F/76wtjuWRUrzarFDOqO/FUse Y8hADQ5A5cRLsmTCdZ9MeB5LlArWSPs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c7kcmOvD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=BsnSN175; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c7kcmOvD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=BsnSN175; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744105234; a=rsa-sha256; cv=none; b=FZg5LJ7izeSlRayb+kI6s+LVWgGyIc9+2AJu7uSRTRrtSpC3XLTjbOxJi+IxqF5u8SmeiV hfMZ24ZoxfroIrhXVrP3BjeMtxMxbjPtmnNSPsmnFnaCw+XoXfGp3SPPqU4iBo+v8Gp6XR XXXajkpCeVuKA5g8dLpay9cuLnxf22I= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1B31F1F38D; Tue, 8 Apr 2025 09:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744105233; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l3p5sLGIP2X+bIKQwxkFToIWZYHS0thNE8Wr00aRmuo=; b=c7kcmOvD55KO7JBs+GQ6pLPC65XtRoDBvIn/4LR/a6HJX8a4rASgygAam6B4LQMIQ9YZNo QYhLLSV2LUZdpzYrJtZBD3uvAj3CJmizfmz+BmwsxMtg3j9YJXA3NJ0eUSUCjruZc7UkRh wOoXvSVWu2hrFFbuWBX13179Mt16d9o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744105233; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l3p5sLGIP2X+bIKQwxkFToIWZYHS0thNE8Wr00aRmuo=; b=BsnSN1755pVmWtXzTeJSp0Pobu31O6gwkueisB8Y5+8tXZGNqWUbr6cFZRmEjT1icgWKF3 S8bHLk9cMAOuyADA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744105233; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l3p5sLGIP2X+bIKQwxkFToIWZYHS0thNE8Wr00aRmuo=; b=c7kcmOvD55KO7JBs+GQ6pLPC65XtRoDBvIn/4LR/a6HJX8a4rASgygAam6B4LQMIQ9YZNo QYhLLSV2LUZdpzYrJtZBD3uvAj3CJmizfmz+BmwsxMtg3j9YJXA3NJ0eUSUCjruZc7UkRh wOoXvSVWu2hrFFbuWBX13179Mt16d9o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744105233; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l3p5sLGIP2X+bIKQwxkFToIWZYHS0thNE8Wr00aRmuo=; b=BsnSN1755pVmWtXzTeJSp0Pobu31O6gwkueisB8Y5+8tXZGNqWUbr6cFZRmEjT1icgWKF3 S8bHLk9cMAOuyADA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A421C13A1E; Tue, 8 Apr 2025 09:40:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nFCLIxDv9Gd/aAAAD6G6ig (envelope-from ); Tue, 08 Apr 2025 09:40:32 +0000 Date: Tue, 8 Apr 2025 11:40:31 +0200 From: Oscar Salvador To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, mingo@kernel.org, yanjun.zhu@linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable() Message-ID: References: <20250407030306.411977-1-bhe@redhat.com> <20250407030306.411977-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250407030306.411977-2-bhe@redhat.com> X-Rspamd-Queue-Id: 91512C0003 X-Stat-Signature: npj3boy3r1fdnpyfb1mozw5k1fu17zqu X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744105234-237346 X-HE-Meta: U2FsdGVkX18DIHJDWKewIFI6mkLUX86+yzNPSEXUFpK4hGJ/vukEXR8EOiuS+zJI02f+z0IF+ZNMDDSAexAbfTe+iPlJbzgaqDdE5X2YWvw2AOY8QiLJMCr8kaaY2wTcIeplWu1Eo/9hNmVW3jSw58dDeATHjeeQOyVaO8kn+78LnjazQaw966FROgohxsSqQ2Myi8B4Eb2Apvj5tmzN3DtotopT4hhgoJN3m0SsI0wIjbnwWKo49JoLqUUcEllmtnXdM3V3ZYsIwrhLDJsIRupuBae5sMfsmFbThB66/ZsdLzz0HBvH4rR548BRZvwqz5yEURwlbBHLIsLB3A6aV2ijtleVRh1WbXGoiba1vBnFfed17moOOzWBSkxw9pVWCMI814Aci8RjQ1pFn0zV1yZe/NyfUWjX/HjcW9yWxk+OwyU8+ALwClSQnqDz0goDqdo2uGsqeyMwnF2I3C/6o0ADFwtgXrft7UGtxRSY5L0gWvs2C33K/rnpA3Z64gh7RRfmHxXKtUgkoOc/JU/hJaX5f2+wbzGfntR51NLyZSZR+Qnr8JtH9Vpyh44KUuAFihHMneFXxJitgz8hzRxiMk0zW5PDMhEVCRQ9sY5hXjiGEEvotLdCcTg5htB2objpkeG0K4ogRCq6xoV3cUAv7dtR6ZXbaH+EGplYRW3h9hG68LIFofmaRF46/LeFCjTjPv5eYOCDlmGk/W3TFOUYxrcQhw6G9ZOpnjD0BtoiMtvymp9gUfFPrFO8tiY5v0YJZVA1qBssEvTK4zn3jXmKdcjlRyLwbsq0jQdoShRti3jA8r2AOHUunrMA2mcy2XNShIMDWp2kOb+uYyl1joI8M5dYx3QMbD/g18F5IeRSDTT2ToOY0Lx45m7pdI3BJPNnoxCufdIiRGPtm1iUYKWSDXPYLG6nUElHehbYqw8M2mt+NnM/s3GwQPVfRs0jic9R/a/1AszfjxQF15JDh5E wTepdHQx ir9Ydxirjt2GCPscLTUeuHA14XQqzWMbSUwHCNQQDXOtPWFiWpQoGFxdvX9iS+HYI5a2yydltdHOVcueTc5oNPwow/feAfQw5/yPJenWlQ8qgSmUhbdmw651+mXEjhjo4Bk/zPacdgi5ovNZwYO89KULoSLf1JwZB1bguLElZCyEeWtiFR76b5F9phfEAfR5mIsIO1aM34ne8pM3uSyjoYRMSZTnWTjl9crY1DMR6CEwUOwE9+yv/6kVyFpo4azOrmfFjY96aAjt7EdVBZO4JwIN8sj7Ciii4YxU8jKJl+zIy1LAY9mvXNV2lSLf1uN1DCgOSffLMyP4Y0ck= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000029, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 07, 2025 at 11:03:04AM +0800, Baoquan He wrote: > Not like fault_in_readable() or fault_in_writeable(), in > fault_in_safe_writeable() local variable 'start' is increased page > by page to loop till the whole address range is handled. However, > it mistakenly calcalates the size of handled range with 'uaddr - start'. ^^ calculates > > Here fix the code bug in fault_in_safe_writeable(), and also adjusting > the codes in fault_in_readable() and fault_in_writeable() to use local > variable 'start' to loop so that codes in these three functions are > consistent. > > Signed-off-by: Baoquan He The fix for the bug in fault_in_safe_writeable() looks good to me. But I think that David suggested the other way around wrt. uaddr and start variables in those three functions? I think he had in mind that fault_in_safe_writeable() follows fault_in_safe_writeable() and fault_in_readable() lead. Other than that looks good to me. -- Oscar Salvador SUSE Labs