From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 272F4C3600C for ; Tue, 8 Apr 2025 06:02:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEB0A6B0026; Tue, 8 Apr 2025 02:02:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B97A56B0028; Tue, 8 Apr 2025 02:02:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0FCC6B0029; Tue, 8 Apr 2025 02:02:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8447F6B0026 for ; Tue, 8 Apr 2025 02:02:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A9795B8771 for ; Tue, 8 Apr 2025 06:02:08 +0000 (UTC) X-FDA: 83309831136.28.D856FDF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id D35581C0004 for ; Tue, 8 Apr 2025 06:02:06 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eaj1IaAq; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+416fb8959d6b6dfa49be+7898+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+416fb8959d6b6dfa49be+7898+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744092127; a=rsa-sha256; cv=none; b=oM8Bba9hfsAdx49oORn77eWF1AoaWNS3Bb7FwV2jW8Uk0Xdjb650UZFNKzHpK+womwRFcq 47HT4/eJUZ94Hbu1nn3B3zxPyvLDpL+bqhw8s0Tm1cLZgNQZy/uz/LLXiA9RPukZdHu5LF Y1vAX0ZbcMRQUTKxEtrSCHCZynCMv2A= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eaj1IaAq; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+416fb8959d6b6dfa49be+7898+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+416fb8959d6b6dfa49be+7898+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744092127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EDvhmqcm28EGKlWvqvv6BIg+rBPoOk4uGE1wigR7x3o=; b=MTHsR8oUGIf4I2Cdd5DlvtLrzEPnILYgYgMkijyFko6RfxCe7gomNcgszEsmX5fy/i6KQF Fz9GYEWOz0nZHnk20ApDRnrDm8dPrncTDDRpICmA9AdV6JmUrAdU59Y8NWxM+CkpZz7qlu Kxb96/QWmpd2Z32G+jQ62vVA78uDO3M= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EDvhmqcm28EGKlWvqvv6BIg+rBPoOk4uGE1wigR7x3o=; b=eaj1IaAqJLIbwH05lY07iozfAP FvaFhZ8ycdvdRmono/f4bzqeelSUDKtVyi6N76cV4Agkxr95sZdYny5LOdja8Aq1oSTcAdLs+axej w4MABierkL6xejGfPy+ohktMFwQBE52hcO4vFZwpmq54PJ1vgRJK1CB4GR4ngrBlTFRc+9yNCfbWO ZiVBwVsAfXeQjL6bCG3SeO8E27oeD7YW+SbLhpq1+Z7k3C25WQOYytd7rrY4ag8z5//HEFVsC76hV K7oezNLUkf5XqD8Gy54XMP2HcELF5NYwuFI6sXJXSpYPEa8oKvTA8LxLOSiXgRMY0rHMvrNAtGh6Q 6rBy0CQQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u221q-00000002qK6-2cV0; Tue, 08 Apr 2025 06:01:46 +0000 Date: Mon, 7 Apr 2025 23:01:46 -0700 From: Christoph Hellwig To: Eric Naim Cc: Vlastimil Babka , Suren Baghdasaryan , akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v7 10/17] mm: uninline the main body of vma_start_write() Message-ID: References: <20241226170710.1159679-1-surenb@google.com> <20241226170710.1159679-11-surenb@google.com> <0d36fd53-b817-4bbd-ae38-af094bd301df@suse.cz> <40182b31-95ad-4825-9c0c-0127be1734a6@cachyos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40182b31-95ad-4825-9c0c-0127be1734a6@cachyos.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D35581C0004 X-Stat-Signature: qjkkafmouupt5ewnhmwj4ihwekp8sd65 X-Rspam-User: X-HE-Tag: 1744092126-700654 X-HE-Meta: U2FsdGVkX18VIocjidThm8Jm/mJ2zZbGM77D+zSPXVNSfdT/9ILGTdF/Kqptlv+henap888pHFGWwBVER9fXn1Q1Sfzh4db+3e5C+MFpFn9cAtD5lzKTcCqEqlJbuNCofarRSyWxweJKxjVNGalVKPvt+ucNysC4mnfSecGrmBnXKnllVVFQPgnWiKm57TXEafCpeR5zXptt+l/RFJ5rnGxwRrZkDfAjhl8bULC2Y4binYNLI61YE5ccugNKjnHKfE6WC0EYDZbVDfmkmpRmlNhDo1tumakYkIAZ+TkoKPf9lRVHeQNEbT3ly0yyekYYOcLg/cgXonWt+02JGoHWaYUVlrWRqzQXm4LZOCKMZ6NBh2UBpjKX5/31ZCHcUq6Ri7FeEzab+HRHqdkRiC5v058eNxivfjvjdTkRkuVFfoUFsT85q4/sYdcvy3bYY3zC3iidayLhF5Hi2y4cxS3Qhxyu9j1jLXesp/XzcrOPfQyz6NnKET6+UL+1jFJOS/Zg/NmcVjfOe4t4xGZ2Su4O+0EArI25WBXpRl3HUK2gzonfAc9bObvtlq6dcT7HDu4Z0bp3h53uWalGGEqPBLuFkwX9S+8laOAJ4aA4UtuJaUX9ML1xitTZm6aBNAIQfitAR3TeEeFSQC742Gj+gFiECEBnYFTDov9oUH9s/BvdYtrlugd0cM0mY/rr/QEnWUzw58iOL9G1Mdct2Cm8rzhzHFOdU/wR4RnW9MDE8G8HWaUXnoa08CSoRwm/v3o1y+1DubHp9/LiyKa+f+2Z5p01QmdWnXt/OAL7+0UNQ+MfEpLonsTxkAGFCPtDPIv3ABMT47A6VQnf5ppTsJ0MEY6v0AKnr87cTPs+g7mF0FBrXCsNQ0Iadi7HSCtwv0ELxnoUAspkK3kYPtVZFYquSRb8blm6FBHSnFZ2wBzkrqYPGIOF7muaKwOSCxd+oef1SZ7WzOA19oUcYVGmXvFteLg lbUFFvU0 fJLE4ftCyN1v1ubylWeynZI+YbMDfX+XRKlVKU9oanoc+gLEFZQt6Pufsb2ZFqHQETYZ2W+fQ6EWGsdUpdD1KVPvYSktQIISM8bP5rz3mcxbfpjvHzSBHDftrYdZzK0KU6M6kwh4YwWgGDep9hHqRU7nwFeQYxipVeY8msv57Py3T/D/b/6yUO8zy64FZde3E+4KgjTzAyyPT7GWMjoHf1OGjOHd6KfFlqjPycGTIyd3gvr5MYJakDNAnEH3giJoUtujSUA4ZPW0uqa0hkO+3rKGTA/gdOoyAC6trJ7NIcfIZvChSaH19lC+d+PN9zOhL4ojvKeblmRJAs53PZ8UBZ4bWt3hM1e4ACawQRrNfef5IyKm+3s3GajlRdSCmknNySAaFmD+DRCthHmxxJ7/aVouhJyDIHL6GN1XJdMXMFYgPJM7x53z+qWSlm40w8qYrMZV78RY+6k3DpJY1y67VHOjOKzgAnkqbImpAjhenQTXNY4OrbtjLk05I4SMT+4nCHWCsU4hjjHtoHt7BFEY3Kf4t3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 08, 2025 at 12:39:25PM +0800, Eric Naim wrote: > The out-of-tree NVIDIA modules seem to rely on this symbol, is it possible to use EXPORT_SYMBOL() here instead of EXPORT_SYMBOL_GPL(), below is the modpost error: No. They don't have any business using this. In fact vma_start_write should not be exported at all, just the vm_flags_{set,clear,mod} helpers.