From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A89AC36010 for ; Mon, 7 Apr 2025 18:59:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C1476B0006; Mon, 7 Apr 2025 14:59:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 949F06B0008; Mon, 7 Apr 2025 14:59:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E8FC6B000A; Mon, 7 Apr 2025 14:59:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5DFE36B0006 for ; Mon, 7 Apr 2025 14:59:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E1CF61C7AE9 for ; Mon, 7 Apr 2025 18:59:53 +0000 (UTC) X-FDA: 83308162266.20.0ECEB3E Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf04.hostedemail.com (Postfix) with ESMTP id 793FF40013 for ; Mon, 7 Apr 2025 18:59:52 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ikd64YAq; spf=pass (imf04.hostedemail.com: domain of mingo@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=mingo@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744052392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W9646qA1pWcOR1Gt7vnx0MmGLO/CCOY1OYvGDXpEtUg=; b=Y4BjFeUcIyvbnoagppjWNFc6BxO5JRAx0MhddbMwNrSGEBAVpMLqAqv66X8+acHsvuiX/D /0+HDnTVLAhHkpvBng9ZjlqFTFbHGB9vPYw7Q00kuK0SkGwxh3RhqrsoflGT6tBQ9BZBHT VAsuPvhPfmtKkDwKXief7d0TytNTLUs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744052392; a=rsa-sha256; cv=none; b=DO7Ny1k7GCHWgef1vp76tpT/vSa8b5J9CUCTLW63XdyInpZniUOImcLrHHvAHBeBJ9BmR1 3fHfOCG/CXNXTNYqS+EC0yeNDWDf8cs5w3/6v7TFYwz3Sp9Sj1en6PshQpm5zuqLW2LwbJ C28c91xwJGJv4W4x7jDRlQcO/7/XbMk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ikd64YAq; spf=pass (imf04.hostedemail.com: domain of mingo@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=mingo@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 0DF49614BD; Mon, 7 Apr 2025 18:59:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06AFDC4CEE9; Mon, 7 Apr 2025 18:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744052391; bh=eaNf30YMHU7BcMuCAMDNJprm7z6isxLdGxhhr3Wr8Q4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ikd64YAqfbipeTl6hXDFg9UtK1ahIqbijdiME7QobH7eGGfFYEDkcTbIA96k/5RbK dZxLtRnW7kn5GPqkUWVOAClRXMXcARNivPZIfTrRYsZpl2hC2LeiO8VRdnmHLcTBvo 79awVyWWeU/0Y847Cheh8sRU0tRALEq1jrwyTc1CGEKOQCnREC939Poj/ZYam5BCqI kw5HRw9OIM7NfnsvVd0FHjs2eUNOolNSSjRmk8Aqf83OPOdTAhhWUkXIzhr3AjxU4X odNLLyxa9m9ilw8E4jY8ndnncqhcqS9YgGJCt9O6CYifyGRrNYQcNvcKyX70+vniky KASmKhk5gMbEg== Date: Mon, 7 Apr 2025 20:59:44 +0200 From: Ingo Molnar To: Dan Carpenter Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kernel test robot , Dan Carpenter , Andrew Morton , Lorenzo Stoakes , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Rik van Riel , "H. Peter Anvin" , Linus Torvalds Subject: Re: [PATCH v1] x86/mm/pat: (un)track_pfn_copy() fix + improvements Message-ID: References: <20250404124931.2255618-1-david@redhat.com> <630caa8e-2ee2-4895-9e4e-8bf2fa079100@redhat.com> <4961949a-75db-4071-a478-fdc543c1dd28@stanley.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4961949a-75db-4071-a478-fdc543c1dd28@stanley.mountain> X-Stat-Signature: mnh5d1j9caf6pnoe3gno6uigben81arc X-Rspam-User: X-Rspamd-Queue-Id: 793FF40013 X-Rspamd-Server: rspam08 X-HE-Tag: 1744052392-164546 X-HE-Meta: U2FsdGVkX1+iN1VjWNd8ulIXRItyJ+eyt124Fh+eWf69PImwXwhZjMHKjKmdpjK7xS93lB+pJog426UktcdyRL5NoIo9H8Yz/4sCiJBRUjzaGfiqpiDWwREmqnDU37XS1/F16l2cAkKEbzqTgk0PdLuvme7lCtvqNGLRa0a7Esn64P10RcymbceAQlDAJcX3+pF4AgEIZLq3/oWOL3u6JG/sZJ2LP+z+6TsuF4Giw6wN6u92Oe350W3or/ccLbw5Kt7xPEhICO57DOio+66vMV5ISrQYqaOorLtCUVwJRr77CHSHPMk+FN1A17DTTRXPDbrrj23VhZRfmXVqNPnL/z8OHk6TTLbK5qwkWIHTipWx0m0PZW45kQIzYT/n3lsIl6E3/SIkBjYb/bOpnBqKu6lWG0Ldn/OPA9KzNTCX7uf5PtZa+i2PiREqymvQfkE5WJX5RYoZsqxlRvZdW2IFhNAmYFRSRJXv/A1T0xHPlO4ukA7LIcWEYTuFMnjRPP57vqjAOawGOZgwLVr7yaOy+DJu9k2dQhe05j7U2DYSFOzMgCylYPhYMoRZhx2Q8iWm7eD95qfEyHaWkUDYzMljY+qKzJC48mZ3bgHrXfye/voCuWloakyHaUJ29nIEBwI7t3ttfNKoUHoOqJNPgvc1owxtTU3dDM4Qg4Dp6w6720myW5u1KwEB8IzKKX82fubxaCVZcsuH5KzhfIx8Yn3bO+3oIccPdFbGBWmXFNU7emxWnZyZ2WBRkhNbBmWjLdswcex1OaqYaum6bOr73g/aHJiy0tig/wHqsCnKYOUzuHxlQU+KwP/DJisIfH+bNfAG6Ojh+AoO2dK0s1cG2hU1YEvJzEAvhIWFpXMGmqhhtGhk743P8Y29CO5BgezujyML/EXztJJhwodwgkNbWvXErx51R9ym/7o4uudmkuD/k7htlM3PDEBlnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Dan Carpenter wrote: > > least for non-struct variables. Even for structs I would > > zero-initialize and *maybe* allow a non-initialized opt-in for > > cases where it matters. It matters in very few cases in praxis. And > > don't get me started about the stupidity that is to not initialize > > holes in struct members ...) > > Everyone sane uses CONFIG_INIT_STACK_ALL_ZERO these days. Good, although why is this compiler option named so weirdly in Clang: CC_AUTO_VAR_INIT_ZERO_ENABLER := -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang Hopefully it is named thusly because Clang has adopted GCC's -ftrivial-auto-var-init=zero? Thanks, Ingo