From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EA8AC3600C for ; Sun, 6 Apr 2025 10:37:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 081166B0005; Sun, 6 Apr 2025 06:37:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0056B6B0006; Sun, 6 Apr 2025 06:37:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC1CE6B000A; Sun, 6 Apr 2025 06:37:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BCA7D6B0005 for ; Sun, 6 Apr 2025 06:37:24 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B5AC0B09EC for ; Sun, 6 Apr 2025 10:37:24 +0000 (UTC) X-FDA: 83303267208.21.E8943AD Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id A64C54000A for ; Sun, 6 Apr 2025 10:37:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=F5IlVpZb; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nhjH7ia3; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=F5IlVpZb; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nhjH7ia3; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743935842; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m9tB4KiUFVwHhvJCfi4QInnIoxcdRheNTWxyx6ac/HQ=; b=pPoW4dTmNuqqr6oG1R5Sg+9QXUvRD4tcOOBxhczAPPQ7E5cSwZqOXIzkDZ8uLEWA+L9RT5 JtiF75/VD54tjO3VqcjsvCBSt+PJWRJk6W37t5vDXUXSRe86aRg6j2OjOjKe5CYj5dLt6P tSQv4ARVcx0oOMYk78k0666mhsk+mtQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743935843; a=rsa-sha256; cv=none; b=1s9eJlq7yXEyZa9iEevUJ5WtUAyPGlHQsiE4v6ELdYeQdyypPdWSaFZq7WbWCuKoHo6ssP dKDco2X0wTGsIiCoZaW8pMJu2Hq0aUV+ag7KkdZg38Ku1wcLqf5LoThyNQhxNBlZOQty7C 6pBzdi1WTBoVL8KP92IxFgTkXlVo6/M= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=F5IlVpZb; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nhjH7ia3; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=F5IlVpZb; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nhjH7ia3; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3942A21184; Sun, 6 Apr 2025 10:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743935841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m9tB4KiUFVwHhvJCfi4QInnIoxcdRheNTWxyx6ac/HQ=; b=F5IlVpZbbbzWRT5TkBWpbx4rKS7bi6/OU9rjuiMSAvfVRxDjeSRmPuBNtL1mwgJ47zMPaG GrIka4q3XuG9p83XLDXBGDvvh4xWrbVbobjn99HpH2eOxTRfc1vEkrwSwfN7ttkv6sQ9ga V22++4y/qVy7w8zD3MRRyxi2u5vlYfY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743935841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m9tB4KiUFVwHhvJCfi4QInnIoxcdRheNTWxyx6ac/HQ=; b=nhjH7ia3PPMzPyE8a2b3k3d4v8B+L4omW1n+XLf9ztNqHgxXTMEOEnN8/Ll5QVDjBBwbR+ idC0/r8QePlhbpAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743935841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m9tB4KiUFVwHhvJCfi4QInnIoxcdRheNTWxyx6ac/HQ=; b=F5IlVpZbbbzWRT5TkBWpbx4rKS7bi6/OU9rjuiMSAvfVRxDjeSRmPuBNtL1mwgJ47zMPaG GrIka4q3XuG9p83XLDXBGDvvh4xWrbVbobjn99HpH2eOxTRfc1vEkrwSwfN7ttkv6sQ9ga V22++4y/qVy7w8zD3MRRyxi2u5vlYfY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743935841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m9tB4KiUFVwHhvJCfi4QInnIoxcdRheNTWxyx6ac/HQ=; b=nhjH7ia3PPMzPyE8a2b3k3d4v8B+L4omW1n+XLf9ztNqHgxXTMEOEnN8/Ll5QVDjBBwbR+ idC0/r8QePlhbpAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C5BFB13A4B; Sun, 6 Apr 2025 10:37:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qv5+LWBZ8mf+ZwAAD6G6ig (envelope-from ); Sun, 06 Apr 2025 10:37:20 +0000 Date: Sun, 6 Apr 2025 12:37:19 +0200 From: Oscar Salvador To: Jinjiang Tu Cc: muchun.song@linux.dev, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com Subject: Re: [PATCH v2] mm/hugetlb: fix set_max_huge_pages() when there are surplus pages Message-ID: References: <20250401082339.676723-1-tujinjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A64C54000A X-Stat-Signature: roocrckrdcy5gs86wcq47ykn1zrbg7j5 X-HE-Tag: 1743935842-539746 X-HE-Meta: U2FsdGVkX18nj+OQioqU6ha2lwVy8sRVSQqr/W1pis4kL+XWK9xavRTHKr4gcr1xyWqW8HxpDpCWJPM3kYL38hHNlGmoTKV0eVP6Xfm4V1+YeXnEu5DkpYSVuUllReJDQqReYBTFzZXhMVJvHxUZGl+PSW3ObKUyJRLmzbH043JlAnHuTepo5mJNQsSBw6v5aFkB5ynNJ2xccjb2GPGbR6LPgyomne/MbQmIXxF0HxC+HV2FquW96GMm+MAYMOim+7SAzd9z9c4Ab18Td0YJx7LETq+5/tKKTeCi9R3ZpgosFP/Sr77Ec1KhmeqiKkGraPe3z0mV9QdRRiNti/IeLax0P+HHophtfJKuV3XaFIg7u+F+FYrEDLCtmD4TDSqt3bXExJrUvsjJq8fSyED1A0z/w9vabhRMVxIquKy8R9h8EMaJ/kD+x37AF9JC5swQ79KWWWCU3hjdY4gM7YnNWD5RQv/24SaV983TcrCxRj5aV5foFKmPRHGlYRnmTaBKVgIVwKTIZ/Bi7WVUh9fed8/7PMMebJGV6nWJaF/3hEqJAPvM5qEGU/BPVFNlQlbDJNYXTWCydaKqMXqmCPFVJ80L5JQG91Aq+Mimk8GJIQPs8ha/s+fGzjMPGjEXegc2p6u7zDZmpkjjSZ+AJbPm7WYQdDVgeMjsgtiiyZtL/4JA6hkZP9ENoKheHDoJWH02kisk7XDCcSlgqN5z4vuAJ+fFPseqaE0jw7Qxae9U85/wiolJToFDzKXOki3nbRz4DGTaS0C8JU1pNJq+LZeea1Hrdn/GemLf2O7qvSVAUmqPn7/LNAwJwtQpnhvhvs+aKEDM6dlJJJ41l7zfxgIxVsHmdQ2dPgUGnFMDv2drSlHVc7w0+VmfbEqlgzWmtK2iFAebzPlW4d1lL23+8nFZNo7TA+W9NCNQ17OF3mcXlE//QcFCA865VIjle73XlCHOKKUltC6nKOE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000279, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 06, 2025 at 12:30:43PM +0200, Oscar Salvador wrote: > On Fri, Apr 04, 2025 at 03:18:09PM +0200, Oscar Salvador wrote: > > @@ -3960,7 +3961,12 @@ static int set_max_huge_pages(struct hstate *h, unsigned long count, int nid, > > * and won't grow the pool anywhere else. Not until one of the > > * sysctls are changed, or the surplus pages go out of use. > > */ > > - min_count = h->resv_huge_pages + h->nr_huge_pages - h->free_huge_pages; > > + if (h->free_huge_pages > persistent_huge_pages(h)) > > + substract = h->free_huge_pages - h->surplus_huge_pages; > > + else > > + h->free_huge_pages; > > Ofc, this wanted to be substract = h->free_huge_pages. Although I am thinking that instead of playing smart, we really need a counter to tell us how many _free_ surplus pages due to hvo failing to recompose back those pages we have at any given time, then the substracting thing becomes easier. -- Oscar Salvador SUSE Labs