From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F616C3600C for ; Sun, 6 Apr 2025 10:31:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D86056B0005; Sun, 6 Apr 2025 06:31:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D33676B0006; Sun, 6 Apr 2025 06:31:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF8036B0008; Sun, 6 Apr 2025 06:31:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A1D3E6B0005 for ; Sun, 6 Apr 2025 06:31:04 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 738C35C72D for ; Sun, 6 Apr 2025 10:31:05 +0000 (UTC) X-FDA: 83303251290.30.EBA8C8B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf27.hostedemail.com (Postfix) with ESMTP id 4E2B740004 for ; Sun, 6 Apr 2025 10:31:03 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IfjiIlZ7; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lLVx7dsP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IfjiIlZ7; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lLVx7dsP; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743935463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GRnCK/2/5LupbNbg0GB6YQ023+79NGRqwRLw4d3n9ss=; b=0356DpdwJnEpvPDxuIBNcfxSg8OqTm6PlwpJf8PsXUrEVCrtoClwa9nah9NOHcmhpe/aak SQ3mCobsIBBApbTde0BGbqWu3g6/JD1bZuZzfNSHOIraEcKbfl3cwrGGwuF0lMRF6Ek15y aLdBAg0I1WYZTo7LT2aJYACTID9AhUg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IfjiIlZ7; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lLVx7dsP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IfjiIlZ7; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lLVx7dsP; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743935463; a=rsa-sha256; cv=none; b=NxxSiad1Jw4kpdECMHR4e6pMw1RtjYT0SMT2AkgBPCEvlnRbawtwToaJwibqyYNJMs/9+G u1xOzl5WHmMuhr2YgYIxgDm0+30+sUIki2096bNSZM0kWttqHcUM+kb1IIuxPlpeI/nDKY fNgTp5DWKlm7qZ4vWTe6RAUlY2nSWJM= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 520C42117A; Sun, 6 Apr 2025 10:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743935461; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GRnCK/2/5LupbNbg0GB6YQ023+79NGRqwRLw4d3n9ss=; b=IfjiIlZ75TE78YOOEshIoA3Td7vW5E0bgBOQBAqWjo1yroxaM/bIXlf0SfsyhRGRDtmJ1T jNEiwsYRw2j+eQVJ+lJDY+geB3Ss0lBTiLIQ1a67nJgOtyb+9uyAYq6GxgYHYhOOUq+Myd Z+PiPe85SR0zPY/oMvPotXmu9lLXdV8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743935461; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GRnCK/2/5LupbNbg0GB6YQ023+79NGRqwRLw4d3n9ss=; b=lLVx7dsPR+fU2Feh0f7BFj9rk2lrs7UN8OJnZG07ZsD0P5K1hzAE6+K3D0ecu8Dh8X3zt4 6zekA+vEl0iYT+Bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743935461; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GRnCK/2/5LupbNbg0GB6YQ023+79NGRqwRLw4d3n9ss=; b=IfjiIlZ75TE78YOOEshIoA3Td7vW5E0bgBOQBAqWjo1yroxaM/bIXlf0SfsyhRGRDtmJ1T jNEiwsYRw2j+eQVJ+lJDY+geB3Ss0lBTiLIQ1a67nJgOtyb+9uyAYq6GxgYHYhOOUq+Myd Z+PiPe85SR0zPY/oMvPotXmu9lLXdV8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743935461; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GRnCK/2/5LupbNbg0GB6YQ023+79NGRqwRLw4d3n9ss=; b=lLVx7dsPR+fU2Feh0f7BFj9rk2lrs7UN8OJnZG07ZsD0P5K1hzAE6+K3D0ecu8Dh8X3zt4 6zekA+vEl0iYT+Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D8B6213A50; Sun, 6 Apr 2025 10:31:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oKLUMeRX8meaZgAAD6G6ig (envelope-from ); Sun, 06 Apr 2025 10:31:00 +0000 Date: Sun, 6 Apr 2025 12:30:43 +0200 From: Oscar Salvador To: Jinjiang Tu Cc: muchun.song@linux.dev, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com Subject: Re: [PATCH v2] mm/hugetlb: fix set_max_huge_pages() when there are surplus pages Message-ID: References: <20250401082339.676723-1-tujinjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4E2B740004 X-Stat-Signature: cbjqp1b5ay89dfmqudptnggsqzoacht1 X-HE-Tag: 1743935463-64418 X-HE-Meta: U2FsdGVkX1+2+CwRXjHjs6WJebP2623S85IB2zrtx0wM9H1jnw6FLazk46rnQpx0t53XbpqjyX5k7tCuTgewq9Ku+znCJdM24kagybiCu8FUNyKoKGmGnOW7ZsG+pzSTEYAoF8BQEkF7KtsktdhVQY+lh7I1kJzQh2Pvq3hrX3o28yrXp76hg3Fn5vSDCKzsev3pGnFtJOMc66yt75+4/LzD4+w2pQQDlKIw+PTZLHHudnBWXpoOv7N/GqPSOxXZrzC2uvDgQRs6+Qk11xHuNTdLeZCtbMcBEtfAJzPHN021m9e0NHAFyQ145tHmIBuoTun5ivJ9gM1hNoj9n/exKJCjAIKmjKYWPjrODMh6sspPI9pC1QSLkQ84ONXULwuL6MBRARrYilcfQ504MvtKyF548npHfaSRtngdHm5cd8v0xAS1idyO5nZIGaYWcKaY6nIo+SoJJ/L/K/bW7xOYICXle3OteZ5Rl9culi0uQqDNplgNXEfs1UGrDtIXH05NFo0rKhJgB+7eBxrE4udhOyhg2ReSE85yq4RV79HWZjurPO0HyM1dDvN0IuI6Z8tYg2SlTgmwd/j2lKJLvnqfY0jxqmi9/VAVcHZV/g7/LhjkSX5l90jFpfkwFR4l/qLJZtaKUr3+V04XHg0eSzwaWhxBBsMcsGMQlXqbJ/Xwfl8fwukoeL7oJl5+g7DmO8dm+QimHgxm5Nku0tQD7YvggUmnc2kpsyjnsa9XTxdqblv2g3BCABTWGSf3IMyKU5lsPdNaC7MFAilFcHy4PNx9t0/7XDsCodW40Waa4OSJ1Dlx89HnQBExK8Uup54f46kbA/sXBU46uCOe6WQjwvd8UjJ9FHIN30R5IUtCHlhWW7kq3uJwMW7mbCksOsDx1zoQKek9gccWXec77ug0y3QbSAuCqVJCIwGk039sluQ7+vA6s2g2jQ4eS8XDq8ztqfPE0BGnMr2QOIzPcIUsruD hNgJOFtw vOB15pB2RpMe8r8LsHpN5ikjJNA8tdCDwTTIbGXIHKRnbfwcPHPKtjlAiOpl+/rpHIHKnlbf/sY8OuxKonTIYDjg98vtBBlmRiaxVBjkjmHgDhiXS2rn87dzjkgd3OQaUNHqEhie3riY2UoxTkQHBoU/bIiQ6n4MF0MgU7Ugl7Ql3rNNTuhfp+7g6IUapmmWdIKlPYSOvlLNgeFnR3aAALf1DgUFg8DmCYjHW9EYiHgvQ3ENNA34mEWexNNzf8mpHFEQr2NnmUiPHEiDqDQwj3q2zmzML8Jc2836S1bP1Beqro20zCM4313fSAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 04, 2025 at 03:18:09PM +0200, Oscar Salvador wrote: > @@ -3960,7 +3961,12 @@ static int set_max_huge_pages(struct hstate *h, unsigned long count, int nid, > * and won't grow the pool anywhere else. Not until one of the > * sysctls are changed, or the surplus pages go out of use. > */ > - min_count = h->resv_huge_pages + h->nr_huge_pages - h->free_huge_pages; > + if (h->free_huge_pages > persistent_huge_pages(h)) > + substract = h->free_huge_pages - h->surplus_huge_pages; > + else > + h->free_huge_pages; Ofc, this wanted to be substract = h->free_huge_pages. -- Oscar Salvador SUSE Labs