From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C399C36010 for ; Sat, 5 Apr 2025 16:23:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 134906B0006; Sat, 5 Apr 2025 12:23:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E41E6B0008; Sat, 5 Apr 2025 12:23:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EED196B000A; Sat, 5 Apr 2025 12:23:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D1F3A6B0006 for ; Sat, 5 Apr 2025 12:23:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 633AE1A146B for ; Sat, 5 Apr 2025 16:23:18 +0000 (UTC) X-FDA: 83300510076.22.A168C2E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 7E5F1C000A for ; Sat, 5 Apr 2025 16:23:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gY5FMrpt; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743870196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=51H4DBdNtaQaW2P/B/Tj+hCm6+P7TC22nEECZ6yf2Ss=; b=i+3AuV5kRUuYQgKseaFkdJ+eEsaExWNIdkJ+YETmzfOJUIypBKShglLqEBOU3KwXeoVi2Q lkqyngZXtTIk3LAzX+ob7FnsbEvYioPk2hfYsc1UvfNwjdEe/BaW2NKkxJ5hnYfz4bJ503 t7PuvhXC/BmyafFLQHO+nylCm8t1q0w= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gY5FMrpt; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743870196; a=rsa-sha256; cv=none; b=4Cq/5+g5JFVkDe/kmvuDh6pj/prREe1S9z5AL+hzz/rcZK2Ld/5Wis9tfvL44pDBEb5zrT ZtRK1kGOTLMfkHuF6ZSarAm6Z7AAGIi714y/uuWGfc+B4qfHh9VUSqEb7g0taDC3SFUVCU 1VidKzfHAFP/FWDWMiTfEnHESGkr7pg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=51H4DBdNtaQaW2P/B/Tj+hCm6+P7TC22nEECZ6yf2Ss=; b=gY5FMrpt99vpoQq5zifFxYYOLR UiwCIhj7+6nLg4OP9Hl2WYto8vqsQ/drN1hQwIllWv0o/Uo37zTZGbsrdG+PRNttzLB0EdrI2Lq5Y GZeGV1l1t2nVqgU0Yj3kowIS1IyJFJ+7GSsEhaWOU6ACbJRDagEZZhoDXr1rzbqgOQ7lzgTXeO3KH YXzIaUKG7oR0b7YBkZJUPrnMRHuH9NNOGleRDYUVep8VkJ3D9i5E2TdPuvDDX0pBkPmex4JkcbWWv W+qXj3i3bNCt6EkFjLggYI/9mb4C2mD1woYuX0Lk9uptcQ10Jf+c6znFNCK5QEmB3hJZJo524i6ZC /cho31sQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u16IV-0000000411K-2BVS; Sat, 05 Apr 2025 16:23:07 +0000 Date: Sat, 5 Apr 2025 17:23:07 +0100 From: Matthew Wilcox To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com Subject: Re: [PATCH v7 5/7] KVM: guest_memfd: Restore folio state after final folio_put() Message-ID: References: <20250328153133.3504118-1-tabba@google.com> <20250328153133.3504118-6-tabba@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250328153133.3504118-6-tabba@google.com> X-Rspamd-Queue-Id: 7E5F1C000A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qas4k3c7nyeqwyh8ajtqq5wibx5zhebj X-HE-Tag: 1743870196-502793 X-HE-Meta: U2FsdGVkX18dnp/Ga25bT7S1Ixv4B3YWaoJYIeynMs8b8m36XfrnAE+p2G2nvXn413Ibqw8mTW6ndRaGX8OjBzIIuUsKNnp/pVT4+ekv0u/AkUZKPGDGaEPj2+0P+yWAw3nhK3LfCbl+gCBt76WthL8DtsgHabiLtSP329rY3861QxNElC9RTGSaj6CnpwyLmA+92pMQBEqUBHosbs0n3AH5JgvlvVAGvR4hr4Uv22JxdZND6a5vhwh0+LhNtYInr3eJLfJeeNG0VoICriC2/7G4WTCbZ5y3qhTyLV3IAUKCQI3dJ1cDpSTp4/F10hYbS5ppIAaZB96TyOtU1xqUnT6ITN6ZQ2d2KnXggmV2KeRoCjX0xDPDG4nmWYjuegcZyO2B3o+4vAoAuJkN9T2y1bOUNXPXRPXIJcqbsegw3P70j+xcAx8rRcnSu325azyz/kZNrMOJQZx1N3D+k4rdNdTA68sPwDQaYk+mUFribkO2FlRLcSS1re0zbzJEs0iM910wATyFAG2C5SH82aGEZQT9Ay7BbS8NYLwd3QeuEQaZB49wXFtYrqKs3eA96K89ct8wllZ76VeEIU14z0dJF48msM5IwhZojPU5ZSejjpe7652Hcp8fgeOOHP8VPHPMHYfkeAXSgJeHh5t/VaBNyWlHydHUV7X/moQEjp50QjIiOaW90FMO30iwIHi9q6cl/vGOS5fS1Yv1qU0KTmzL+3OkKNm7YI3cn46n3+7ysH8JqxkaHfimhjkQuMJO4zTbE+vuK4ZxdD4B3FvUJ0X26WGfOdOzxdxgStZwmx2rzPcs3QGa5vK+pd1y5jVlkwFXU51DZRSbJNAOCBZ59gKCEuHbYYeW/MVzElLymxdCpQQvNUCSpt75KBZhNz7812FE9txQ1waZO59TDHiDsIV8xKrdy2cTcsXYYap2yAoBaBCmIEj10rz3dkKZd9WtmYAKew+iLPKkGcSTe+YoJaX WWcEynB2 Mwzgrvt3dFZKo24nm6AF8SyEtTSQWOsZxfbx1K2TuoU3dXWtklj+DUNTyjoaPd0w42dZACMVkYNYfZzf3In5JixjcFW2Puv64lMk3A6XPCp4LVtnG0HM4ASpCNLcM0Fp6QfRYtkMnYM31uZ0TRTOH+fjts7ftqTOC27TytMjO7KuJQui9R5XTP6ncr8hRddT/vgZiCKufZgLzMlSnXTOA60zn+iEnc1D9KQXj5+n+Yg0xIzlzpgiF9P85z7TDYO/EHhTDqG6fOP3ci3O2t093GAAJPsYBxolc49NyR+il4+IQAbSy3h3obFQtymXfya7q4PZZqs6+St1k4d2klYi5xJOaxxqQzShRudGO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 28, 2025 at 03:31:31PM +0000, Fuad Tabba wrote: > + write_lock(offsets_lock); > + folio_lock(folio); write_lock() is a spinlock. folio_lock() is a sleeping lock. Do you not enable any kernel debugging during development? It would save you the embarassment of sending patches which are obvious garbage.