From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E34C8C36010 for ; Sat, 5 Apr 2025 18:38:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07FC16B0006; Sat, 5 Apr 2025 14:38:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02E1D6B0008; Sat, 5 Apr 2025 14:38:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E11776B000A; Sat, 5 Apr 2025 14:38:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C0D046B0006 for ; Sat, 5 Apr 2025 14:38:25 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0B634161430 for ; Sat, 5 Apr 2025 18:38:27 +0000 (UTC) X-FDA: 83300850654.10.2EE2649 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf22.hostedemail.com (Postfix) with ESMTP id CD835C0009 for ; Sat, 5 Apr 2025 18:38:24 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="GYs8uc/k"; spf=pass (imf22.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743878304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sl2M++fvRVUdrk0PUNelzDx+YAZUrNZAMRr7cMe/F+c=; b=kpLGzJ9ZB+b9ezC5ByCZA6rTvxwhEusYnYahxv9i38T0ttTxPB+0nBdXsSoN7vPdLN4uNY 2eskoWPRoYOC5au7kr6dhwdgpHT6xax2apO8FH3ZwWwnoQXkrwsXtJeIpcH6v+6CmmCDca Gg0o8XTowzW7pZDw7xgxp5HnHHZxChk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="GYs8uc/k"; spf=pass (imf22.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743878304; a=rsa-sha256; cv=none; b=gIAYn1UUXNr8P1Eb40owrARFsgyKxsu6/C2H4VG3L7uMVOIspNBXCWPjrxDyQRVNexUt6X EU2RnpWJyNAVpgqXLYP0i2/W3125m3/LafEy1Tw6OYtALsrZyI24zrqLAXLDcwGwkp1ykm nzfMHful8jraIzM6/5n/DbTOp/vD1W4= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-476964b2c1dso54436281cf.3 for ; Sat, 05 Apr 2025 11:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743878304; x=1744483104; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=sl2M++fvRVUdrk0PUNelzDx+YAZUrNZAMRr7cMe/F+c=; b=GYs8uc/ksLbW2XpnLJdafx6z2SQbkQwO1zZQesjxDB0GcMjdd0RHJ++vmIpCvcIo3H eNC0wtEyXQ92CR0/4RLfsKzfTL/DGkaK4bxhQwW8BbKRTu+aQTbygOTOniBmWg3p43xb ayQVqr5kzsspZm+X/I2ArqdD0s82X3yA3aw9gIcJk5W7KGHsCAtGwGeNUHEbofg21A8o uzYrEEQ2pSzF8xepN0oIedPwiCLYkUAd4NB5ccnPOf7+5DQgExa5dVlZar+6B31lm2R8 NCkVTcA0HHzroOgF8ObPfh4C99skCCjK0U58QY7FHR43Es3RYpBlTcWF9nsjHKyjCZAw 0i2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743878304; x=1744483104; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sl2M++fvRVUdrk0PUNelzDx+YAZUrNZAMRr7cMe/F+c=; b=dtlgNLxzsXKJy2HihwBigIPOJi/vpXxawjIu2X2wKiVEdLUpyDtulUTEAfpxAmZDnM cjCi0lLRQvzSHwDkcKqr6RN88xePnhQHnsZAtD88xNY9Eo1XWGz2M9nd2gUhmS6pBKH6 fPWFOxIQR5qN7Wdqk2sXlxHxt8BfgurdVq9KXFdHrs35mLnz0knWp1Yb588ORlmmeaEc 5lVl2weta6OHtZ44wurwClOmaxhA8GkBVSarA9kXzKCT3mm79AwuB3cn2nLLJXmGujoX C89Q4vPfE4aDH6Z6GlTsNHwG9SFicTFi8N1D1886ZdOGCS6t1aVLRCJGHUPZ6DR78jwz 1bFg== X-Forwarded-Encrypted: i=1; AJvYcCWmDfq4iui8ZaSdmnDDl4qUFAU5YMg/9r+/i/ILEYIuJo7k6lX/15rYeCkaQmhRH1nd1FckMLIUkQ==@kvack.org X-Gm-Message-State: AOJu0Yy8C40WsUZJgbb3Xr71M+xG0Pejb6yGizqoZJ5wclm9irKJcHLn roc0Df8cDfO/moyjnyMR+PEnv/LDugRA63MK9D7TSTUV7yU4Szmv X-Gm-Gg: ASbGnctbYE19HhdTxBdZjgiX2ApecqiN4enqDIwDn9hl4i788jZXu85QSXUBEvFBswG aA+NOtPRySMGjCULYX+NG2FGSZ/jXLpKUu7Ta2v5n9pV24N2mk3KCkffDKjtnhYhyWb7/IZX82L EsH0l/kurEHKFBvO0ekg43H/uyfYlbltI14VOQxbNAW5CBmfjk+2xp5WF6y0++dBn8oR6fBsb1h X+og3FCeIvmLJYkH8r+LsxLEME4x/iyAdoN+kPKd8v5JW0fTisQvaJDs5K66v28epys+9FOadoH jyuD2KD6PEWdo66kUJQ9ts2PN/U0MkdYAtmD3yoDj1RG8T2qgDm8hdxQMejDoB47HspDdhaTrLo ajS4aTF/2oEjbn43j5vM7xOdYqtE6OLDJNYU= X-Google-Smtp-Source: AGHT+IGQ+VniDYYVVkdPFpff89YQ2tB+gwFWi/omtRKMHBspF0ohm6pDkZK+xQOPlmxVk+aP3+vg6A== X-Received: by 2002:a05:622a:f:b0:476:af21:9d4b with SMTP id d75a77b69052e-479249a7d83mr106849881cf.37.1743878303908; Sat, 05 Apr 2025 11:38:23 -0700 (PDT) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4791b0883f1sm38734551cf.42.2025.04.05.11.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Apr 2025 11:38:23 -0700 (PDT) Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfauth.phl.internal (Postfix) with ESMTP id A16D61200066; Sat, 5 Apr 2025 14:38:22 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Sat, 05 Apr 2025 14:38:22 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduleehuddtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddt vdenucfhrhhomhepuehoqhhunhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrih hlrdgtohhmqeenucggtffrrghtthgvrhhnpeehudfgudffffetuedtvdehueevledvhfel leeivedtgeeuhfegueevieduffeivdenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpegsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgr lhhithihqdeiledvgeehtdeigedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppe hgmhgrihhlrdgtohhmsehfihigmhgvrdhnrghmvgdpnhgspghrtghpthhtohepvddvpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopeifihhllhihsehinhhfrhgruggvrggurd horhhgpdhrtghpthhtoheprghnughrvgifjhgsrghllhgrnhgtvgesghhmrghilhdrtgho mhdprhgtphhtthhopehlihgrmhdrhhhofihlvghtthesohhrrggtlhgvrdgtohhmpdhrtg hpthhtohepohhjvggurgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprghlvgigrdhg rgihnhhorhesghhmrghilhdrtghomhdprhgtphhtthhopehgrghrhiesghgrrhihghhuoh drnhgvthdprhgtphhtthhopegsjhhorhhnfegpghhhsehprhhothhonhhmrghilhdrtgho mhdprhgtphhtthhopegsvghnnhhordhlohhsshhinhesphhrohhtohhnrdhmvgdprhgtph htthhopegrrdhhihhnuggsohhrgheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 5 Apr 2025 14:38:22 -0400 (EDT) Date: Sat, 5 Apr 2025 11:38:09 -0700 From: Boqun Feng To: Matthew Wilcox Cc: Andrew Ballance , Liam.Howlett@oracle.com, ojeda@kernel.org, alex.gaynor@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, wedsonaf@gmail.com, brauner@kernel.org, dingxiangfei2009@gmail.com, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Subject: Re: [RFC PATCH 1/2] maple_tree: add __mtree_insert_range function Message-ID: References: <20250405060154.1550858-1-andrewjballance@gmail.com> <20250405060154.1550858-2-andrewjballance@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: CD835C0009 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: hudnw5uiehm99x9yp37ham958qw78xno X-HE-Tag: 1743878304-479054 X-HE-Meta: U2FsdGVkX1+zOyte1ethAlNr/8LnLSRGa5bMYhuN50ioaoWdIt15oaAFyA9M0De4A8hZW6dDIXxCrbJCvRa7Olbnex8NTza5OlgrWhZRTG691f16xizXoBasBAzeBeaoNT1toFnEnK3nBdv75zcK6L7+WlueX/dl1oIj4KnnwhwhP71+lODIJIS4ejl5EFbRu2gd8FgAo+cnFIMMimJLQ4yVErpegDwU5m54EGNgjsNUlo88JqvgyuCiQdGVkKrH5MnmG4pCLHLdKm1GbtkzOZ5zTL2ddF0Tx7Ab9CFv77VLYhKbuJt8HWDMq9aSD/7mLRwexA99ggSBvBarinZjxRbTXAbxjQ0JzT+bHuxIZStdCrd8q0+J9L5svqykjVeNK5OjMkAh/DrzQhBnXvSFy5RT81NKVOJu59MlDJvKgWDxRwB6pYl0cZRsY7xn2N5WE9JPu8/Tk6+HJ0U/7EkR5Vm7TJ1RmNiqIgigR+GTG9O7LpQz/r64i3jrViqov+kGqcPQQ48r/Ikm9EtV8qf9YU0sFUqs1EcHe37NJBNTizm3qf7kZepWRWIOghJMONTh9lE6Cs1psvrbjxStNs8WSWBv04l4n5liV7LMh0Fzh9HAdh5fqssTwH/zH3cf3KZgMQmvjB2aJYutXKOpd9S+sN4oXUdA2v77+xwwspY+Lrehd/OXmupeFy52eC2YUWeoEhpXFbtlPY7CMOq+CYjrR2xQ9E4ro32tKkqEmzH9mKCtvGc4wX1GlW3osVC44WY7jpqxM3w/XVjjlIDW8ePQFSZdyrQppD+6gU8RUu1MQbD4ToH0LFLK42KkzAwZzxEHSEONe1RCNT7sZ8uyZlgHAhT2lYnOWslKQ3hlKzAgLH8iS9Q4/YOGHsaHyUJl4htgGZSgmpXMNqhF6RT9nbCGAbGTRz0h40mUvt+6gauDlIc9ZrkuWJedtrtD5XiCVTxMN0U6AbhU4TQA1TK6TSp 6Vb60TVS 0ChoGXILYbymwYRNsGJEJkG1ZpkiRtZUsV1WBZGe0AVQ0KgBJRR8JaQh1RXO3hFNWel+9vameBNzXSY4gCOK/c3SHO0TDHCtvQLbrvAjyHuCJVe2+BUTjbhVyZQghZH81XJ+xxpeLXeL2ujR3A2KANURTdixuAwB5RgBX69OJdZSiGNmtkF7TnRgO4O0KaL7c5wuPg5ako0Gx/MK8hnQ427Is3rE5ZN/Z1EnHqdkXFOGCPK1e9aNWEbIvo/sLWhBIpPM6JOz+gHY79a78W/PVNIR1VtarsZqYGJhrgQorjWdnmb51riS9vhHVHAKPwok0AX9klirv1vIs54P/Ak47HiO5qt4zLnbTlz4ZWfwXv0x3LgWLKmhUz4kaLCntNDpZY7QEU2xcqQGk4s7nkBu1B8lqdIZ8yMRlgmMyjapTp5M/g5BebDSxyk6sEJ0pPfCpYPyeepce8UfCTeCzb1qAskC1prN7PxYLHWCizm+n6x1+xAnBaldXmrwCr+WQHlxtOh5OedlRybNqKxoFaalyBLdGXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.306277, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 05, 2025 at 04:22:34PM +0100, Matthew Wilcox wrote: > On Sat, Apr 05, 2025 at 01:01:53AM -0500, Andrew Ballance wrote: > > adds the __mtree_insert_range which is identical to mtree_insert_range > > but does not aquire ma_lock. > > This function is needed for the rust bindings for maple trees because > > the locking is handled on the rust side. > > No. > > The support for external locking is a TEMPORARY HACK. I've talked > before about why this is and don't feel like explaining it again. Does it mean that ideally maple trees should not support external locking, i.e. it should use its own locking? (BTw, people usually add some documentation if they don't want to repeat themselves ;-)) Regards, Boqun