From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E80C3601A for ; Fri, 4 Apr 2025 17:12:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C9D56B000C; Fri, 4 Apr 2025 13:12:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 377EE6B000E; Fri, 4 Apr 2025 13:12:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 269766B0010; Fri, 4 Apr 2025 13:12:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0E7116B000C for ; Fri, 4 Apr 2025 13:12:38 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 44E7E57472 for ; Fri, 4 Apr 2025 17:12:38 +0000 (UTC) X-FDA: 83297005596.12.30EF830 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf10.hostedemail.com (Postfix) with ESMTP id 9ABB6C0003 for ; Fri, 4 Apr 2025 17:12:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Wf1nHGS0; spf=pass (imf10.hostedemail.com: domain of tj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743786756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BJ+76OJRrW9oAMaoal0qRDUOWjLURNrk++hSKO9BsxI=; b=tF3cfMHeC4Snw1WKOdPHmUohicxzwisUGTUFGZziyekAVgh5XpfwE6SJiEg3cXjl0LjVyC iiUaQqiUftBdHl4GSHnMVxLvs1T2VFAYFtbmiuSE3gl3Y6U/WGQFAj6wpwxT4URuduq5ko 7jCjRFZhGIzlcVGbQwId6/JSP7ejt3g= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Wf1nHGS0; spf=pass (imf10.hostedemail.com: domain of tj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743786756; a=rsa-sha256; cv=none; b=ITNjxXf80bWrJsssVBn0MulTOFvOkvOzqnvIdf/w5E2DhUFzfdMxsn9WXtO94mGr+IGsHw TROp2bt7IoiHtxoDKsjT1Q9cp1Os01NOPj/sWNDXdGxN86u5CMje8bQPo/XJV4ZwsgLvuO QzysOIo/bxkiVx247AZwjKXNAyR1YgA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7346668440; Fri, 4 Apr 2025 17:12:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60FA2C4CEE8; Fri, 4 Apr 2025 17:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743786755; bh=ORCLl6N1YVZ27ya63jZI4ynRwB7ykB32+2AH1oNeqQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wf1nHGS015wz+9164yfmKeRrVusoTrmZ+YPYFFpD+AlLfJy9ePo1O1eqviCc8Ril9 4/pA+B4zm+rOEi0YrP8iuNmJ4mIB7n1aLIux7rvVIYtYSts2t0lC4goBbBX3Bcti8d xi91t1atYsPsZW+8SF1qPJO9YdXN4Zwl4CAxUBvYFlM7JEl8kENQ/o2iaFrDuU5U8n uwkKZwyOCk+x2tX2BLaAved6Ejj6kzcCgQnU+fMcsLSmzT1V3fmbimoZ2zA7DjFATv eANDjaab8sOZ8IG6LqQ15j5cdGgs2m16D8ZyZhSakLKO43yk6e/Wz5PPlMpGLckhvZ JyDf1eFH3ZDHQ== Date: Fri, 4 Apr 2025 07:12:34 -1000 From: Tejun Heo To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 1/2] memcg: Don't generate low/min events if either low/min or elow/emin is 0 Message-ID: References: <20250404012435.656045-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250404012435.656045-1-longman@redhat.com> X-Rspamd-Queue-Id: 9ABB6C0003 X-Stat-Signature: n6thjfw5d1wot7joq6gcsggxws14h9ii X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1743786756-43451 X-HE-Meta: U2FsdGVkX1+SKTSYN82VqT0Mybm1hnc8bSVS99B1vBTU2ZL8tqTXY7Khi+5/HRl7x9WFA1y3vb2hMourI3QZXcyVHfxlr//NRw0fzgk4Ujfc5KHBOuGnzmkcNmKyiimKKy0mhnMs4L1+x5+ny58xw6JUyintnzOzHehAaP2q5Bf6aqkOlGeo4OjCxjViIk8PdBCeT2fdHxR4Lb5fD9SioN4GpRX+ud2hbnX6bybATtNfxDJiEnE5hPtcql0SAS7RuBdGd4XVwsA+oS9RMCztoBVNPjW6xIiejUezLGNtyXtQc0JYzWXmaMuU6zDjM/Pw8lu6ijC/mnABAQqc4c/W4h+uYgm0R0pKu9GY8/OPZeVchh4Ie4TJ5ZKu8OVJBLbXpwyhYesyFxXmyxOBahtXHKJhdlQ9OnB2Oqvou/OLQIQ7o2wBZWDejWBh5Rbh5f7gEPGWWOHijjha4SOkqRa7rbNnYknih7mF/CaZ74MpW6jcwjqvOCJFmHlQa/W1N77aT4E4n/J9a2RNv/qW55ZPx5WY6jG9pTU190g9gP0lB8ZJQahHlSDPbOIbKQlVjzdSClvX51lPf8pzmmBBlrG8zuvkuR4L82/fi3nl0ZRU2ZpoFG+YuB3nBFeL3N/WEBXMCGJNAyLtPP7ZAExIsguIlMefNtmfA7oM4rT1kfhi3aj58NgZCrWxgWNMt7QMgH/SoyjsQrUvf0rqWL3XDFbyp3sp4ubs2glS3Fxhce+9vj1R5UcGeTE9SodhsleUsy094DAr8I4RCHytBgMgju4RyRjf5xF6jsclo9d2XekODnR41K788kJyYg66I+ePDaTDRBtrcUAwPEnpdCc991Sggc8xGWNebZEaURAwgf8Gr3GfyvXQv3y5ITvZjmj2KfR+DXCvBRYYWQzlLUtgogfHeYIjUJwHGOxJ5HCwCqicf86ZNqmgWVObLfTZpbYcxqN+IBqcXN8nO0N90eWgHXP PEaY/9q/ LyQPGFsRKu0w4nQWGQIZyK879HELNUP1QM1Cjz6KZuCEzyBIXE3Ar1qSYpisTgkDcZOJ8l+slqGrFXJcvt1Kc7a/tc3SOS+TaPLXVklCL++CqB5rCxgQ8tdoTyYPUqUKm/JdHLn8CTh62jYzgd0En5Bi9A/3RbjHOBza/2pWOZqDiACfXnl+9DMuM9Otkr7I4bX4qzgH3z9J+qL0x1HnTTYJGSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Thu, Apr 03, 2025 at 09:24:34PM -0400, Waiman Long wrote: ... > The simple and naive fix of changing the operator to ">", however, > changes the memory reclaim behavior which can lead to other failures > as low events are needed to facilitate memory reclaim. So we can't do > that without some relatively riskier changes in memory reclaim. I'm doubtful using ">" would change reclaim behavior in a meaningful way and that'd be more straightforward. What do mm people think? Thanks. -- tejun