From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67771C36010 for ; Fri, 4 Apr 2025 20:09:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA4ED6B0011; Fri, 4 Apr 2025 16:09:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A524B6B0012; Fri, 4 Apr 2025 16:09:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 942BE6B0022; Fri, 4 Apr 2025 16:09:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 75AF16B0011 for ; Fri, 4 Apr 2025 16:09:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 665331208B3 for ; Fri, 4 Apr 2025 20:09:53 +0000 (UTC) X-FDA: 83297452266.17.538BC4F Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf07.hostedemail.com (Postfix) with ESMTP id D958D4000A for ; Fri, 4 Apr 2025 20:09:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kV79duNv; spf=pass (imf07.hostedemail.com: domain of tj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743797391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D9l8CYpbXYrsN7IVuN7RA420bGuwCcVnaFLnhYTCuwQ=; b=lalhn3Jd/XRkK+HwB83T0mx2HvsY3VJNggB5N/ccKtmsDe9puJFUoo5WA/BOLybVlE7TiK shsaC2W97VJX7tdJ6JQq8ypeITlRhgqw1/TyHTgWc6MVyIORVP774GBA/kx/kYJg1ESQaA RRMc/UKAUl77A+gTl1da779mrv/rV0g= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kV79duNv; spf=pass (imf07.hostedemail.com: domain of tj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743797391; a=rsa-sha256; cv=none; b=1qrxWmcp3zCfkFnlnu3CwXJyrwsVa1XQOzDFGRD3Lhht3WvcJjhz1ALwUOG0saMTVXPWk6 WJEKSUs6XCkjY9xuHZl2+PmieFb4u3brJ9EtmFPOQeneeKsDWy+Nn9RcED4gio1YhhEMmh utt8B7iXccZxhGK3E/f4hp49SSL2hZg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id AAE3761135; Fri, 4 Apr 2025 20:09:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB121C4CEDD; Fri, 4 Apr 2025 20:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743797390; bh=5MKQFTnc4HH4IcmQJ8cqBJBgkSr327R+5PevCPCJrkg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kV79duNv4MRvBZs2fARTvmvWbf3CoRvQX0SPG/STX4ksvgy7GrLD4Rbsp7dpEw79w WFCZTioDYUuaLSP2Embi2jIJfH/ClBH7r8Rwjt73W346l3L0mSBlyFQudN+AMrhgOO gv4laNnY9fZ/mEno2jbaWvPn209vdugsd4NxHf2SOZ5Zat1olVIHuywUKv22e4YYiE 8QMkhzzFHwWcM0LK4OGOBEpnkIq6JVl0NliT5gWFwWPuHDmOa8FnVw1PEgerb4XeH4 qH3aR8NgHwcfbBiS4qT4jUP4sIZ+VBEsuxmBGMbKgxXr4R5OW/0dV2ry4NrwmwKm3S ZsQ6O8TYjKgQA== Date: Fri, 4 Apr 2025 10:09:49 -1000 From: Tejun Heo To: JP Kobryn Cc: shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 3/5] cgroup: change rstat function signatures from cgroup-based to css-based Message-ID: References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-4-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D958D4000A X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: jtmf3sqo8qcmdf9nbjjuib5wgik3jjkn X-HE-Tag: 1743797391-340882 X-HE-Meta: U2FsdGVkX19lqqqJxsLQeNqBqIY351+uNB0hfde/vz+0wnfAIeLxbTY7cx6/JsbgvC5DIM9LmsAfqtOy8eH52U/VKlBKMGgMZB5PpjvXzb4mRYygUK3qqYW//83G2ermPJepK/REeYiMieqS3AipIIm1fNDV6DOtChdskGbX6n/nQIT+BsAsk5g2kTp+SKGFs++eJW97pMKTXzYY5CZhp5/HlVJwAjBcDsZ3Em9NySCwyDZlrxnmKC7ELBzxRGQ8S5B5Jv22K7ylp4o5FY5z6VzlXQKI/vGElZMROxIHqcBDjz8WWYHyoKr5tVmGVweM5IR60ICUYo3yUPU/b9wA81T3O/RkXrlbg/3San0sTaq+j3aX/s1AIzK5f8rdmTBIqWZYkO0YIcOaMCMM9DJPi1xrNCKasCVHR27D4G4/N3USSibCVv7PT0G7KCa5R3MxlQcJrWOJXvhKSMYHwJHHFqqO3dYlqRUepdke3wzvAQD5QIzAJlVgLLXIwLz7kgQ+Pi4zSqtZsGQgozL1qUGySgN5J0uRijYJ67M1Zg4a9+TAO2kvQ0eqJUCnhw2tqLD5QqX4U9Z68neR2ZbE0KTdVmFjMKR1eiph+4iFOr80KYAUjFCRtsIQxujfpeYcRE2FAH2ZuRJnATXTiOkoqiPifLpz2NUmhrRgfWgfap1jNzsvodMMJAPMv0BKP7tffcyKRPrFlGOFzqFd7Z8TbVs5vjgeEp9TFlinw7HVHEl+zgVTy8xyL3tjoMnsThqnx/J62KsQlE3pKO1sM4ybsOOTwLxrdjnaHWZ4n/KYjtC5g6q/fc2HeLdZkbZWgQccgX1YikmrS77ox5WYt6WyoUhxUd/jTmM9nFyrtWJjatdy1hkVCzrpaJMNI6StLb7NDeFk3QgMLn4x3eqF6K2rtX+cV7RqqACcQTDKUmRkL++HJ2cP4/U6tW8PMA98adz4LieK/8Nk75ifWkDJMJ/gzfI +jmmUyDG dOkxwmwQIOYPML6kws8T40CVifexIlNx4cXTfuVKz8t19gRqKsM2EG2GMCUR8CE3vRQ6f0o9g4RO9UnyVk9OyvCD9PHuo0Y4zOnkA8GbH68+bkaL+A0Sk5IZSuvry+U3abcu2aY/4NTdtE7Mdw33kuWdTuugqQ1J7loPyXM39V2R6hzWX8SEb2e0pQaZne4VSmxOmEk99i70oLM6eC5wuMBItz210hde6BWPtjBZ/NWK9cHjoxaprYFrnOHXyDUVorSry X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 04, 2025 at 10:00:25AM -1000, Tejun Heo wrote: > On Thu, Apr 03, 2025 at 06:10:48PM -0700, JP Kobryn wrote: > > This non-functional change serves as preparation for moving to > > subsystem-based rstat trees. To simplify future commits, change the > > signatures of existing cgroup-based rstat functions to become css-based and > > rename them to reflect that. > > > > Though the signatures have changed, the implementations have not. Within > > these functions use the css->cgroup pointer to obtain the associated cgroup > > and allow code to function the same just as it did before this patch. At > > applicable call sites, pass the subsystem-specific css pointer as an > > argument or pass a pointer to cgroup::self if not in subsystem context. > > > > Note that cgroup_rstat_updated_list() and cgroup_rstat_push_children() > > are not altered yet since there would be a larger amount of css to > > cgroup conversions which may overcomplicate the code at this > > intermediate phase. > > > > Signed-off-by: JP Kobryn > > Applied 1-3 to cgroup/for-5.16. There were some conflicts with the commits already in cgroup/for-5.15-fixes. I resolved them but it'd be great if you can verify that I didn't do anything silly. git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-6.16 Thanks. -- tejun