From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0754FC36010 for ; Fri, 4 Apr 2025 20:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEE0E6B0008; Fri, 4 Apr 2025 16:00:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9BB36B000A; Fri, 4 Apr 2025 16:00:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8C7E6B000C; Fri, 4 Apr 2025 16:00:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8B2F86B0008 for ; Fri, 4 Apr 2025 16:00:30 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0AF151C981B for ; Fri, 4 Apr 2025 20:00:30 +0000 (UTC) X-FDA: 83297428620.28.2C30D4B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 5286640012 for ; Fri, 4 Apr 2025 20:00:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lwNoKRvX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of tj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743796828; a=rsa-sha256; cv=none; b=RnL8yJj697sAxUA0AG9ilY6V6b+17jFrisDSLYeNqxQao6+YmzV5U4qd/rOiPGss7b9X/0 FkgGy9pPs6vxCIZYlfBBDtgTQMHYci1CtQrfnIFtq4KO9O6tGtqo0k4X96X7k9vKxWUfLF IBZrz+JV0RIlky4b73nlW4yfttQZhTY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lwNoKRvX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of tj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743796828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5PXcA0TMs8dlUv3o4HvW8M0ERzpjDohIMOQsUy1BKh8=; b=ngYbmeVPTCy7l7vHTcFh+mWEC3SLgH2Wwi9weYsrxc9mSNSaagHZiQmLAqyYjd8tyUULXv 9gCKv31uccLwRTXvhxS6fTE0yeBTDAsKvVSJ2kfcQmRBELkf58CyMADlwHsND2H+y752Yj 8vZZo84XiDwa4zgQU0nhCkYF7rZNjOk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1AE115C4251; Fri, 4 Apr 2025 19:58:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE497C4CEDD; Fri, 4 Apr 2025 20:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743796826; bh=youZVDSXWxqPeudTSAYG+CS7IXwWVZhbzznDqGM8d8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lwNoKRvXMYm3seTbKqwJUlf/HLvj3LAOf8r1PrexfOqgjwSF1bqMAiuzlOVcFK52X 2Q/FbmtqS1hYzQnDgnDg8BvWDDF4DlpyYAGmCRSBz0UxOZhxigYgC1l7YrPywHmDTW 5nYJ+XOdD/YPmeRGXWhaWjYZz4ZKan19DPI/yF8NhMICYnjk0gedw/Ol/qdJle7saK N2krKhEtIG95PLKHF0o+31PEW3PAGmNGaQGYsdTyHZQjlfRcR3JJ3EgFaLDaPpGZvg b3KZO6sEc1F4mNV5h6taDCiaGX7BW0Q9irZ8/DI10hazvfbwPpxqSQ5comajD3CREH 5ODDvGhlUqhPg== Date: Fri, 4 Apr 2025 10:00:25 -1000 From: Tejun Heo To: JP Kobryn Cc: shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 3/5] cgroup: change rstat function signatures from cgroup-based to css-based Message-ID: References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-4-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250404011050.121777-4-inwardvessel@gmail.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5286640012 X-Stat-Signature: udgpkrjg5x1x8tjfm4t4txk5p4pwq7d5 X-Rspam-User: X-HE-Tag: 1743796828-102533 X-HE-Meta: U2FsdGVkX19PP7JZsL1BKgPCtvmIb2279xmerYLD/izkHPLolTIO3j+t2eBMcQofTmxxV4hmcatacImn1pbR54+64iInpDI+dCRHXGwxZUvU6rXe2D116kyXCj3NVeRFbtyQBl/YLPnxAost8rfpWkvcNaZ6+3npoqKe7w/ao6MsPtPYHVTZKOvFrtoFj1CWRAXYNvtTe7F/saIT/JbdwX7/3gSbYBOsA1v0VOnps7S2ny+Cf7ISzVqM+lS1jyc1DOJQqEYoKfeSr0IsmjRiLOzsMgpqU3thIZ7yoK+XDFWjmqUg4U6sAAGt2Yfrm/Js8P/hn9J0zxeeroKPARCR+Xpg8dTJMc20BYognbIprk3iDhZKa07r97rSONRergGzFsTvSwtiSL6kYVI7nE1ouM68eE8J0MSFtzcCkNy5SMwoqd6PNTKcBLARbmVHMo0cb2j8DdcS7djRx3ynXMMezqB3CCmFf2dwpJWWOSPOCqk0OxAiq6Sjm87qswZIuNJ5zWXvAk3n0O2Abw/7k6WjbvV4W6rQ4xg2pFuYp5L9wRH1gYBuUxF6pnheAOtXqrbvfpO8fgGq0Tu8ckpqvHvHYVNh8bvj4229vY+h2EU3B3Uhbzgik1bb/uqsylP7+u2pS1mPiFLXuUGi4wu3CA2v1lIoM20FcYnW6BypnszFjfRH1sbV0obfqMK5lTVBvHNoV/SDngI6A4XKHoS1n6rZYLv+es908E/1MZGDQHZTMVqJaKEOTAZet4f+adEeCAvUPRHpT4aNyGSICV7hbb8+Oa7dA6HpvKIobKZjkjBr5GItzia5jt1sgtWi50AOq9rELwV2+0pbk9ZHT+2LK3Jd+fGkhslYfmREWwlhD9eW/vpxCBSFkeUYZZE47iXz16ZU+se2tEPCi3gyUFzIL7x37Z1eYqzSMFFSyKiKFSoNf9NQlzvEqCbqDbO3Ptku1aEHXj3ei81ryc0FIl2Y8HL 9+nRxI4/ zPGv6vNfuBKy6wnFcr3ot9CzzVKVnm4oUgGgdjPCAjsN5Xb38JW1RGAA8ilhoHS/moTpwYyW8qRhbZsfq/B7vbRG7gqsIwRpYlyrph6x9TOqqqtXkOSIZYovSB0ONSfj+xv/93pGlDHtRMm/Yc++oBeNWnsmGRSoq5q+z5HiC0uf223NUDR7mVom0MNLGL8X3ygBX88gC3x5G61IbXWkNVGrNQEB7ji3xMe+PEwS3olDEpfM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 03, 2025 at 06:10:48PM -0700, JP Kobryn wrote: > This non-functional change serves as preparation for moving to > subsystem-based rstat trees. To simplify future commits, change the > signatures of existing cgroup-based rstat functions to become css-based and > rename them to reflect that. > > Though the signatures have changed, the implementations have not. Within > these functions use the css->cgroup pointer to obtain the associated cgroup > and allow code to function the same just as it did before this patch. At > applicable call sites, pass the subsystem-specific css pointer as an > argument or pass a pointer to cgroup::self if not in subsystem context. > > Note that cgroup_rstat_updated_list() and cgroup_rstat_push_children() > are not altered yet since there would be a larger amount of css to > cgroup conversions which may overcomplicate the code at this > intermediate phase. > > Signed-off-by: JP Kobryn Applied 1-3 to cgroup/for-5.16. Thanks. -- tejun